linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: jikos@kernel.org
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
	Paul Pawlowski <paul@mrarm.io>, Aun-Ali Zaidi <admin@kodeit.net>,
	Aditya Garg <gargaditya08@live.com>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: [PATCH 1/7] HID: apple: remove unused members from struct apple_sc_backlight
Date: Thu,  1 Feb 2024 12:53:14 +0100	[thread overview]
Message-ID: <20240201115320.684-2-jirislaby@kernel.org> (raw)
In-Reply-To: <20240201115320.684-1-jirislaby@kernel.org>

The backlight members in struct apple_sc_backlight are unused. They were
added in commit 9018eacbe623 (HID: apple: Add support for keyboard
backlight on certain T2 Macs.), but never used.

As this is not a struct to communicate with the HW, remove these.

Found by https://github.com/jirislaby/clang-struct.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Paul Pawlowski <paul@mrarm.io>
Cc: Aun-Ali Zaidi <admin@kodeit.net>
Cc: Aditya Garg <gargaditya08@live.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
 drivers/hid/hid-apple.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
index b9c7c0ed7bcc..bd022e004356 100644
--- a/drivers/hid/hid-apple.c
+++ b/drivers/hid/hid-apple.c
@@ -79,7 +79,6 @@ struct apple_non_apple_keyboard {
 struct apple_sc_backlight {
 	struct led_classdev cdev;
 	struct hid_device *hdev;
-	unsigned short backlight_off, backlight_on_min, backlight_on_max;
 };
 
 struct apple_sc {
-- 
2.43.0


  reply	other threads:[~2024-02-01 11:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01 11:53 [PATCH 0/7] HID: unused struct members cleanup Jiri Slaby (SUSE)
2024-02-01 11:53 ` Jiri Slaby (SUSE) [this message]
2024-02-14 12:54   ` [PATCH 1/7] HID: apple: remove unused members from struct apple_sc_backlight Aditya Garg
2024-02-01 11:53 ` [PATCH 2/7] HID: wacom: remove unused hid_data::pressure Jiri Slaby (SUSE)
2024-02-02  2:30   ` Ping Cheng
2024-02-01 11:53 ` [PATCH 3/7] HID: protect hid_device::bpf by CONFIG_HID_BPF Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 4/7] HID: hid-lg3ff: remove unused struct lg3ff_device Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 5/7] HID: hid-multitouch: remove unused mt_application::dev_time Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 6/7] HID: hid-prodikeys: remove unused struct pcmidi_snd members Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 7/7] HID: hid-prodikeys: remove struct pk_device Jiri Slaby (SUSE)
2024-02-13 10:44 ` [PATCH 0/7] HID: unused struct members cleanup Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240201115320.684-2-jirislaby@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=admin@kodeit.net \
    --cc=benjamin.tissoires@redhat.com \
    --cc=gargaditya08@live.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@mrarm.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).