Requesting 3 patches for Apple Magic Keyboard 2021 to be merged to LTS kernels

Requesting 3 patches for Apple Magic Keyboard 2021 to be merged to LTS kernels

[Aseda Aboagye]

Dear stable kernel maintainers,

I am writing to request that 3 related patches be merged to various LTS kernels. I'm not sure if it would have
been preferable for me to send 3 separate emails, so please forgive me if I chose wrongly. (This is my first foray
into interacting with the kernel community) :)

The patches are as follows:

    1. 0cd3be51733f (HID: apple: Add support for the 2021 Magic Keyboard, 2021-10-08)
    2. 346338ef00d3 (HID: apple: Swap the Fn and Left Control keys on Apple keyboards, 2020-05-15)
    3. 531cb56972f2 (HID: apple: Add 2021 magic keyboard FN key mapping, 2021-11-08)

These patches have all been merged to mainline, but I believe when they were submitted, backporting may not have been considered. The Apple Magic Keyboard 2021 (Model # A2450) seems to be a popular keyboard, and without these
patches, for users on certain LTS kernels that use this keyboard, the function keys do not behave as expected. e.g. Pressing the brightness down or brightness up key didn't work, and bizarrely pressing the globe/Fn key alone caused the brightness to decrease. None of the top row keys worked as expected.

I checked to see where the patches were missing and figured that it would be good to have those patches in those
kernels.

I would ask that patches 1 & 3 be merged to v4.19, v5.4, v5.10, and v5.15.
I would ask that patch 2 be merged to: v5.4 and v4.19.

For patch 3 to apply cleanly, it needed patch 2 to be present in the tree.


Thanks,

--
Aseda Aboagye

Re: Requesting 3 patches for Apple Magic Keyboard 2021 to be merged to LTS kernels

[Greg KH]

On Fri, Feb 02, 2024 at 08:45:40PM -0600, Aseda Aboagye wrote:
> Dear stable kernel maintainers,
> 
> I am writing to request that 3 related patches be merged to various LTS kernels. I'm not sure if it would have
> been preferable for me to send 3 separate emails, so please forgive me if I chose wrongly. (This is my first foray
> into interacting with the kernel community) :)
> 
> The patches are as follows:
> 
>     1. 0cd3be51733f (HID: apple: Add support for the 2021 Magic Keyboard, 2021-10-08)
>     2. 346338ef00d3 (HID: apple: Swap the Fn and Left Control keys on Apple keyboards, 2020-05-15)
>     3. 531cb56972f2 (HID: apple: Add 2021 magic keyboard FN key mapping, 2021-11-08)
> 
> These patches have all been merged to mainline, but I believe when they were submitted, backporting may not have been considered. The Apple Magic Keyboard 2021 (Model # A2450) seems to be a popular keyboard, and without these
> patches, for users on certain LTS kernels that use this keyboard, the function keys do not behave as expected. e.g. Pressing the brightness down or brightness up key didn't work, and bizarrely pressing the globe/Fn key alone caused the brightness to decrease. None of the top row keys worked as expected.
> 
> I checked to see where the patches were missing and figured that it would be good to have those patches in those
> kernels.
> 
> I would ask that patches 1 & 3 be merged to v4.19, v5.4, v5.10, and v5.15.
> I would ask that patch 2 be merged to: v5.4 and v4.19.
> 
> For patch 3 to apply cleanly, it needed patch 2 to be present in the tree.

I've done so now, but really, adding support for a keyboard that wasn't
even out when the kernel was released is odd, why not just use a newer
kernel version?  That's generally a good idea for all consumer devices,
use the latest stable kernel please.

thanks,

greg k-h

Re: Requesting 3 patches for Apple Magic Keyboard 2021 to be merged to LTS kernels

[Aseda Aboagye]

> On Fri, Feb 02, 2024 at 08:45:40PM -0600, Aseda Aboagye wrote:
>> Dear stable kernel maintainers,
>>
>> I am writing to request that 3 related patches be merged to various LTS kernels. I'm not sure if it would have
>> been preferable for me to send 3 separate emails, so please forgive me if I chose wrongly. (This is my first foray
>> into interacting with the kernel community) :)
>>
>> The patches are as follows:
>>
>>     1. 0cd3be51733f (HID: apple: Add support for the 2021 Magic Keyboard, 2021-10-08)
>>     2. 346338ef00d3 (HID: apple: Swap the Fn and Left Control keys on Apple keyboards, 2020-05-15)
>>     3. 531cb56972f2 (HID: apple: Add 2021 magic keyboard FN key mapping, 2021-11-08)
>>
>> These patches have all been merged to mainline, but I believe when they were submitted, backporting may not have been considered. The Apple Magic Keyboard 2021 (Model # A2450) seems to be a popular keyboard, and without these
>> patches, for users on certain LTS kernels that use this keyboard, the function keys do not behave as expected. e.g. Pressing the brightness down or brightness up key didn't work, and bizarrely pressing the globe/Fn key alone caused the brightness to decrease. None of the top row keys worked as expected.
>>
>> I checked to see where the patches were missing and figured that it would be good to have those patches in those
>> kernels.
>>
>> I would ask that patches 1 & 3 be merged to v4.19, v5.4, v5.10, and v5.15.
>> I would ask that patch 2 be merged to: v5.4 and v4.19.
>>
>> For patch 3 to apply cleanly, it needed patch 2 to be present in the tree.
> 
> I've done so now, but really, adding support for a keyboard that wasn't
> even out when the kernel was released is odd, why not just use a newer
> kernel version?  That's generally a good idea for all consumer devices,
> use the latest stable kernel please.
> 

Thank you so much Greg! Yes, that would be the ideal, using a newer kernel. Our
team is in the process of updating the kernel version for our devices, but it's
a long process with many devices and hence wanting to get a fix in the interim.
Our goal is to eventually continuously ship the latest stable kernel versions.

Thanks,

--
Aseda Aboagye

> thanks,
> 
> greg k-h
>