* [PATCH][next] input: ti_am335x_tsc: remove redundant assignment to variable config
@ 2024-02-05 21:59 Colin Ian King
2024-02-09 18:53 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2024-02-05 21:59 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input; +Cc: kernel-janitors, linux-kernel
The variable config is being initialized with a value that is never
read, it is being re-assigned in the next statement. The initialization
is redundant and can be removed.
Cleans up clang scan build warning:
drivers/input/touchscreen/ti_am335x_tsc.c:160:2: warning: Value stored
to 'config' is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/input/touchscreen/ti_am335x_tsc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
index 34324f8512ac..294b7ceded27 100644
--- a/drivers/input/touchscreen/ti_am335x_tsc.c
+++ b/drivers/input/touchscreen/ti_am335x_tsc.c
@@ -157,7 +157,6 @@ static void titsc_step_config(struct titsc *ts_dev)
n++ == 0 ? STEPCONFIG_OPENDLY : 0);
}
- config = 0;
config = STEPCONFIG_MODE_HWSYNC |
STEPCONFIG_AVG_16 | ts_dev->bit_yn |
STEPCONFIG_INM_ADCREFM;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] input: ti_am335x_tsc: remove redundant assignment to variable config
2024-02-05 21:59 [PATCH][next] input: ti_am335x_tsc: remove redundant assignment to variable config Colin Ian King
@ 2024-02-09 18:53 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2024-02-09 18:53 UTC (permalink / raw)
To: Colin Ian King; +Cc: linux-input, kernel-janitors, linux-kernel
On Mon, Feb 05, 2024 at 09:59:40PM +0000, Colin Ian King wrote:
> The variable config is being initialized with a value that is never
> read, it is being re-assigned in the next statement. The initialization
> is redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/input/touchscreen/ti_am335x_tsc.c:160:2: warning: Value stored
> to 'config' is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-09 18:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-05 21:59 [PATCH][next] input: ti_am335x_tsc: remove redundant assignment to variable config Colin Ian King
2024-02-09 18:53 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).