From: Greg KH <gregkh@linuxfoundation.org>
To: Edward Adam Davis <eadavis@qq.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, rafael@kernel.org,
syzbot+8e41bb0c055b209ebbf4@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH riscv64] kobject: fix WARNING in input_register_device
Date: Tue, 13 Feb 2024 08:21:18 +0100 [thread overview]
Message-ID: <2024021356-unveiling-falcon-54db@gregkh> (raw)
In-Reply-To: <tencent_9D9878866FF42C756D2C94DCEA36EC26CE0A@qq.com>
On Tue, Feb 13, 2024 at 08:50:01AM +0800, Edward Adam Davis wrote:
> On Thu, 8 Feb 2024 12:25:35 +0000, Greg KH wrote:
> > On Thu, Feb 08, 2024 at 07:37:56PM +0800, Edward Adam Davis wrote:
> > > On Thu, 8 Feb 2024 10:56:00, Greg KH wrote:
> > > > > The input_add_uevent_modalias_var()->input_print_modalias() will add 1684 bytes
> > > > > of data to env, which will result in insufficient memory allocated to the buf
> > > > > members of env.
> > > >
> > > > What is "env"? And can you wrap your lines at 72 columns please?
> > > env is an instance of struct kobj_uevent_env.
> >
> > Also, why is "risc64" in the subject line?
> Because when syzbot reported this issue, it wrote "userspace arch: riscv64".
> However, I actually tested it on the master branch of upstream.
Then of course, this was not correct in the subject line.
thanks,
greg k-h
next prev parent reply other threads:[~2024-02-13 7:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 19:54 [syzbot] [input?] [usb?] WARNING in input_register_device (2) syzbot
2024-02-08 10:46 ` [PATCH riscv64] kobject: fix WARNING in input_register_device Edward Adam Davis
2024-02-08 10:56 ` Greg KH
2024-02-08 11:37 ` Edward Adam Davis
2024-02-08 12:25 ` Greg KH
2024-02-13 0:43 ` Edward Adam Davis
2024-02-13 7:20 ` Greg KH
2024-02-13 13:10 ` Edward Adam Davis
2024-02-08 12:25 ` Greg KH
2024-02-13 0:50 ` Edward Adam Davis
2024-02-13 7:21 ` Greg KH [this message]
2024-02-13 13:13 ` Edward Adam Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024021356-unveiling-falcon-54db@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=eadavis@qq.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=syzbot+8e41bb0c055b209ebbf4@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).