From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F7C2604CE; Mon, 11 Mar 2024 18:38:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710182291; cv=none; b=j+BxV8sRRPIpjfsE/SLgGv7NQ8245YmzxdvvLltD6iKTwpOIv0ufA/FSE/B6FWNh2IYh1haOK3n311fs+umA2GX3pAHqlqsyvdulqU/lKuM09B6DnHCiMkvzqZG0yPeHvJFfSUmXbQIK0a0NA98IAby6/Ru0rF17RSPWAUsVQVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710182291; c=relaxed/simple; bh=a90TlNcd55CuvJI7AGBcJt7/5SipQJTr/jE8uvYuenY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=P5wPRZh7MfQ65CuBjxb29WDHTnpVe4cRyG69t51/k7SshkmrMbB9yYmTmbxLQAFCNEIiSjmGJFO5ByMxG9jBJR5VwYF96piQMUQId5zRfvmR2+Nsgr4ev+rMW985jpLUvra5AHvjABwEUlEfJz+XJijA32ehl6FmpjkNqahauB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sclpDytX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sclpDytX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E31FC433C7; Mon, 11 Mar 2024 18:38:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710182291; bh=a90TlNcd55CuvJI7AGBcJt7/5SipQJTr/jE8uvYuenY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sclpDytXvxJJgnfLy1DOHqAmUL/6l9sMXipjXNwKFLeULcgtmVMKf6Y0A+rnkE2+b VWTY2H5TzIr8TH75rdAuzhk8ruFq7njz6WXd+FB5Irws/c9Ak6ZdmAWG4oXBc5QNwc uDY4SdDzq3t9RXsCLUChHuQqm7zzYLpf5cvAVzereXt50uU4TqeQvGHDyD+HTH/dko jNpoEB4h7c2ztKUYU3doaEZlNX8AWwHqpym6L2zGIM07quxkZU9/apC3zqwkIYjAP0 SjjkIhBKsgjxfPAQOM7zIZvaJVkvO30ZJ5ohfpsPzoW45oQ0iOC8E6ztY/n+2R2xy5 y9tdMQgYSahJw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Linus Walleij , Dmitry Torokhov , Sasha Levin , linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 6.6 09/12] Input: gpio_keys_polled - suppress deferred probe error for gpio Date: Mon, 11 Mar 2024 14:37:23 -0400 Message-ID: <20240311183727.328187-9-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240311183727.328187-1-sashal@kernel.org> References: <20240311183727.328187-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.21 Content-Transfer-Encoding: 8bit From: Uwe Kleine-König [ Upstream commit 963465a33141d0d52338e77f80fe543d2c9dc053 ] On a PC Engines APU our admins are faced with: $ dmesg | grep -c "gpio-keys-polled gpio-keys-polled: unable to claim gpio 0, err=-517" 261 Such a message always appears when e.g. a new USB device is plugged in. Suppress this message which considerably clutters the kernel log for EPROBE_DEFER (i.e. -517). Signed-off-by: Uwe Kleine-König Reviewed-by: Linus Walleij Link: https://lore.kernel.org/r/20240305101042.10953-2-u.kleine-koenig@pengutronix.de Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/keyboard/gpio_keys_polled.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c index ba00ecfbd343b..b41fd1240f431 100644 --- a/drivers/input/keyboard/gpio_keys_polled.c +++ b/drivers/input/keyboard/gpio_keys_polled.c @@ -315,12 +315,10 @@ static int gpio_keys_polled_probe(struct platform_device *pdev) error = devm_gpio_request_one(dev, button->gpio, flags, button->desc ? : DRV_NAME); - if (error) { - dev_err(dev, - "unable to claim gpio %u, err=%d\n", - button->gpio, error); - return error; - } + if (error) + return dev_err_probe(dev, error, + "unable to claim gpio %u\n", + button->gpio); bdata->gpiod = gpio_to_desc(button->gpio); if (!bdata->gpiod) { -- 2.43.0