From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BAF317736; Sun, 24 Mar 2024 12:16:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711282583; cv=none; b=sxJjnqvzht+EhMCxf8AlsZqOjkr9afx/alwQ2taRaxDhAWQwIlZL52oToxQScz8OYB1KPTDWv+EjaJx58Eu2Eqrp9V3YC1oiI+3W2RcdRKRs/wM9PRZY2d2ddXeRYT1VqpW0iJ2V+w3deZJxGWfZIY+C6qJnY32266pQHl1IBRA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711282583; c=relaxed/simple; bh=PXRDCrEc+u0PcMCf601WouC7laGk8s3Xs3CLxtUdZV8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WV0wIzW3YzFzTw1W3pxlXFGoM5RCnvZL0D7kS0kSjJ+aeDtq2xYRJVOIU9Bwt8u2YBLdl0RCOJiG9cjV2UdObQ7o/sml8N7h+DCbiCNDEpHxiFtEgOeQCJhm0qPFXXSUqrlQEIcfyrqHz/1Ac5rZ28kHiw2ACt61yQq5lJsTJgM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W2IbvpxJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W2IbvpxJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF9ABC433F1; Sun, 24 Mar 2024 12:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711282583; bh=PXRDCrEc+u0PcMCf601WouC7laGk8s3Xs3CLxtUdZV8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=W2IbvpxJguEvyynQn3fQMmrclzMYGYbmKLk7n4wJSDydWgpdywkTh+AAKPWM5ye1o 9A2VvfuhQSU5DKJvfFksMKWi/lU5r6UEPJYvc8f5RCDMQUIvHw0GGOPuILFrGoAhfe KarfpwLVN1J0oflthQ21t0kb2QTCRK4xZbTgXhFiD7cNWTdbM4nynxp1wmqOaHBENc 6pWqkarUElQRuAIZDBMASCe/R/GYQTygjl24O7sGU4BV15egclY5HVq514VahafcDF dII1OZzGBkzI88iKqRlDoyGqHMvQ5kkvDj6xLjEb5HeCE02AOk5ZNRLhvsFUhnfJzy sxRI+wF7FrXBA== Date: Sun, 24 Mar 2024 12:16:08 +0000 From: Jonathan Cameron To: Li Zhijian Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Srinivas Pandruvada , Benjamin Tissoires , linux-input@vger.kernel.org, linux-iio@vger.kernel.org, Jonathan Cameron Subject: Re: [PATCH v4 2/4] HID: hid-sensor-custom: Convert sprintf() family to sysfs_emit() family Message-ID: <20240324121608.30b2217b@jic23-huawei> In-Reply-To: <20240319054527.1581299-2-lizhijian@fujitsu.com> References: <20240319054527.1581299-1-lizhijian@fujitsu.com> <20240319054527.1581299-2-lizhijian@fujitsu.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 19 Mar 2024 13:45:25 +0800 Li Zhijian wrote: > Per filesystems/sysfs.rst, show() should only use sysfs_emit() > or sysfs_emit_at() when formatting the value to be returned to user space. > > coccinelle complains that there are still a couple of functions that use > snprintf(). Convert them to sysfs_emit(). > > sprintf() and scnprintf() will be converted as well if they have. > > Generally, this patch is generated by > make coccicheck M= MODE=patch \ > COCCI=scripts/coccinelle/api/device_attr_show.cocci > > No functional change intended > > CC: Jiri Kosina > CC: Jonathan Cameron > CC: Srinivas Pandruvada > CC: Benjamin Tissoires > CC: linux-input@vger.kernel.org > CC: linux-iio@vger.kernel.org As a general rule, don't have cc's of lists up here. It makes a mess of the logs. Also once you have another tag drop CC of same person (even if it's a different email address). We don't want to fill the git log with useless information. I think git is fine picking up CC's from below the --- so you can add them there if it simplifies how you send your patch sets out. > Reviewed-by: Jonathan Cameron > Signed-off-by: Li Zhijian > --- > V3: > rewrap the line as will be under 80 chars and add Reviewed-by # Jonathan > This is a part of the work "Fix coccicheck device_attr_show warnings"[1] > Split them per subsystem so that the maintainer can review it easily > [1] https://lore.kernel.org/lkml/20240116041129.3937800-1-lizhijian@fujitsu.com/ > --- > drivers/hid/hid-sensor-custom.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-sensor-custom.c > index d85398721659..ac214777d7d9 100644 > --- a/drivers/hid/hid-sensor-custom.c > +++ b/drivers/hid/hid-sensor-custom.c > @@ -155,7 +155,7 @@ static ssize_t enable_sensor_show(struct device *dev, > { > struct hid_sensor_custom *sensor_inst = dev_get_drvdata(dev); > > - return sprintf(buf, "%d\n", sensor_inst->enable); > + return sysfs_emit(buf, "%d\n", sensor_inst->enable); > } > > static int set_power_report_state(struct hid_sensor_custom *sensor_inst, > @@ -372,14 +372,13 @@ static ssize_t show_value(struct device *dev, struct device_attribute *attr, > sizeof(struct hid_custom_usage_desc), > usage_id_cmp); > if (usage_desc) > - return snprintf(buf, PAGE_SIZE, "%s\n", > - usage_desc->desc); > + return sysfs_emit(buf, "%s\n", usage_desc->desc); > else > - return sprintf(buf, "not-specified\n"); > + return sysfs_emit(buf, "not-specified\n"); > } else > return -EINVAL; > > - return sprintf(buf, "%d\n", value); > + return sysfs_emit(buf, "%d\n", value); > } > > static ssize_t store_value(struct device *dev, struct device_attribute *attr,