Linux Input/HID development
 help / color / mirror / Atom feed
From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
To: jikos@kernel.org
Cc: bentiss@kernel.org, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: [PATCH] HID: Remove the unused variable minor
Date: Sun,  7 Apr 2024 10:28:04 +0800	[thread overview]
Message-ID: <20240407022804.27081-1-jiapeng.chong@linux.alibaba.com> (raw)

Variable minor is not effectively used, so delete it.

drivers/hid/hid-winwing.c:123:15: warning: variable 'minor' set but not used.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8705
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/hid/hid-winwing.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/hid/hid-winwing.c b/drivers/hid/hid-winwing.c
index d895c82a541d..0e224d1a6466 100644
--- a/drivers/hid/hid-winwing.c
+++ b/drivers/hid/hid-winwing.c
@@ -120,7 +120,6 @@ static int winwing_init_led(struct hid_device *hdev,
 static int winwing_probe(struct hid_device *hdev,
 		const struct hid_device_id *id)
 {
-	unsigned int minor;
 	int ret;
 
 	ret = hid_parse(hdev);
@@ -135,8 +134,6 @@ static int winwing_probe(struct hid_device *hdev,
 		return ret;
 	}
 
-	minor = ((struct hidraw *) hdev->hidraw)->minor;
-
 	return 0;
 }
 
-- 
2.20.1.7.g153144c


             reply	other threads:[~2024-04-07  2:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-07  2:28 Jiapeng Chong [this message]
2024-04-12 11:38 ` [PATCH] HID: Remove the unused variable minor Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240407022804.27081-1-jiapeng.chong@linux.alibaba.com \
    --to=jiapeng.chong@linux.alibaba.com \
    --cc=abaci@linux.alibaba.com \
    --cc=bentiss@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox