From: Andre Przywara <andre.przywara@arm.com>
To: Hans de Goede <hdegoede@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev,
James McGregor <jamcgregor@protonmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: input: sun4i-lradc-keys: Add H616 compatible
Date: Tue, 23 Apr 2024 11:15:02 +0100 [thread overview]
Message-ID: <20240423111502.6e068887@donnerap.manchester.arm.com> (raw)
In-Reply-To: <20240422164511.2488261-2-andre.przywara@arm.com>
On Mon, 22 Apr 2024 17:45:10 +0100
Andre Przywara <andre.przywara@arm.com> wrote:
Hi,
> From: James McGregor <jamcgregor@protonmail.com>
>
> The Allwinner H616 SoC has an LRADC which is compatible with the
> versions in existing SoCs.
> Add a compatible string for H616, with the R329 fallback. This is the
> same as the D1, so put them into an enum.
>
> Signed-off-by: James McGregor <jamcgregor@protonmail.com>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Compared the descriptions in the manual between the R392 and the H616, they
look the same:
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
> .../bindings/input/allwinner,sun4i-a10-lradc-keys.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml b/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
> index c384bf0bb25d..8cb5820774e0 100644
> --- a/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
> +++ b/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
> @@ -22,7 +22,9 @@ properties:
> - const: allwinner,sun8i-a83t-r-lradc
> - const: allwinner,sun50i-r329-lradc
> - items:
> - - const: allwinner,sun20i-d1-lradc
> + - enum:
> + - allwinner,sun50i-h616-lradc
> + - allwinner,sun20i-d1-lradc
> - const: allwinner,sun50i-r329-lradc
>
> reg:
next prev parent reply other threads:[~2024-04-23 10:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 16:45 [PATCH 0/2] arm64: dts: allwinner: H616: Add LRADC Andre Przywara
2024-04-22 16:45 ` [PATCH 1/2] dt-bindings: input: sun4i-lradc-keys: Add H616 compatible Andre Przywara
2024-04-23 10:15 ` Andre Przywara [this message]
2024-04-23 12:18 ` Krzysztof Kozlowski
2024-04-23 12:51 ` Andre Przywara
2024-04-23 14:59 ` Krzysztof Kozlowski
2024-04-23 15:14 ` Krzysztof Kozlowski
2024-04-24 10:55 ` Andre Przywara
2024-04-24 17:56 ` Krzysztof Kozlowski
2024-04-23 14:32 ` Rob Herring
2024-04-22 16:45 ` [PATCH 2/2] arm64: dts: allwinner: h616: Add LRADC node Andre Przywara
2024-04-23 10:11 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423111502.6e068887@donnerap.manchester.arm.com \
--to=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jamcgregor@protonmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).