Re: [PATCH 2/2] Input: ektf2127 - add ektf2232 support

Andy Shevchenko
2024-05-02T19:16:39Z

On Thu, May 2, 2024 at 9:58 PM Andreas Kemnade <andreas@kemnade.info> wrote:
>
> The chip is similar, but has status bits at different positions,
> so use the correct bits.

...

> + if (ts->shifted_status) {
> + ektf2127_report2_contact(ts, 0, &buf[1], !!(buf[7] & 1));
> + ektf2127_report2_contact(ts, 1, &buf[4], !!(buf[7] & 2));

BIT(0)
BIT(1)

> + } else {
> + ektf2127_report2_contact(ts, 0, &buf[1], !!(buf[7] & 2));
> + ektf2127_report2_contact(ts, 1, &buf[4], !!(buf[7] & 4));

BIT(1)
BIT(2)

> + }

...

> + if (dev->of_node &&
> + of_device_is_compatible(dev->of_node, "elan,ektf2232"))

if (device_is_compatible(...))

> + ts->shifted_status = true;

--
With Best Regards,
Andy Shevchenko