From: Greg KH <gregkh@linuxfoundation.org>
To: huanglei814 <huanglei814@163.com>
Cc: jikos@kernel.org, bentiss@kernel.org, linux-usb@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
huanglei <huanglei@kylinos.cn>
Subject: Re: [PATCH] HID: usbhid: enable remote wakeup for mouse
Date: Wed, 22 May 2024 13:23:45 +0200 [thread overview]
Message-ID: <2024052218-hull-urology-9ec9@gregkh> (raw)
In-Reply-To: <20240522092257.19373-1-huanglei814@163.com>
On Wed, May 22, 2024 at 05:22:57PM +0800, huanglei814 wrote:
> From: huanglei <huanglei@kylinos.cn>
>
> This patch enables remote wakeup by default for USB mouse
> devices.
That is not a good idea. Please see the mailing list archives for the
past 20+ years for why this is the way it is.
If you know your device can support this, please set it in userspace,
but we can not change the default value at this point in time, sorry.
> Mouse can used to be wakeup devices, but the correct
> place to enable it depends on the device's bus; no single
> approach will work for all mouse devices. In particular, this
> covers only USB mouse (and then only those supporting the boot
> protocol).
And that is really not a wise choice, boot protocol mice have no
requirement that they support remote wakeup. So restricting it like
this really will not help, sorry.
Again, do this in userspace, that's why the interface is there to do so.
greg k-h
next prev parent reply other threads:[~2024-05-22 11:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 9:22 [PATCH] HID: usbhid: enable remote wakeup for mouse huanglei814
2024-05-22 10:00 ` Oliver Neukum
2024-05-24 3:14 ` huanglei
2024-05-22 11:23 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-17 6:01 Qiang Ma
2021-05-17 8:31 ` Oliver Neukum
2021-05-17 13:32 ` Alan Stern
2021-05-17 8:58 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024052218-hull-urology-9ec9@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bentiss@kernel.org \
--cc=huanglei814@163.com \
--cc=huanglei@kylinos.cn \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).