linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Tissoires <bentiss@kernel.org>
To: Shuah Khan <shuah@kernel.org>, Jiri Kosina <jikos@kernel.org>,
	 Jonathan Corbet <corbet@lwn.net>,
	Alexei Starovoitov <ast@kernel.org>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	 bpf@vger.kernel.org, linux-input@vger.kernel.org,
	linux-doc@vger.kernel.org,
	 Benjamin Tissoires <bentiss@kernel.org>
Subject: [PATCH HID v2 16/16] HID: bpf: make part of struct hid_device writable
Date: Fri, 07 Jun 2024 17:28:36 +0200	[thread overview]
Message-ID: <20240607-hid_bpf_struct_ops-v2-16-3f95f4d02292@kernel.org> (raw)
In-Reply-To: <20240607-hid_bpf_struct_ops-v2-0-3f95f4d02292@kernel.org>

It is useful to change the name, the phys and/or the uniq of a
struct hid_device during .rdesc_fixup().

For example, hid-uclogic.ko changes the uniq to store the firmware version
to differentiate between 2 devices sharing the same PID. In the same
way, changing the device name is useful when the device export 3 nodes,
all with the same name.

Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>

---

new in v2
---
 drivers/hid/bpf/hid_bpf_struct_ops.c | 3 +++
 include/linux/hid_bpf.h              | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/bpf/hid_bpf_struct_ops.c b/drivers/hid/bpf/hid_bpf_struct_ops.c
index 944e6d91a36b..14a4c64ae242 100644
--- a/drivers/hid/bpf/hid_bpf_struct_ops.c
+++ b/drivers/hid/bpf/hid_bpf_struct_ops.c
@@ -74,6 +74,9 @@ static int hid_bpf_ops_btf_struct_access(struct bpf_verifier_log *log,
 
 	const struct hid_bpf_offset_write_range write_ranges[] = {
 		WRITE_RANGE(hid_bpf_ctx, retval, 0, 0),
+		WRITE_RANGE(hid_device, name, 0, -1), /* minus 1 to ensure \0 at the end */
+		WRITE_RANGE(hid_device, uniq, 0, -1), /* minus 1 to ensure \0 at the end */
+		WRITE_RANGE(hid_device, phys, 0, -1), /* minus 1 to ensure \0 at the end */
 	};
 #undef WRITE_RANGE
 	const struct btf_type *state = NULL;
diff --git a/include/linux/hid_bpf.h b/include/linux/hid_bpf.h
index 88ab4925bdaa..ff30cbc0a090 100644
--- a/include/linux/hid_bpf.h
+++ b/include/linux/hid_bpf.h
@@ -43,7 +43,7 @@ struct hid_device;
  * ``hid`` and ``allocated_size`` are read-only, ``size`` and ``retval`` are read-write.
  */
 struct hid_bpf_ctx {
-	const struct hid_device *hid;
+	struct hid_device *hid;
 	__u32 allocated_size;
 	union {
 		__s32 retval;

-- 
2.44.0


      parent reply	other threads:[~2024-06-07 15:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-07 15:28 [PATCH HID v2 00/16] HID: convert HID-BPF into using bpf_struct_ops Benjamin Tissoires
2024-06-07 15:28 ` [PATCH HID v2 01/16] HID: rename struct hid_bpf_ops into hid_ops Benjamin Tissoires
2024-06-07 15:28 ` [PATCH HID v2 02/16] HID: bpf: add hid_get/put_device() helpers Benjamin Tissoires
2024-06-07 15:28 ` [PATCH HID v2 03/16] HID: bpf: implement HID-BPF through bpf_struct_ops Benjamin Tissoires
2024-06-07 16:51   ` Alexei Starovoitov
2024-06-08  8:00     ` Benjamin Tissoires
2024-06-07 15:28 ` [PATCH HID v2 04/16] selftests/hid: convert the hid_bpf selftests with struct_ops Benjamin Tissoires
2024-06-07 15:28 ` [PATCH HID v2 05/16] HID: samples: convert the 2 HID-BPF samples into struct_ops Benjamin Tissoires
2024-06-07 15:28 ` [PATCH HID v2 06/16] HID: bpf: add defines for HID-BPF SEC in in-tree bpf fixes Benjamin Tissoires
2024-06-07 15:28 ` [PATCH HID v2 07/16] HID: bpf: convert in-tree fixes into struct_ops Benjamin Tissoires
2024-06-07 15:28 ` [PATCH HID v2 08/16] HID: bpf: remove tracing HID-BPF capability Benjamin Tissoires
2024-06-07 15:28 ` [PATCH HID v2 09/16] selftests/hid: add subprog call test Benjamin Tissoires
2024-06-07 15:28 ` [PATCH HID v2 10/16] Documentation: HID: amend HID-BPF for struct_ops Benjamin Tissoires
2024-06-07 15:28 ` [PATCH HID v2 11/16] Documentation: HID: add a small blurb on udev-hid-bpf Benjamin Tissoires
2024-06-07 15:28 ` [PATCH HID v2 12/16] HID: bpf: Artist24: remove unused variable Benjamin Tissoires
2024-06-07 15:28 ` [PATCH HID v2 13/16] HID: bpf: error on warnings when compiling bpf objects Benjamin Tissoires
2024-06-07 15:28 ` [PATCH HID v2 14/16] bpf: allow bpf helpers to be used into HID-BPF struct_ops Benjamin Tissoires
2024-06-07 15:28 ` [PATCH HID v2 15/16] HID: bpf: rework hid_bpf_ops_btf_struct_access Benjamin Tissoires
2024-06-07 16:57   ` Alexei Starovoitov
2024-06-07 15:28 ` Benjamin Tissoires [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240607-hid_bpf_struct_ops-v2-16-3f95f4d02292@kernel.org \
    --to=bentiss@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=jikos@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).