From: Conor Dooley <conor@kernel.org>
To: Charles Wang <charles.goodix@gmail.com>
Cc: dmitry.torokhov@gmail.com, dan.carpenter@linaro.org,
dianders@chromium.org, robh@kernel.org, krzk+dt@kernel.org,
jikos@kernel.org, bentiss@kernel.org, hbarnor@chromium.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: input: Goodix SPI HID Touchscreen
Date: Fri, 14 Jun 2024 16:27:52 +0100 [thread overview]
Message-ID: <20240614-blah-sworn-1e13ec9c0e94@spud> (raw)
In-Reply-To: <20240614121538.236727-3-charles.goodix@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
On Fri, Jun 14, 2024 at 08:15:38PM +0800, Charles Wang wrote:
> The Goodix GT7986U touch controller report touch data according to the
> HID protocol through the SPI bus. However, it is incompatible with
> Microsoft's HID-over-SPI protocol.
> +properties:
> + compatible:
> + enum:
> + - goodix,gt7986u
> + goodix,hid-report-addr:
> + description: the register address for retrieving HID report data.
> + $ref: /schemas/types.yaml#/definitions/uint32
You're also missing an explanation anywhere in the patch for why this
address varies between gt7986u devices.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-06-14 15:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 12:15 [PATCH v4 0/2] HID: add initial support for Goodix HID-over-SPI touchscreen Charles Wang
2024-06-14 12:15 ` [PATCH v4 1/2] HID: hid-goodix: Add Goodix HID-over-SPI driver Charles Wang
2024-06-15 11:57 ` kernel test robot
2024-06-15 18:03 ` kernel test robot
2024-06-16 23:10 ` kernel test robot
2024-06-14 12:15 ` [PATCH v4 2/2] dt-bindings: input: Goodix SPI HID Touchscreen Charles Wang
2024-06-14 13:13 ` Rob Herring (Arm)
2024-06-14 15:26 ` Conor Dooley
2024-06-18 7:15 ` Charles Wang
2024-06-14 15:27 ` Conor Dooley [this message]
2024-06-18 7:27 ` Charles Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614-blah-sworn-1e13ec9c0e94@spud \
--to=conor@kernel.org \
--cc=bentiss@kernel.org \
--cc=charles.goodix@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hbarnor@chromium.org \
--cc=jikos@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).