From: Conor Dooley <conor@kernel.org>
To: Charles Wang <charles.goodix@gmail.com>
Cc: dmitry.torokhov@gmail.com, dan.carpenter@linaro.org,
robh@kernel.org, dianders@chromium.org, krzk+dt@kernel.org,
jikos@kernel.org, bentiss@kernel.org, hbarnor@chromium.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] dt-bindings: input: Goodix SPI HID Touchscreen
Date: Wed, 19 Jun 2024 19:09:05 +0100 [thread overview]
Message-ID: <20240619-browsing-discount-cee3b686f505@spud> (raw)
In-Reply-To: <ZnI_kt3APuF6NWvR@ux-UP-WHL01>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On Wed, Jun 19, 2024 at 10:16:50AM +0800, Charles Wang wrote:
> Hi Conor,
>
> On Tue, Jun 18, 2024 at 06:43:18PM +0100, Conor Dooley wrote:
> > On Tue, Jun 18, 2024 at 04:44:54PM +0800, Charles Wang wrote:
> > > + reset-gpios:
> > > + maxItems: 1
> > > + description: reset gpio the chip is connected to.
> >
> > The description here isn't needed, it's obvious :)
> >
>
> Ack.
>
> > > + goodix,hid-report-addr:
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > + description: |
> >
> > This | is not needed, there's no formatting to preserve.
> >
> > Those are nits:
> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> >
>
> Thank you. If there is a next version, I will fix these.
Sounds good, thank you!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-06-19 18:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 8:44 [PATCH v5 0/2] HID: add initial support for Goodix HID-over-SPI touchscreen Charles Wang
2024-06-18 8:44 ` [PATCH v5 1/2] HID: hid-goodix: Add Goodix HID-over-SPI driver Charles Wang
2024-07-03 20:47 ` Dmitry Torokhov
2024-08-13 12:58 ` Charles Wang
2024-06-18 8:44 ` [PATCH v5 2/2] dt-bindings: input: Goodix SPI HID Touchscreen Charles Wang
2024-06-18 17:43 ` Conor Dooley
2024-06-19 2:16 ` Charles Wang
2024-06-19 18:09 ` Conor Dooley [this message]
2024-06-24 10:10 ` [PATCH v5 0/2] HID: add initial support for Goodix HID-over-SPI touchscreen Charles Wang
2024-08-08 17:19 ` Doug Anderson
2024-08-13 13:09 ` Charles Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619-browsing-discount-cee3b686f505@spud \
--to=conor@kernel.org \
--cc=bentiss@kernel.org \
--cc=charles.goodix@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hbarnor@chromium.org \
--cc=jikos@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).