From: Rob Herring <robh@kernel.org>
To: Caleb Connolly <caleb@postmarketos.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Henrik Rydberg <rydberg@bitmath.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 3/7] dt-bindings: arm: qcom: add OnePlus 8 series
Date: Mon, 24 Jun 2024 14:40:41 -0600 [thread overview]
Message-ID: <20240624204041.GA375582-robh@kernel.org> (raw)
In-Reply-To: <20240624-oneplus8-v1-3-388eecf2dff7@postmarketos.org>
On Mon, Jun 24, 2024 at 03:30:27AM +0200, Caleb Connolly wrote:
> Add bindings for the OnePlus 8, 8 Pro, and 8T devices.
>
> Signed-off-by: Caleb Connolly <caleb@postmarketos.org>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index d839691a900c..a41eeb8c3fc5 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -986,8 +986,11 @@ properties:
> - enum:
> - qcom,qrb5165-rb5
> - qcom,sm8250-hdk
> - qcom,sm8250-mtp
> + - oneplus,kebab
> + - oneplus,instantnoodle
> + - oneplus,instantnoodlep
Which one is which device in the commit msg? I can only guess that 'p'
here corresponds to Pro. A comment after the compatibles would help.
> - sony,pdx203-generic
> - sony,pdx206-generic
> - xiaomi,elish
> - xiaomi,pipa
>
> --
> 2.45.0
>
next prev parent reply other threads:[~2024-06-24 20:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 1:30 [PATCH 0/7] qcom: initial support for the OnePlus 8T Caleb Connolly
2024-06-24 1:30 ` [PATCH 1/7] dt-bindings: panel: document Samsung AMB655X Caleb Connolly
2024-06-24 1:33 ` Caleb Connolly
2024-06-27 22:12 ` Rob Herring
2024-06-27 23:24 ` Caleb Connolly
2024-06-24 1:30 ` [PATCH 2/7] dt-bindings: input: touchscreen: document synaptics TCM oncell Caleb Connolly
2024-06-24 2:42 ` Rob Herring (Arm)
2024-06-24 7:25 ` Dmitry Torokhov
2024-06-24 1:30 ` [PATCH 3/7] dt-bindings: arm: qcom: add OnePlus 8 series Caleb Connolly
2024-06-24 4:52 ` Krzysztof Kozlowski
2024-06-24 20:40 ` Rob Herring [this message]
2024-06-24 1:30 ` [PATCH 4/7] drm: mipi: add mipi_dsi_generic_write_multi_type() Caleb Connolly
2024-06-24 5:21 ` Dmitry Baryshkov
2024-06-24 1:30 ` [PATCH 5/7] drm/panel: add driver for samsung amb655x Caleb Connolly
2024-06-24 5:31 ` Dmitry Baryshkov
2024-06-24 1:30 ` [PATCH 6/7] Input: touchscreen: add Synaptics TCM oncell S3908 Caleb Connolly
2024-06-24 7:42 ` Dmitry Torokhov
2024-06-27 23:35 ` Caleb Connolly
2024-06-24 1:30 ` [PATCH 7/7] arm64: dts: qcom: add OnePlus 8T (kebab) Caleb Connolly
2024-06-26 4:16 ` Bjorn Andersson
2024-06-27 23:40 ` Caleb Connolly
2024-06-26 9:43 ` Konrad Dybcio
2024-06-24 5:18 ` [PATCH 0/7] qcom: initial support for the OnePlus 8T Dmitry Baryshkov
2024-06-24 11:32 ` Caleb Connolly
2024-06-24 11:33 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240624204041.GA375582-robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=caleb@postmarketos.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=rydberg@bitmath.org \
--cc=tzimmermann@suse.de \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).