Re: [PATCH] Input: qt1050 - handle CHIP_ID reading error

Re: [PATCH] Input: qt1050 - handle CHIP_ID reading error

[Andrei Lalaev]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=us-ascii, Size: 319 bytes --]

> But how did we get into the situation with the chip being missing?

In my case, this chip is a part of an external board.
So, for example, I see this message in the case of a bad cable connection.

Also, I prefer to see messages with error codes instead of random values from a stack :)

Best regards,
Andrei Lalaev

[PATCH] Input: qt1050 - handle CHIP_ID reading error

[Andrei Lalaev]

From: Andrei Lalaev <andrei.lalaev@anton-paar.com>

If the device is missing, we get the following error:

  qt1050 3-0041: ID -1340767592 not supported

Let's handle this situation and print more informative error
when reading of CHIP_ID fails:

  qt1050 3-0041: Failed to read chip ID: -6

Fixes: cbebf5addec1 ("Input: qt1050 - add Microchip AT42QT1050 support")
Signed-off-by: Andrei Lalaev <andrei.lalaev@anton-paar.com>
---
 drivers/input/keyboard/qt1050.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/qt1050.c b/drivers/input/keyboard/qt1050.c
index b51dfcd76038..056e9bc26026 100644
--- a/drivers/input/keyboard/qt1050.c
+++ b/drivers/input/keyboard/qt1050.c
@@ -226,7 +226,12 @@ static bool qt1050_identify(struct qt1050_priv *ts)
 	int err;
 
 	/* Read Chip ID */
-	regmap_read(ts->regmap, QT1050_CHIP_ID, &val);
+	err = regmap_read(ts->regmap, QT1050_CHIP_ID, &val);
+	if (err) {
+		dev_err(&ts->client->dev, "Failed to read chip ID: %d\n", err);
+		return false;
+	}
+
 	if (val != QT1050_CHIP_ID_VER) {
 		dev_err(&ts->client->dev, "ID %d not supported\n", val);
 		return false;
-- 
2.35.2

Re: [PATCH] Input: qt1050 - handle CHIP_ID reading error

[Marco Felsch]

On 24-06-17, Andrei Lalaev wrote:
> From: Andrei Lalaev <andrei.lalaev@anton-paar.com>
> 
> If the device is missing, we get the following error:
> 
>   qt1050 3-0041: ID -1340767592 not supported
> 
> Let's handle this situation and print more informative error
> when reading of CHIP_ID fails:
> 
>   qt1050 3-0041: Failed to read chip ID: -6
> 
> Fixes: cbebf5addec1 ("Input: qt1050 - add Microchip AT42QT1050 support")
> Signed-off-by: Andrei Lalaev <andrei.lalaev@anton-paar.com>

Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

Re: [PATCH] Input: qt1050 - handle CHIP_ID reading error

[Dmitry Torokhov]

On Mon, Jun 17, 2024 at 08:30:18PM +0200, Andrei Lalaev wrote:
> From: Andrei Lalaev <andrei.lalaev@anton-paar.com>
> 
> If the device is missing, we get the following error:
> 
>   qt1050 3-0041: ID -1340767592 not supported
> 
> Let's handle this situation and print more informative error
> when reading of CHIP_ID fails:
> 
>   qt1050 3-0041: Failed to read chip ID: -6
> 
> Fixes: cbebf5addec1 ("Input: qt1050 - add Microchip AT42QT1050 support")
> Signed-off-by: Andrei Lalaev <andrei.lalaev@anton-paar.com>

Applied, thank you.

But how did we get into the situation with the chip being missing?
Incorrect DTB for the board?

Thanks.

-- 
Dmitry

Re: [PATCH] Input: qt1050 - handle CHIP_ID reading error

[Andrei Lalaev]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=us-ascii, Size: 393 bytes --]

> But how did we get into the situation with the chip being missing?

In my case, this chip is a part of an external board.
So, for example, I see this message in the case of a bad cable connection.

Also, I prefer to see messages with error codes instead of random values from a stack :)

P.S. sorry for the previous email, I made a typo in git-send-email args.

Best regards,
Andrei Lalaev