From: Lee Jones <lee@kernel.org>
To: James Ogletree <James.Ogletree@cirrus.com>
Cc: James Ogletree <jogletre@opensource.cirrus.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Mark Brown <broonie@kernel.org>, Jeff LaBundy <jeff@labundy.com>,
"patches@opensource.cirrus.com" <patches@opensource.cirrus.com>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH RESEND v11 0/5] Add support for CS40L50
Date: Thu, 27 Jun 2024 08:12:58 +0100 [thread overview]
Message-ID: <20240627071258.GE2532839@google.com> (raw)
In-Reply-To: <21975F67-D71D-4D5D-8042-8EE64E8864CA@cirrus.com>
On Wed, 26 Jun 2024, James Ogletree wrote:
>
> > On Jun 20, 2024, at 11:59 AM, Lee Jones <lee@kernel.org> wrote:
> >
> > On Thu, 20 Jun 2024, James Ogletree wrote:
> >
> >> Changes in v11:
> >> - Constified function parameters in ASOC driver
> >> - Removed an unneeded #include
> >> - Changed number of max FF effects = 1
> >> - Minor refactoring in Input driver
> >> - Reworded comment in MFD driver
> >>
> >> Changes in v10:
> >> - Minor refactoring and logical improvements all around
> >> - Renamed and added supplies
> >>
> >> Changes in v9:
> >> - Fixed empty struct by utilizing cs_dsp's post_run callback
> >> - Style fixes in MFD driver
> >>
> >> Changes in v8:
> >> - set_sysclk() -> set_bclk_ratio()
> >> - Added ID table to codec driver
> >> - Style improvements
> >> - Fixed ordering of new write sequence operations
> >>
> >> Changes in v7:
> >> - Fixed sparse warning
> >> - Moved write sequences to private data structure
> >> - Logical and style improvements in write sequence interface
> >>
> >> Changes in v6:
> >> - Updated write sequencer interface to be control-name based
> >> - Fixed a race condition and non-handling of repeats in playback callback
> >> - Stylistic and logical improvements all around
> >>
> >> Changes in v5:
> >> - Added a codec sub-device to support I2S streaming
> >> - Moved write sequencer code from cirrus_haptics to cs_dsp
> >> - Reverted cirrus_haptics library; future Cirrus input
> >> drivers will export and utilize cs40l50_vibra functions
> >> - Added more comments
> >> - Many small stylistic and logical improvements
> >>
> >> Changes in v4:
> >> - Moved from Input to MFD
> >> - Moved common Cirrus haptic functions to a library
> >> - Incorporated runtime PM framework
> >> - Many style improvements
> >>
> >> Changes in v3:
> >> - YAML formatting corrections
> >> - Fixed typo in MAINTAINERS
> >> - Used generic node name "haptic-driver"
> >> - Fixed probe error code paths
> >> - Switched to "sizeof(*)"
> >> - Removed tree reference in MAINTAINERS
> >>
> >> Changes in v2:
> >> - Fixed checkpatch warnings
> >>
> >> James Ogletree (5):
> >> firmware: cs_dsp: Add write sequence interface
> >> dt-bindings: input: cirrus,cs40l50: Add initial DT binding
> >> mfd: cs40l50: Add support for CS40L50 core driver
> >> Input: cs40l50 - Add support for the CS40L50 haptic driver
> >> ASoC: cs40l50: Support I2S streaming to CS40L50
> >>
> >> .../bindings/input/cirrus,cs40l50.yaml | 68 +++
> >> MAINTAINERS | 12 +
> >> drivers/firmware/cirrus/cs_dsp.c | 278 +++++++++
> >> drivers/input/misc/Kconfig | 10 +
> >> drivers/input/misc/Makefile | 1 +
> >> drivers/input/misc/cs40l50-vibra.c | 555 +++++++++++++++++
> >> drivers/mfd/Kconfig | 30 +
> >> drivers/mfd/Makefile | 4 +
> >> drivers/mfd/cs40l50-core.c | 570 ++++++++++++++++++
> >> drivers/mfd/cs40l50-i2c.c | 68 +++
> >> drivers/mfd/cs40l50-spi.c | 68 +++
> >> include/linux/firmware/cirrus/cs_dsp.h | 27 +
> >> include/linux/mfd/cs40l50.h | 137 +++++
> >> sound/soc/codecs/Kconfig | 11 +
> >> sound/soc/codecs/Makefile | 2 +
> >> sound/soc/codecs/cs40l50-codec.c | 307 ++++++++++
> >> 16 files changed, 2148 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
> >> create mode 100644 drivers/input/misc/cs40l50-vibra.c
> >> create mode 100644 drivers/mfd/cs40l50-core.c
> >> create mode 100644 drivers/mfd/cs40l50-i2c.c
> >> create mode 100644 drivers/mfd/cs40l50-spi.c
> >> create mode 100644 include/linux/mfd/cs40l50.h
> >> create mode 100644 sound/soc/codecs/cs40l50-codec.c
> >
> > Still needs Acks - ping me when you have them.
> >
> > --
> > Lee Jones [李琼斯]
>
> Hi Lee,
>
> You can take this series now.
sound/soc?
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-06-27 7:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 16:17 [PATCH RESEND v11 0/5] Add support for CS40L50 James Ogletree
2024-06-20 16:17 ` [PATCH RESEND v11 1/5] firmware: cs_dsp: Add write sequence interface James Ogletree
2024-06-23 0:19 ` Jeff LaBundy
2024-06-20 16:17 ` [PATCH RESEND v11 2/5] dt-bindings: input: cirrus,cs40l50: Add initial DT binding James Ogletree
2024-06-23 0:20 ` Jeff LaBundy
2024-06-20 16:17 ` [PATCH RESEND v11 3/5] mfd: cs40l50: Add support for CS40L50 core driver James Ogletree
2024-06-23 0:21 ` Jeff LaBundy
2024-06-20 16:17 ` [PATCH RESEND v11 4/5] Input: cs40l50 - Add support for the CS40L50 haptic driver James Ogletree
2024-06-23 0:22 ` Jeff LaBundy
2024-06-23 8:02 ` Dmitry Torokhov
2024-06-23 19:04 ` James Ogletree
2024-06-20 16:17 ` [PATCH RESEND v11 5/5] ASoC: cs40l50: Support I2S streaming to CS40L50 James Ogletree
2024-06-23 0:23 ` Jeff LaBundy
2024-06-26 16:55 ` Rivera-Matos, Ricardo
2024-06-20 16:59 ` [PATCH RESEND v11 0/5] Add support for CS40L50 Lee Jones
2024-06-26 20:35 ` James Ogletree
2024-06-27 7:12 ` Lee Jones [this message]
2024-06-27 12:07 ` James Ogletree
2024-06-28 8:06 ` Lee Jones
2024-06-28 11:18 ` James Ogletree
2024-06-28 14:23 ` Lee Jones
2024-06-28 14:36 ` Lee Jones
2024-06-28 14:38 ` Lee Jones
2024-06-28 14:38 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627071258.GE2532839@google.com \
--to=lee@kernel.org \
--cc=James.Ogletree@cirrus.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jeff@labundy.com \
--cc=jogletre@opensource.cirrus.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).