From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C67C94436A; Fri, 28 Jun 2024 08:06:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719562018; cv=none; b=CyNqn1GD8jr+lc5pG29RtM98Ewae+e6njuS1AhOjmAzSTgJOSmn5xbDb8FSlXTj9BI4E2n7nBRVKrr75opZnyIVL/pxcC33ESchzx9etrDEmJRWF5z+cP/o4OI5QMUhFxmZCvNuyfAMpN3AGc02GdTYnYwk6kKoytAz6UlMBFh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719562018; c=relaxed/simple; bh=Iy8/UxZRhExwvU1/4dAFYZkxite/l0ek3Z7R2WkUJCA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Fpxudu7N7JDANKtqy8pyc46dSGDMMLPK1k9Twv5Gi7iDFYxXsX2SullfBF3e+pGkMjcz0fVn6FAWS9T12DUKLSfTZxT5Y9xwZUFphR8xtW696P6uVJ2ZxkNpymFuWfb6Uw/3suCWOS2TiHDZY641DBFtE9VKRpuJ/HBNGjEfrzM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ddWAcFDj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ddWAcFDj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CAF9C32781; Fri, 28 Jun 2024 08:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719562018; bh=Iy8/UxZRhExwvU1/4dAFYZkxite/l0ek3Z7R2WkUJCA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ddWAcFDjX0QfautySQE9b+e04FLKN6UtAFVjcXXUG+KFdZ7cu2KxlcYX7JZ9j+SBI /l3QHtcjZAm0H+pqMjqa7UNXNqi3KLUVLNfQs2t96afCUgs5VRRZdiflY+UwVzNGQy 6chnlUZw5ixIa77vbxSSN/M1LOqVrFsB3A/JVtxPoo0MqpwZ21Yy4tdyLHbtBNxzcG 5GYkHugbz5ll775Y3nQQY/P5vBGUP2TVh9XYkRliuyYCcG0Qm6E8oPCg3fkBA2mu2T DqsizVQ1ZYc9yknrnBZ8VxjX1jI+o0iKUZIp/Kzz241EPN1vp54yDt+cQ2MKkbfIyj Ts4Vy/xh+w8/Q== Date: Fri, 28 Jun 2024 09:06:53 +0100 From: Lee Jones To: James Ogletree Cc: James Ogletree , Dmitry Torokhov , "robh+dt@kernel.org" , Krzysztof Kozlowski , Conor Dooley , Mark Brown , Jeff LaBundy , "patches@opensource.cirrus.com" , "linux-sound@vger.kernel.org" , "linux-input@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH RESEND v11 0/5] Add support for CS40L50 Message-ID: <20240628080653.GJ2532839@google.com> References: <20240620161745.2312359-1-jogletre@opensource.cirrus.com> <20240620165935.GT3029315@google.com> <21975F67-D71D-4D5D-8042-8EE64E8864CA@cirrus.com> <20240627071258.GE2532839@google.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, 27 Jun 2024, James Ogletree wrote: > > > On Jun 27, 2024, at 2:12 AM, Lee Jones wrote: > > > > On Wed, 26 Jun 2024, James Ogletree wrote: > > > >> > >>> On Jun 20, 2024, at 11:59 AM, Lee Jones wrote: > >>> > >>> On Thu, 20 Jun 2024, James Ogletree wrote: > >>> > >>>> Changes in v11: > >>>> - Constified function parameters in ASOC driver > >>>> - Removed an unneeded #include > >>>> - Changed number of max FF effects = 1 > >>>> - Minor refactoring in Input driver > >>>> - Reworded comment in MFD driver > >>>> > >>>> Changes in v10: > >>>> - Minor refactoring and logical improvements all around > >>>> - Renamed and added supplies > >>>> > >>>> Changes in v9: > >>>> - Fixed empty struct by utilizing cs_dsp's post_run callback > >>>> - Style fixes in MFD driver > >>>> > >>>> Changes in v8: > >>>> - set_sysclk() -> set_bclk_ratio() > >>>> - Added ID table to codec driver > >>>> - Style improvements > >>>> - Fixed ordering of new write sequence operations > >>>> > >>>> Changes in v7: > >>>> - Fixed sparse warning > >>>> - Moved write sequences to private data structure > >>>> - Logical and style improvements in write sequence interface > >>>> > >>>> Changes in v6: > >>>> - Updated write sequencer interface to be control-name based > >>>> - Fixed a race condition and non-handling of repeats in playback callback > >>>> - Stylistic and logical improvements all around > >>>> > >>>> Changes in v5: > >>>> - Added a codec sub-device to support I2S streaming > >>>> - Moved write sequencer code from cirrus_haptics to cs_dsp > >>>> - Reverted cirrus_haptics library; future Cirrus input > >>>> drivers will export and utilize cs40l50_vibra functions > >>>> - Added more comments > >>>> - Many small stylistic and logical improvements > >>>> > >>>> Changes in v4: > >>>> - Moved from Input to MFD > >>>> - Moved common Cirrus haptic functions to a library > >>>> - Incorporated runtime PM framework > >>>> - Many style improvements > >>>> > >>>> Changes in v3: > >>>> - YAML formatting corrections > >>>> - Fixed typo in MAINTAINERS > >>>> - Used generic node name "haptic-driver" > >>>> - Fixed probe error code paths > >>>> - Switched to "sizeof(*)" > >>>> - Removed tree reference in MAINTAINERS > >>>> > >>>> Changes in v2: > >>>> - Fixed checkpatch warnings > >>>> > >>>> James Ogletree (5): > >>>> firmware: cs_dsp: Add write sequence interface > >>>> dt-bindings: input: cirrus,cs40l50: Add initial DT binding > >>>> mfd: cs40l50: Add support for CS40L50 core driver > >>>> Input: cs40l50 - Add support for the CS40L50 haptic driver > >>>> ASoC: cs40l50: Support I2S streaming to CS40L50 > >>>> > >>>> .../bindings/input/cirrus,cs40l50.yaml | 68 +++ > >>>> MAINTAINERS | 12 + > >>>> drivers/firmware/cirrus/cs_dsp.c | 278 +++++++++ > >>>> drivers/input/misc/Kconfig | 10 + > >>>> drivers/input/misc/Makefile | 1 + > >>>> drivers/input/misc/cs40l50-vibra.c | 555 +++++++++++++++++ > >>>> drivers/mfd/Kconfig | 30 + > >>>> drivers/mfd/Makefile | 4 + > >>>> drivers/mfd/cs40l50-core.c | 570 ++++++++++++++++++ > >>>> drivers/mfd/cs40l50-i2c.c | 68 +++ > >>>> drivers/mfd/cs40l50-spi.c | 68 +++ > >>>> include/linux/firmware/cirrus/cs_dsp.h | 27 + > >>>> include/linux/mfd/cs40l50.h | 137 +++++ > >>>> sound/soc/codecs/Kconfig | 11 + > >>>> sound/soc/codecs/Makefile | 2 + > >>>> sound/soc/codecs/cs40l50-codec.c | 307 ++++++++++ > >>>> 16 files changed, 2148 insertions(+) > >>>> create mode 100644 Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml > >>>> create mode 100644 drivers/input/misc/cs40l50-vibra.c > >>>> create mode 100644 drivers/mfd/cs40l50-core.c > >>>> create mode 100644 drivers/mfd/cs40l50-i2c.c > >>>> create mode 100644 drivers/mfd/cs40l50-spi.c > >>>> create mode 100644 include/linux/mfd/cs40l50.h > >>>> create mode 100644 sound/soc/codecs/cs40l50-codec.c > >>> > >>> Still needs Acks - ping me when you have them. > >>> > >>> -- > >>> Lee Jones [李琼斯] > >> > >> Hi Lee, > >> > >> You can take this series now. > > > > sound/soc? > > > > -- > > Lee Jones [李琼斯] > > Mark has Acked the original v11 series here: > https://lore.kernel.org/all/a85e09d6-d8eb-4c60-ae83-b4dbf875a926@sirena.org.uk/ Ah, you just forgot to add it to the RESEND? Okay, leave it with me then. -- Lee Jones [李琼斯]