From: "Tomasz Pakuła" <tomasz.pakula.oficjalny@gmail.com>
To: dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org
Subject: [PATCH] Input: increase max button number to 0x3ff
Date: Tue, 2 Jul 2024 13:41:47 +0200 [thread overview]
Message-ID: <20240702114530.11800-1-tomasz.pakula.oficjalny@gmail.com> (raw)
Maximum number of buttons is limited to 0x2ff. This makes it so game
controllers like joysticks, racing wheelbases etc. are limited to 80
buttons.
A lot of input devices for flight simulators and racing simulators take
full advantage of Windows' input API limitation of 128 buttons and,
in turn, some of their buttons simply don't show up under linux. While
normally I'd say doing something just becuase other OS does, doesn't
seem like enough of a reason, Linux became quite a viable gaming
platform in the recent years so this makes it so it supports all the HID
peripherals without fuss and confusion (there aren't any dmesg errors if
HID device exceeds the 0x2ff button id).
I'm a part of linux simracing community and we encoutered this issue
with Moza Racing wheelbases, as they use top of the range for things
like h-pattern shifters, sequential shifters. These accessories simply
don't work, be it connected through the wheelbase or directly with USB.
Upcoming Moza Flight Sim devices will face the same issue, and there were
Saitek/Logitech/Honeycomb and custom-made products that also have more
then 80 buttons.
0x2ff was already sort of an arbitrary number, so I'm increasing it to
0x3ff to keep the value straight-forward.
Change has been verified on my Moza Racing R9 wheelbase + Moza racing
sequential shifter (it uses buttons 112-117).
Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny@gmail.com>
---
include/linux/mod_devicetable.h | 2 +-
include/uapi/linux/input-event-codes.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
index 4338b1b4ac44..c2cb3a2d0dc7 100644
--- a/include/linux/mod_devicetable.h
+++ b/include/linux/mod_devicetable.h
@@ -333,7 +333,7 @@ struct pcmcia_device_id {
/* Input */
#define INPUT_DEVICE_ID_EV_MAX 0x1f
#define INPUT_DEVICE_ID_KEY_MIN_INTERESTING 0x71
-#define INPUT_DEVICE_ID_KEY_MAX 0x2ff
+#define INPUT_DEVICE_ID_KEY_MAX 0x3ff
#define INPUT_DEVICE_ID_REL_MAX 0x0f
#define INPUT_DEVICE_ID_ABS_MAX 0x3f
#define INPUT_DEVICE_ID_MSC_MAX 0x07
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index a4206723f503..a8eace215b54 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -808,7 +808,7 @@
/* We avoid low common keys in module aliases so they don't get huge. */
#define KEY_MIN_INTERESTING KEY_MUTE
-#define KEY_MAX 0x2ff
+#define KEY_MAX 0x3ff
#define KEY_CNT (KEY_MAX+1)
/*
--
2.45.2
next reply other threads:[~2024-07-02 11:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 11:41 Tomasz Pakuła [this message]
2024-07-05 14:04 ` [PATCH] Input: increase max button number to 0x3ff Michał Kopeć
2024-07-05 15:01 ` Benjamin Tissoires
2024-07-08 10:30 ` Tomasz Pakuła
2024-07-08 10:32 ` Tomasz Pakuła
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702114530.11800-1-tomasz.pakula.oficjalny@gmail.com \
--to=tomasz.pakula.oficjalny@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).