From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71C8D1AA358; Tue, 9 Jul 2024 16:26:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720542416; cv=none; b=gSXUgQMP1bdMaPpJCOpoTmrQdNp1m086YWSDN4g7eXplZnvCTnL0oAPwf1AF1husoxvJo4QXXiX4rqeKwybaVUxJMTSiMpk1KeyDLAon5Z7s2Jz2gsAWkdoolgZxVB2EntxVe+78uGTRQFuGwpvRgRzJE8ZERwO93onbvL1TWGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720542416; c=relaxed/simple; bh=gOcCp+LQ0kE3urmjpfxXHzJf4UqCQl6qhAqq2kc3Qts=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=V+lWAPDVbCQyNuA/Tn3/Ww7uW+wVyAfVQ6yRUo98NavkDf2xhpB3CUSZ3sHk5KwukqQMbqDlzHfVhAcMJLgwvyZDxVnwZLpsQsTalBnFDA/BKAJirWZgDzGrW9V6Kv8pwybOvXI6N/AyH5xBzBDcfyCHengdqomGmreZpLVyIvI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kWhP8UhB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kWhP8UhB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81CABC3277B; Tue, 9 Jul 2024 16:26:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720542416; bh=gOcCp+LQ0kE3urmjpfxXHzJf4UqCQl6qhAqq2kc3Qts=; h=From:To:Cc:Subject:Date:From; b=kWhP8UhBOkvzfWjkQj0b24j9uKOlWnVZgzsANGtpURQ+5CfF6jnAl6cFTYfMkFvcn vaHZKjSVyhwY9sE70lqxIGTQRtDGu0ZGSAFKOviG4hwfPElyrhCVO7JiGX28jEfiqk CFz1T2NkIGhwmoZdQn84aueABHArmFkqp5NWYlzvLrizG/ssZPuZ1G7Qa/snfEXYRb CJU+jby+9YRuxzCNmhCnoo5vQvL144k4UdgByUZjqI+1xDCyDbxTehqr6bb1kxeHYA 7ng4Zi08keZdSHFJdMxGhx0PFuxODmeh4NDWC+2Y/6LveHyz77bIabpju99bu13VXZ XoFmZ83B3C8rQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jonathan Denose , Dmitry Torokhov , Sasha Levin , jefferymiller@google.com, linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 01/11] Input: elantech - fix touchpad state on resume for Lenovo N24 Date: Tue, 9 Jul 2024 12:26:34 -0400 Message-ID: <20240709162654.33343-1-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.279 Content-Transfer-Encoding: 8bit From: Jonathan Denose [ Upstream commit a69ce592cbe0417664bc5a075205aa75c2ec1273 ] The Lenovo N24 on resume becomes stuck in a state where it sends incorrect packets, causing elantech_packet_check_v4 to fail. The only way for the device to resume sending the correct packets is for it to be disabled and then re-enabled. This change adds a dmi check to trigger this behavior on resume. Signed-off-by: Jonathan Denose Link: https://lore.kernel.org/r/20240503155020.v2.1.Ifa0e25ebf968d8f307f58d678036944141ab17e6@changeid Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/mouse/elantech.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index 9ff89bfda7a24..8e286e023916f 100644 --- a/drivers/input/mouse/elantech.c +++ b/drivers/input/mouse/elantech.c @@ -1476,16 +1476,47 @@ static void elantech_disconnect(struct psmouse *psmouse) psmouse->private = NULL; } +/* + * Some hw_version 4 models fail to properly activate absolute mode on + * resume without going through disable/enable cycle. + */ +static const struct dmi_system_id elantech_needs_reenable[] = { +#if defined(CONFIG_DMI) && defined(CONFIG_X86) + { + /* Lenovo N24 */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "81AF"), + }, + }, +#endif + { } +}; + /* * Put the touchpad back into absolute mode when reconnecting */ static int elantech_reconnect(struct psmouse *psmouse) { + int err; + psmouse_reset(psmouse); if (elantech_detect(psmouse, 0)) return -1; + if (dmi_check_system(elantech_needs_reenable)) { + err = ps2_command(&psmouse->ps2dev, NULL, PSMOUSE_CMD_DISABLE); + if (err) + psmouse_warn(psmouse, "failed to deactivate mouse on %s: %d\n", + psmouse->ps2dev.serio->phys, err); + + err = ps2_command(&psmouse->ps2dev, NULL, PSMOUSE_CMD_ENABLE); + if (err) + psmouse_warn(psmouse, "failed to reactivate mouse on %s: %d\n", + psmouse->ps2dev.serio->phys, err); + } + if (elantech_set_absolute_mode(psmouse)) { psmouse_err(psmouse, "failed to put touchpad back into absolute mode.\n"); -- 2.43.0