* [PATCH] Adding Support for Thinkpad X12 Gen 2 Kbd Portfolio with 0x61AE as PID
@ 2024-08-18 7:27 Vishnu Sankar
2024-09-10 15:03 ` Vishnu Sankar
[not found] ` <CABxCQKtfFttYVpfZE0jsjt=xgO4EJ0vNeb4Wf-==xOr3XnKnxQ@mail.gmail.com>
0 siblings, 2 replies; 4+ messages in thread
From: Vishnu Sankar @ 2024-08-18 7:27 UTC (permalink / raw)
To: jikos, bentiss, linux-input, linux-kernel
Cc: mpearson-lenovo, vsankar, Vishnu Sankar
This applies similar quirks used by previous generation device, so that
Trackpoint and buttons on the touchpad works.
New USB KBD PID 0x61AE for Thinkpad X12 Tab is added.
Signed-off-by: Vishnu Sankar <vishnuocv@gmail.com>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
---
drivers/hid/hid-ids.h | 1 +
drivers/hid/hid-multitouch.c | 6 ++++++
2 files changed, 7 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 72d56ee7c..981813f50 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -807,6 +807,7 @@
#define USB_DEVICE_ID_LENOVO_X1_TAB 0x60a3
#define USB_DEVICE_ID_LENOVO_X1_TAB3 0x60b5
#define USB_DEVICE_ID_LENOVO_X12_TAB 0x60fe
+#define USB_DEVICE_ID_LENOVO_X12_TAB2 0x61ae
#define USB_DEVICE_ID_LENOVO_OPTICAL_USB_MOUSE_600E 0x600e
#define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_608D 0x608d
#define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_6019 0x6019
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 56fc78841..1b0844ffa 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -2081,6 +2081,12 @@ static const struct hid_device_id mt_devices[] = {
USB_VENDOR_ID_LENOVO,
USB_DEVICE_ID_LENOVO_X12_TAB) },
+ /* Lenovo X12 TAB Gen 2 */
+ { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU,
+ HID_DEVICE(BUS_USB, HID_GROUP_MULTITOUCH_WIN_8,
+ USB_VENDOR_ID_LENOVO,
+ USB_DEVICE_ID_LENOVO_X12_TAB2) },
+
/* Logitech devices */
{ .driver_data = MT_CLS_NSMU,
HID_DEVICE(BUS_BLUETOOTH, HID_GROUP_MULTITOUCH_WIN_8,
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Adding Support for Thinkpad X12 Gen 2 Kbd Portfolio with 0x61AE as PID
2024-08-18 7:27 [PATCH] Adding Support for Thinkpad X12 Gen 2 Kbd Portfolio with 0x61AE as PID Vishnu Sankar
@ 2024-09-10 15:03 ` Vishnu Sankar
[not found] ` <CABxCQKtfFttYVpfZE0jsjt=xgO4EJ0vNeb4Wf-==xOr3XnKnxQ@mail.gmail.com>
1 sibling, 0 replies; 4+ messages in thread
From: Vishnu Sankar @ 2024-09-10 15:03 UTC (permalink / raw)
To: jikos, bentiss, linux-input, linux-kernel; +Cc: mpearson-lenovo, vsankar
All,
Do we have any comments or feedback on this patch?
On Sun, Aug 18, 2024 at 4:28 PM Vishnu Sankar <vishnuocv@gmail.com> wrote:
>
> This applies similar quirks used by previous generation device, so that
> Trackpoint and buttons on the touchpad works.
> New USB KBD PID 0x61AE for Thinkpad X12 Tab is added.
>
> Signed-off-by: Vishnu Sankar <vishnuocv@gmail.com>
> Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> ---
> drivers/hid/hid-ids.h | 1 +
> drivers/hid/hid-multitouch.c | 6 ++++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 72d56ee7c..981813f50 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -807,6 +807,7 @@
> #define USB_DEVICE_ID_LENOVO_X1_TAB 0x60a3
> #define USB_DEVICE_ID_LENOVO_X1_TAB3 0x60b5
> #define USB_DEVICE_ID_LENOVO_X12_TAB 0x60fe
> +#define USB_DEVICE_ID_LENOVO_X12_TAB2 0x61ae
> #define USB_DEVICE_ID_LENOVO_OPTICAL_USB_MOUSE_600E 0x600e
> #define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_608D 0x608d
> #define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_6019 0x6019
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 56fc78841..1b0844ffa 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -2081,6 +2081,12 @@ static const struct hid_device_id mt_devices[] = {
> USB_VENDOR_ID_LENOVO,
> USB_DEVICE_ID_LENOVO_X12_TAB) },
>
> + /* Lenovo X12 TAB Gen 2 */
> + { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU,
> + HID_DEVICE(BUS_USB, HID_GROUP_MULTITOUCH_WIN_8,
> + USB_VENDOR_ID_LENOVO,
> + USB_DEVICE_ID_LENOVO_X12_TAB2) },
> +
> /* Logitech devices */
> { .driver_data = MT_CLS_NSMU,
> HID_DEVICE(BUS_BLUETOOTH, HID_GROUP_MULTITOUCH_WIN_8,
> --
> 2.43.0
>
--
Regards,
Vishnu Sankar
+817015150407 (Japan)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Adding Support for Thinkpad X12 Gen 2 Kbd Portfolio with 0x61AE as PID
[not found] ` <CABxCQKtfFttYVpfZE0jsjt=xgO4EJ0vNeb4Wf-==xOr3XnKnxQ@mail.gmail.com>
@ 2024-09-11 12:18 ` Jiri Kosina
2024-09-12 1:38 ` Vishnu Sankar
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Kosina @ 2024-09-11 12:18 UTC (permalink / raw)
To: Vishnu Sankar
Cc: bentiss, linux-input, linux-kernel, mpearson-lenovo, vsankar
On Tue, 10 Sep 2024, Vishnu Sankar wrote:
> Do we have any feedback or comments about this patch?
Sorry, this slipped in between cracks.
Now applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Adding Support for Thinkpad X12 Gen 2 Kbd Portfolio with 0x61AE as PID
2024-09-11 12:18 ` Jiri Kosina
@ 2024-09-12 1:38 ` Vishnu Sankar
0 siblings, 0 replies; 4+ messages in thread
From: Vishnu Sankar @ 2024-09-12 1:38 UTC (permalink / raw)
To: Jiri Kosina; +Cc: bentiss, linux-input, linux-kernel, mpearson-lenovo, vsankar
Thank you for the acceptance.
On Wed, Sep 11, 2024 at 9:18 PM Jiri Kosina <jikos@kernel.org> wrote:
>
> On Tue, 10 Sep 2024, Vishnu Sankar wrote:
>
> > Do we have any feedback or comments about this patch?
>
> Sorry, this slipped in between cracks.
>
> Now applied, thanks.
>
> --
> Jiri Kosina
> SUSE Labs
>
--
Regards,
Vishnu Sankar
+817015150407 (Japan)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-09-12 1:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-18 7:27 [PATCH] Adding Support for Thinkpad X12 Gen 2 Kbd Portfolio with 0x61AE as PID Vishnu Sankar
2024-09-10 15:03 ` Vishnu Sankar
[not found] ` <CABxCQKtfFttYVpfZE0jsjt=xgO4EJ0vNeb4Wf-==xOr3XnKnxQ@mail.gmail.com>
2024-09-11 12:18 ` Jiri Kosina
2024-09-12 1:38 ` Vishnu Sankar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).