* [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: Use generic node name
@ 2024-08-29 13:44 Fabio Estevam
2024-08-30 16:18 ` Rob Herring (Arm)
2024-09-05 8:46 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2024-08-29 13:44 UTC (permalink / raw)
To: dmitry.torokhov
Cc: robh, krzk+dt, conor+dt, linux-input, devicetree, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
Node names should be generic.
Improve the binding example by using 'touchscreen' as the node name.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
.../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
index 51d48d4130d3..70a922e213f2 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
@@ -126,7 +126,7 @@ examples:
i2c {
#address-cells = <1>;
#size-cells = <0>;
- edt-ft5x06@38 {
+ touchscreen@38 {
compatible = "edt,edt-ft5406";
reg = <0x38>;
interrupt-parent = <&gpio2>;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: Use generic node name
2024-08-29 13:44 [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: Use generic node name Fabio Estevam
@ 2024-08-30 16:18 ` Rob Herring (Arm)
2024-09-05 8:46 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2024-08-30 16:18 UTC (permalink / raw)
To: Fabio Estevam
Cc: krzk+dt, linux-input, dmitry.torokhov, Fabio Estevam, devicetree,
conor+dt
On Thu, 29 Aug 2024 10:44:28 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Node names should be generic.
>
> Improve the binding example by using 'touchscreen' as the node name.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> .../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Could be squashed with the others...
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: Use generic node name
2024-08-29 13:44 [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: Use generic node name Fabio Estevam
2024-08-30 16:18 ` Rob Herring (Arm)
@ 2024-09-05 8:46 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-05 8:46 UTC (permalink / raw)
To: Fabio Estevam, dmitry.torokhov
Cc: robh, krzk+dt, conor+dt, linux-input, devicetree, Fabio Estevam
On 29/08/2024 15:44, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Node names should be generic.
>
> Improve the binding example by using 'touchscreen' as the node name.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
There are other files in touschscreen with the same issue. This is
trivial, non-functional change so do not do it one file per patch. It's
way too much churn. Fix everything or just don't touch.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-05 8:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-29 13:44 [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: Use generic node name Fabio Estevam
2024-08-30 16:18 ` Rob Herring (Arm)
2024-09-05 8:46 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).