From: Rob Herring <robh@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: dmitry.torokhov@gmail.com, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH 2/2] dt-bindings: input: touchscreen: goodix: Use generic node name
Date: Fri, 30 Aug 2024 10:39:27 -0500 [thread overview]
Message-ID: <20240830153927.GA36571-robh@kernel.org> (raw)
In-Reply-To: <20240829183051.3392443-2-festevam@gmail.com>
On Thu, Aug 29, 2024 at 03:30:51PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
Why 2 different subjects for the same change?
Really, both of these go to the same maintainer, so they can be 1 patch.
>
> Node names should be generic.
>
> Improve the binding example by using 'touchscreen' as the node name.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Documentation/devicetree/bindings/input/touchscreen/goodix.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
> index 2a2d86cfd104..eb4992f708b7 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
> @@ -69,7 +69,7 @@ examples:
> i2c {
> #address-cells = <1>;
> #size-cells = <0>;
> - gt928@5d {
> + touchscreen@5d {
> compatible = "goodix,gt928";
> reg = <0x5d>;
> interrupt-parent = <&gpio>;
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-08-30 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 18:30 [PATCH 1/2] dt-bindings: input: touchscreen: iqs7211: Use 'touchscreen' as node name Fabio Estevam
2024-08-29 18:30 ` [PATCH 2/2] dt-bindings: input: touchscreen: goodix: Use generic " Fabio Estevam
2024-08-30 14:19 ` Conor Dooley
2024-08-30 15:39 ` Rob Herring [this message]
2024-08-30 14:18 ` [PATCH 1/2] dt-bindings: input: touchscreen: iqs7211: Use 'touchscreen' as " Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830153927.GA36571-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).