linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: input: touchscreen: iqs7211: Use 'touchscreen' as node name
@ 2024-08-29 18:30 Fabio Estevam
  2024-08-29 18:30 ` [PATCH 2/2] dt-bindings: input: touchscreen: goodix: Use generic " Fabio Estevam
  2024-08-30 14:18 ` [PATCH 1/2] dt-bindings: input: touchscreen: iqs7211: Use 'touchscreen' as " Conor Dooley
  0 siblings, 2 replies; 5+ messages in thread
From: Fabio Estevam @ 2024-08-29 18:30 UTC (permalink / raw)
  To: dmitry.torokhov
  Cc: robh, krzk+dt, conor+dt, linux-input, devicetree, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

'touchscreen' is the recommended node name, not 'touch'.

Fix it accordingly.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 .../devicetree/bindings/input/touchscreen/azoteq,iqs7211.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/azoteq,iqs7211.yaml b/Documentation/devicetree/bindings/input/touchscreen/azoteq,iqs7211.yaml
index 8cf371b99f19..e4dbbafb3779 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/azoteq,iqs7211.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/azoteq,iqs7211.yaml
@@ -666,7 +666,7 @@ examples:
             #address-cells = <1>;
             #size-cells = <0>;
 
-            touch@56 {
+            touchscreen@56 {
                     compatible = "azoteq,iqs7210a";
                     reg = <0x56>;
                     irq-gpios = <&gpio 4 GPIO_ACTIVE_LOW>;
@@ -704,7 +704,7 @@ examples:
             #address-cells = <1>;
             #size-cells = <0>;
 
-            touch@56 {
+            touchscreen@56 {
                     compatible = "azoteq,iqs7211e";
                     reg = <0x56>;
                     irq-gpios = <&gpio 4 (GPIO_ACTIVE_LOW |
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] dt-bindings: input: touchscreen: goodix: Use generic node name
  2024-08-29 18:30 [PATCH 1/2] dt-bindings: input: touchscreen: iqs7211: Use 'touchscreen' as node name Fabio Estevam
@ 2024-08-29 18:30 ` Fabio Estevam
  2024-08-30 14:19   ` Conor Dooley
  2024-08-30 15:39   ` Rob Herring
  2024-08-30 14:18 ` [PATCH 1/2] dt-bindings: input: touchscreen: iqs7211: Use 'touchscreen' as " Conor Dooley
  1 sibling, 2 replies; 5+ messages in thread
From: Fabio Estevam @ 2024-08-29 18:30 UTC (permalink / raw)
  To: dmitry.torokhov
  Cc: robh, krzk+dt, conor+dt, linux-input, devicetree, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Node names should be generic.

Improve the binding example by using 'touchscreen' as the node name.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 Documentation/devicetree/bindings/input/touchscreen/goodix.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
index 2a2d86cfd104..eb4992f708b7 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
@@ -69,7 +69,7 @@ examples:
     i2c {
       #address-cells = <1>;
       #size-cells = <0>;
-      gt928@5d {
+      touchscreen@5d {
         compatible = "goodix,gt928";
         reg = <0x5d>;
         interrupt-parent = <&gpio>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dt-bindings: input: touchscreen: iqs7211: Use 'touchscreen' as node name
  2024-08-29 18:30 [PATCH 1/2] dt-bindings: input: touchscreen: iqs7211: Use 'touchscreen' as node name Fabio Estevam
  2024-08-29 18:30 ` [PATCH 2/2] dt-bindings: input: touchscreen: goodix: Use generic " Fabio Estevam
@ 2024-08-30 14:18 ` Conor Dooley
  1 sibling, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2024-08-30 14:18 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: dmitry.torokhov, robh, krzk+dt, conor+dt, linux-input, devicetree,
	Fabio Estevam

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

On Thu, Aug 29, 2024 at 03:30:50PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> 'touchscreen' is the recommended node name, not 'touch'.
> 
> Fix it accordingly.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Ultimately I feel acking this is pointless given how trivial it is, I
wouldn't want a trivial patch held up by the lack of one.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] dt-bindings: input: touchscreen: goodix: Use generic node name
  2024-08-29 18:30 ` [PATCH 2/2] dt-bindings: input: touchscreen: goodix: Use generic " Fabio Estevam
@ 2024-08-30 14:19   ` Conor Dooley
  2024-08-30 15:39   ` Rob Herring
  1 sibling, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2024-08-30 14:19 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: dmitry.torokhov, robh, krzk+dt, conor+dt, linux-input, devicetree,
	Fabio Estevam

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

On Thu, Aug 29, 2024 at 03:30:51PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Node names should be generic.
> 
> Improve the binding example by using 'touchscreen' as the node name.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] dt-bindings: input: touchscreen: goodix: Use generic node name
  2024-08-29 18:30 ` [PATCH 2/2] dt-bindings: input: touchscreen: goodix: Use generic " Fabio Estevam
  2024-08-30 14:19   ` Conor Dooley
@ 2024-08-30 15:39   ` Rob Herring
  1 sibling, 0 replies; 5+ messages in thread
From: Rob Herring @ 2024-08-30 15:39 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: dmitry.torokhov, krzk+dt, conor+dt, linux-input, devicetree,
	Fabio Estevam

On Thu, Aug 29, 2024 at 03:30:51PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>

Why 2 different subjects for the same change?

Really, both of these go to the same maintainer, so they can be 1 patch.

> 
> Node names should be generic.
> 
> Improve the binding example by using 'touchscreen' as the node name.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  Documentation/devicetree/bindings/input/touchscreen/goodix.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
> index 2a2d86cfd104..eb4992f708b7 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
> @@ -69,7 +69,7 @@ examples:
>      i2c {
>        #address-cells = <1>;
>        #size-cells = <0>;
> -      gt928@5d {
> +      touchscreen@5d {
>          compatible = "goodix,gt928";
>          reg = <0x5d>;
>          interrupt-parent = <&gpio>;
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-08-30 15:39 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-29 18:30 [PATCH 1/2] dt-bindings: input: touchscreen: iqs7211: Use 'touchscreen' as node name Fabio Estevam
2024-08-29 18:30 ` [PATCH 2/2] dt-bindings: input: touchscreen: goodix: Use generic " Fabio Estevam
2024-08-30 14:19   ` Conor Dooley
2024-08-30 15:39   ` Rob Herring
2024-08-30 14:18 ` [PATCH 1/2] dt-bindings: input: touchscreen: iqs7211: Use 'touchscreen' as " Conor Dooley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).