From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: linux-input@vger.kernel.org
Cc: Michael Hennerich <michael.hennerich@analog.com>,
Ville Syrjala <syrjala@sci.fi>,
Support Opensource <support.opensource@diasemi.com>,
Eddie James <eajames@linux.ibm.com>,
Andrey Moiseev <o2g.org.ru@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
Javier Carrasco <javier.carrasco.cruz@gmail.com>,
Jeff LaBundy <jeff@labundy.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 13/22] Input: iqs269a - use cleanup facility for fwnodes
Date: Tue, 3 Sep 2024 21:48:05 -0700 [thread overview]
Message-ID: <20240904044806.1047847-1-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20240904044244.1042174-1-dmitry.torokhov@gmail.com>
Use __free(fwnode_handle) cleanup facility to ensure that references to
acquired fwnodes are dropped at appropriate times automatically.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/misc/iqs269a.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/input/misc/iqs269a.c b/drivers/input/misc/iqs269a.c
index c34d847fa4af..1851848e2cd3 100644
--- a/drivers/input/misc/iqs269a.c
+++ b/drivers/input/misc/iqs269a.c
@@ -550,7 +550,6 @@ static int iqs269_parse_chan(struct iqs269_private *iqs269,
const struct fwnode_handle *ch_node)
{
struct i2c_client *client = iqs269->client;
- struct fwnode_handle *ev_node;
struct iqs269_ch_reg *ch_reg;
u16 engine_a, engine_b;
unsigned int reg, val;
@@ -727,8 +726,9 @@ static int iqs269_parse_chan(struct iqs269_private *iqs269,
}
for (i = 0; i < ARRAY_SIZE(iqs269_events); i++) {
- ev_node = fwnode_get_named_child_node(ch_node,
- iqs269_events[i].name);
+ struct fwnode_handle *ev_node __free(fwnode_handle) =
+ fwnode_get_named_child_node(ch_node,
+ iqs269_events[i].name);
if (!ev_node)
continue;
@@ -737,7 +737,6 @@ static int iqs269_parse_chan(struct iqs269_private *iqs269,
dev_err(&client->dev,
"Invalid channel %u threshold: %u\n",
reg, val);
- fwnode_handle_put(ev_node);
return -EINVAL;
}
@@ -751,7 +750,6 @@ static int iqs269_parse_chan(struct iqs269_private *iqs269,
dev_err(&client->dev,
"Invalid channel %u hysteresis: %u\n",
reg, val);
- fwnode_handle_put(ev_node);
return -EINVAL;
}
@@ -767,7 +765,6 @@ static int iqs269_parse_chan(struct iqs269_private *iqs269,
}
error = fwnode_property_read_u32(ev_node, "linux,code", &val);
- fwnode_handle_put(ev_node);
if (error == -EINVAL) {
continue;
} else if (error) {
--
2.46.0.469.g59c65b2a67-goog
next prev parent reply other threads:[~2024-09-04 4:48 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 4:42 [PATCH 00/22] Convert misc input drivers to use new cleanup facilities Dmitry Torokhov
2024-09-04 4:42 ` [PATCH 01/22] Input: ad714x - use guard notation when acquiring mutex Dmitry Torokhov
2024-09-04 18:47 ` Javier Carrasco
2024-09-04 4:42 ` [PATCH 02/22] Input: ati_remote2 " Dmitry Torokhov
2024-09-04 18:49 ` Javier Carrasco
2024-09-04 4:42 ` [PATCH 03/22] Input: cm109 - use guard notation when acquiring mutex and spinlock Dmitry Torokhov
2024-09-04 19:44 ` Javier Carrasco
2024-09-04 4:42 ` [PATCH 04/22] Input: cma3000_d0x - use guard notation when acquiring mutex Dmitry Torokhov
2024-09-04 18:51 ` Javier Carrasco
2024-09-04 4:42 ` [PATCH 05/22] Input: da7280 - use guard notation when acquiring mutex and spinlock Dmitry Torokhov
2024-09-04 19:02 ` Javier Carrasco
2024-09-04 4:42 ` [PATCH 06/22] Input: kxtj9 - use guard notation when acquiring mutex/disabling irq Dmitry Torokhov
2024-09-04 19:03 ` Javier Carrasco
2024-09-04 4:42 ` [PATCH 07/22] Input: drv260x - use guard notation when acquiring mutex Dmitry Torokhov
2024-09-04 19:05 ` Javier Carrasco
2024-09-04 4:42 ` [PATCH 08/22] Input: drv2665 " Dmitry Torokhov
2024-09-04 19:07 ` Javier Carrasco
2024-09-04 4:42 ` [PATCH 09/22] Input: drv2667 " Dmitry Torokhov
2024-09-04 19:08 ` Javier Carrasco
2024-09-04 4:42 ` [PATCH 10/22] Input: ideapad_slidebar - use guard notation when acquiring spinlock Dmitry Torokhov
2024-09-04 19:09 ` Javier Carrasco
2024-09-04 4:47 ` [PATCH 11/22] Input: ibm-panel " Dmitry Torokhov
2024-09-04 19:11 ` Javier Carrasco
2024-09-04 21:56 ` Eddie James
2024-09-04 4:47 ` [PATCH 12/22] Input: iqs269a - use guard notation when acquiring mutex Dmitry Torokhov
2024-09-04 13:53 ` Javier Carrasco
2024-09-04 18:21 ` Dmitry Torokhov
2024-09-04 18:41 ` Javier Carrasco
2024-09-04 18:53 ` Dmitry Torokhov
2024-09-08 22:05 ` Jeff LaBundy
2024-09-04 4:48 ` Dmitry Torokhov [this message]
2024-09-04 11:13 ` [PATCH 13/22] Input: iqs269a - use cleanup facility for fwnodes Javier Carrasco
2024-09-08 22:08 ` Jeff LaBundy
2024-09-04 4:48 ` [PATCH 14/22] Input: iqs626a " Dmitry Torokhov
2024-09-04 11:10 ` Javier Carrasco
2024-09-09 0:02 ` Jeff LaBundy
2024-09-09 1:31 ` Dmitry Torokhov
2024-09-10 15:12 ` Jeff LaBundy
2024-09-04 4:48 ` [PATCH 15/22] Input: iqs7222 " Dmitry Torokhov
2024-09-04 10:50 ` Javier Carrasco
2024-09-04 18:26 ` Dmitry Torokhov
2024-09-04 18:46 ` Javier Carrasco
2024-09-09 0:12 ` Jeff LaBundy
2024-09-09 1:34 ` Dmitry Torokhov
2024-09-10 15:14 ` Jeff LaBundy
2024-09-04 4:48 ` [PATCH 16/22] Input: max8997_haptic - use guard notation when acquiring mutex Dmitry Torokhov
2024-09-04 19:12 ` Javier Carrasco
2024-09-04 4:48 ` [PATCH 17/22] Input: pegasus_notetaker " Dmitry Torokhov
2024-09-04 19:52 ` Javier Carrasco
2024-09-04 20:59 ` [PATCH v2 " Dmitry Torokhov
2024-09-04 4:49 ` [PATCH 18/22] Input: powermate - use guard notation when acquiring spinlock Dmitry Torokhov
2024-09-04 19:16 ` Javier Carrasco
2024-09-04 4:49 ` [PATCH 19/22] Input: pwm-beeper " Dmitry Torokhov
2024-09-04 19:22 ` Javier Carrasco
2024-09-04 4:49 ` [PATCH 20/22] Input: regulator-haptic - use guard notation when acquiring mutex Dmitry Torokhov
2024-09-04 19:27 ` Javier Carrasco
2024-09-04 20:55 ` [PATCH v2 " Dmitry Torokhov
2024-09-04 21:41 ` Javier Carrasco
2024-09-07 3:40 ` [PATCH " kernel test robot
2024-09-04 4:49 ` [PATCH 21/22] Input: rotary_encoder " Dmitry Torokhov
2024-09-04 19:32 ` Javier Carrasco
2024-09-04 4:49 ` [PATCH 22/22] Input: sparcspkr - use guard notation when acquiring spinlock Dmitry Torokhov
2024-09-04 19:33 ` Javier Carrasco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904044806.1047847-1-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=eajames@linux.ibm.com \
--cc=hdegoede@redhat.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jeff@labundy.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=o2g.org.ru@gmail.com \
--cc=support.opensource@diasemi.com \
--cc=syrjala@sci.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).