From: Jinjie Ruan <ruanjinjie@huawei.com>
To: <dmitry.torokhov@gmail.com>, <erick.archer@outlook.com>,
<u.kleine-koenig@pengutronix.de>, <danilokrummrich@dk-develop.de>,
<linus.walleij@linaro.org>, <robh@kernel.org>,
<linux-input@vger.kernel.org>
Cc: <ruanjinjie@huawei.com>
Subject: [PATCH] Input: ps2-gpio - Use IRQF_NO_AUTOEN flag in request_irq()
Date: Thu, 12 Sep 2024 11:30:13 +0800 [thread overview]
Message-ID: <20240912033013.2610949-1-ruanjinjie@huawei.com> (raw)
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable when request IRQ.
Fixes: 9ee0a0558819 ("Input: PS/2 gpio bit banging driver for serio bus")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/input/serio/ps2-gpio.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/input/serio/ps2-gpio.c b/drivers/input/serio/ps2-gpio.c
index 0c8b390b8b4f..3a431395c464 100644
--- a/drivers/input/serio/ps2-gpio.c
+++ b/drivers/input/serio/ps2-gpio.c
@@ -429,16 +429,14 @@ static int ps2_gpio_probe(struct platform_device *pdev)
}
error = devm_request_irq(dev, drvdata->irq, ps2_gpio_irq,
- IRQF_NO_THREAD, DRIVER_NAME, drvdata);
+ IRQF_NO_THREAD | IRQF_NO_AUTOEN, DRIVER_NAME,
+ drvdata);
if (error) {
dev_err(dev, "failed to request irq %d: %d\n",
drvdata->irq, error);
goto err_free_serio;
}
- /* Keep irq disabled until serio->open is called. */
- disable_irq(drvdata->irq);
-
serio->id.type = SERIO_8042;
serio->open = ps2_gpio_open;
serio->close = ps2_gpio_close;
--
2.34.1
next reply other threads:[~2024-09-12 3:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 3:30 Jinjie Ruan [this message]
2024-09-12 20:49 ` [PATCH] Input: ps2-gpio - Use IRQF_NO_AUTOEN flag in request_irq() Danilo Krummrich
2024-09-13 17:21 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240912033013.2610949-1-ruanjinjie@huawei.com \
--to=ruanjinjie@huawei.com \
--cc=danilokrummrich@dk-develop.de \
--cc=dmitry.torokhov@gmail.com \
--cc=erick.archer@outlook.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).