From: Conor Dooley <conor@kernel.org>
To: Charles Wang <charles.goodix@gmail.com>
Cc: dmitry.torokhov@gmail.com, dianders@chromium.org,
dan.carpenter@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
jikos@kernel.org, bentiss@kernel.org, hbarnor@chromium.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v8 2/2] dt-bindings: input: Goodix SPI HID Touchscreen
Date: Thu, 26 Sep 2024 12:13:59 +0100 [thread overview]
Message-ID: <20240926-password-cadmium-87ccdf950fd1@spud> (raw)
In-Reply-To: <20240926044217.9285-3-charles.goodix@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
On Thu, Sep 26, 2024 at 12:42:17PM +0800, Charles Wang wrote:
> The Goodix GT7986U touch controller report touch data according to the
> HID protocol through the SPI bus. However, it is incompatible with
> Microsoft's HID-over-SPI protocol.
>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Charles Wang <charles.goodix@gmail.com>
Please remove my reviewed by, I didn't review this new "spi"
compatible.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-09-26 11:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 4:42 [PATCH v8 0/2] HID: add initial support for Goodix HID-over-SPI touchscreen Charles Wang
2024-09-26 4:42 ` [PATCH v8 1/2] HID: hid-goodix: Add Goodix HID-over-SPI driver Charles Wang
2024-09-26 4:42 ` [PATCH v8 2/2] dt-bindings: input: Goodix SPI HID Touchscreen Charles Wang
2024-09-26 6:29 ` Krzysztof Kozlowski
2024-09-26 9:57 ` Charles Wang
2024-09-26 12:32 ` Krzysztof Kozlowski
2024-09-30 3:22 ` Charles Wang
2024-09-30 6:42 ` Krzysztof Kozlowski
2024-09-30 7:56 ` Charles Wang
2024-09-30 8:08 ` Krzysztof Kozlowski
2024-10-08 8:18 ` Charles Wang
2024-09-26 11:13 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926-password-cadmium-87ccdf950fd1@spud \
--to=conor@kernel.org \
--cc=bentiss@kernel.org \
--cc=charles.goodix@gmail.com \
--cc=conor.dooley@microchip.com \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hbarnor@chromium.org \
--cc=jikos@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).