Re: [PATCH 20/51] Input: omap4-keypad: Switch to __pm_runtime_put_autosuspend()

[Andreas Kemnade <andreas@kemnade.info>]

Am Fri,  4 Oct 2024 12:41:23 +0300
schrieb Sakari Ailus <sakari.ailus@linux.intel.com>:

> pm_runtime_put_autosuspend() will soon be changed to include a call to
> pm_runtime_mark_last_busy(). This patch switches the current users to
> __pm_runtime_put_autosuspend() which will continue to have the
> functionality of old pm_runtime_put_autosuspend().
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  drivers/input/keyboard/omap4-keypad.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/input/keyboard/omap4-keypad.c
> b/drivers/input/keyboard/omap4-keypad.c index
> 040b340995d8..cc8d77601fc7 100644 ---
> a/drivers/input/keyboard/omap4-keypad.c +++
> b/drivers/input/keyboard/omap4-keypad.c @@ -196,7 +196,7 @@ static
> irqreturn_t omap4_keypad_irq_thread_fn(int irq, void *dev_id)
> kbd_read_irqreg(keypad_data, OMAP4_KBD_IRQSTATUS)); 
>  	pm_runtime_mark_last_busy(dev);
> -	pm_runtime_put_autosuspend(dev);
> +	__pm_runtime_put_autosuspend(dev);
>  
>  	return IRQ_HANDLED;
>  }
> @@ -234,7 +234,7 @@ static int omap4_keypad_open(struct input_dev
> *input) 
>  out:
>  	pm_runtime_mark_last_busy(dev);
> -	pm_runtime_put_autosuspend(dev);
> +	__pm_runtime_put_autosuspend(dev);
>  
hmm, if pm_runtime_put_autosuspend() will include the call to
pm_runtime_mark_last_busy(), then why is this change needed?
After the change, the mark_last_busy could be removed.

Regards,
Andreas