linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Terry Tritton <terry.tritton@linaro.org>
To: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org,
	Aseda Aboagye <aaboagye@chromium.org>
Cc: Peter Griffin <peter.griffin@linaro.org>,
	Terry Tritton <ttritton@google.com>,
	Terry Tritton <terry.tritton@linaro.org>
Subject: [PATCH 0/1] Do Not Disturb broke GD D-pad
Date: Fri, 11 Oct 2024 20:58:07 +0100	[thread overview]
Message-ID: <20241011195808.2201-1-terry.tritton@linaro.org> (raw)

Hi, 
We noticed a breakage in the android test: CtsHardwareTestCases_cts_tests
android.hardware.input.cts.tests.GameviceGv186Test#testAllMotions

I bisected the issue to:
	commit 22d6d060ac77 ("input: Add support for "Do Not Disturb"")
The cause is pretty clear there are 2 separate checks for:
	if ((usage->hid & 0xf0) == 0x90)
so the second one which handles the d-pad is getting skipped.

I've combined them both in the following patch which works for me.

Thanks

Terry Tritton (1):
  input: fix generic desktop D-Pad controls

 drivers/hid/hid-input.c | 37 +++++++++++++++++--------------------
 include/linux/hid.h     |  1 +
 2 files changed, 18 insertions(+), 20 deletions(-)

-- 
2.39.5


             reply	other threads:[~2024-10-11 19:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11 19:58 Terry Tritton [this message]
2024-10-11 19:58 ` [PATCH 1/1] input: fix generic desktop D-Pad controls Terry Tritton
2024-10-14 22:02   ` Aseda Aboagye
2024-11-07 23:21   ` Carlos Llamas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241011195808.2201-1-terry.tritton@linaro.org \
    --to=terry.tritton@linaro.org \
    --cc=aaboagye@chromium.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=ttritton@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).