linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philipp Stanner <pstanner@redhat.com>
To: "Damien Le Moal" <dlemoal@kernel.org>,
	"Niklas Cassel" <cassel@kernel.org>,
	"Sergey Shtylyov" <s.shtylyov@omp.ru>,
	"Basavaraj Natikar" <basavaraj.natikar@amd.com>,
	"Jiri Kosina" <jikos@kernel.org>,
	"Benjamin Tissoires" <bentiss@kernel.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Alex Dubov" <oakad@yahoo.com>,
	"Sudarsana Kalluru" <skalluru@marvell.com>,
	"Manish Chopra" <manishc@marvell.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Rasesh Mody" <rmody@marvell.com>,
	GR-Linux-NIC-Dev@marvell.com,
	"Igor Mitsyanko" <imitsyanko@quantenna.com>,
	"Sergey Matyukevich" <geomatsi@gmail.com>,
	"Kalle Valo" <kvalo@kernel.org>,
	"Sanjay R Mehta" <sanju.mehta@amd.com>,
	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
	"Jon Mason" <jdmason@kudzu.us>,
	"Dave Jiang" <dave.jiang@intel.com>,
	"Allen Hubbe" <allenbh@gmail.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Juergen Gross" <jgross@suse.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam.com>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>, "Chen Ni" <nichen@iscas.ac.cn>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	"Philipp Stanner" <pstanner@redhat.com>,
	"Ricky Wu" <ricky_wu@realtek.com>,
	"Al Viro" <viro@zeniv.linux.org.uk>,
	"Breno Leitao" <leitao@debian.org>,
	"Kevin Tian" <kevin.tian@intel.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Mostafa Saleh" <smostafa@google.com>,
	"Jason Gunthorpe" <jgg@ziepe.ca>, "Yi Liu" <yi.l.liu@intel.com>,
	"Christian Brauner" <brauner@kernel.org>,
	"Ankit Agrawal" <ankita@nvidia.com>,
	"Eric Auger" <eric.auger@redhat.com>,
	"Reinette Chatre" <reinette.chatre@intel.com>,
	"Ye Bin" <yebin10@huawei.com>,
	"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
	"Pierre-Louis Bossart" <pierre-louis.bossart@linux.dev>,
	"Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
	"Rui Salvaterra" <rsalvaterra@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-input@vger.kernel.org, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, ntb@lists.linux.dev,
	linux-pci@vger.kernel.org, kvm@vger.kernel.org,
	xen-devel@lists.xenproject.org, linux-sound@vger.kernel.org
Subject: [PATCH 09/13] ata: Use always-managed version of pci_intx()
Date: Tue, 15 Oct 2024 20:51:19 +0200	[thread overview]
Message-ID: <20241015185124.64726-10-pstanner@redhat.com> (raw)
In-Reply-To: <20241015185124.64726-1-pstanner@redhat.com>

pci_intx() is a hybrid function which can sometimes be managed through
devres. To remove this hybrid nature from pci_intx(), it is necessary to
port users to either an always-managed or a never-managed version.

All users in ata enable their PCI-Device with pcim_enable_device(). Thus,
they need the always-managed version.

Replace pci_intx() with pcim_intx().

Signed-off-by: Philipp Stanner <pstanner@redhat.com>
---
 drivers/ata/ahci.c       | 2 +-
 drivers/ata/ata_piix.c   | 2 +-
 drivers/ata/pata_rdc.c   | 2 +-
 drivers/ata/sata_sil24.c | 2 +-
 drivers/ata/sata_sis.c   | 2 +-
 drivers/ata/sata_uli.c   | 2 +-
 drivers/ata/sata_vsc.c   | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 45f63b09828a..9273ff3d4732 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1985,7 +1985,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 	if (ahci_init_msi(pdev, n_ports, hpriv) < 0) {
 		/* legacy intx interrupts */
-		pci_intx(pdev, 1);
+		pcim_intx(pdev, 1);
 	}
 	hpriv->irq = pci_irq_vector(pdev, 0);
 
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index 093b940bc953..d441246fa357 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -1725,7 +1725,7 @@ static int piix_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	 * message-signalled interrupts currently).
 	 */
 	if (port_flags & PIIX_FLAG_CHECKINTR)
-		pci_intx(pdev, 1);
+		pcim_intx(pdev, 1);
 
 	if (piix_check_450nx_errata(pdev)) {
 		/* This writes into the master table but it does not
diff --git a/drivers/ata/pata_rdc.c b/drivers/ata/pata_rdc.c
index 0a9689862f71..09792aac7f9d 100644
--- a/drivers/ata/pata_rdc.c
+++ b/drivers/ata/pata_rdc.c
@@ -340,7 +340,7 @@ static int rdc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 		return rc;
 	host->private_data = hpriv;
 
-	pci_intx(pdev, 1);
+	pcim_intx(pdev, 1);
 
 	host->flags |= ATA_HOST_PARALLEL_SCAN;
 
diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
index 72c03cbdaff4..b771ebd41252 100644
--- a/drivers/ata/sata_sil24.c
+++ b/drivers/ata/sata_sil24.c
@@ -1317,7 +1317,7 @@ static int sil24_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 	if (sata_sil24_msi && !pci_enable_msi(pdev)) {
 		dev_info(&pdev->dev, "Using MSI\n");
-		pci_intx(pdev, 0);
+		pcim_intx(pdev, 0);
 	}
 
 	pci_set_master(pdev);
diff --git a/drivers/ata/sata_sis.c b/drivers/ata/sata_sis.c
index ef8724986de3..b8b6d9eff3b8 100644
--- a/drivers/ata/sata_sis.c
+++ b/drivers/ata/sata_sis.c
@@ -290,7 +290,7 @@ static int sis_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	}
 
 	pci_set_master(pdev);
-	pci_intx(pdev, 1);
+	pcim_intx(pdev, 1);
 	return ata_host_activate(host, pdev->irq, ata_bmdma_interrupt,
 				 IRQF_SHARED, &sis_sht);
 }
diff --git a/drivers/ata/sata_uli.c b/drivers/ata/sata_uli.c
index 60ea45926cd1..52894ff49dcb 100644
--- a/drivers/ata/sata_uli.c
+++ b/drivers/ata/sata_uli.c
@@ -221,7 +221,7 @@ static int uli_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	}
 
 	pci_set_master(pdev);
-	pci_intx(pdev, 1);
+	pcim_intx(pdev, 1);
 	return ata_host_activate(host, pdev->irq, ata_bmdma_interrupt,
 				 IRQF_SHARED, &uli_sht);
 }
diff --git a/drivers/ata/sata_vsc.c b/drivers/ata/sata_vsc.c
index d39b87537168..a53a2dfc1e17 100644
--- a/drivers/ata/sata_vsc.c
+++ b/drivers/ata/sata_vsc.c
@@ -384,7 +384,7 @@ static int vsc_sata_init_one(struct pci_dev *pdev,
 		pci_write_config_byte(pdev, PCI_CACHE_LINE_SIZE, 0x80);
 
 	if (pci_enable_msi(pdev) == 0)
-		pci_intx(pdev, 0);
+		pcim_intx(pdev, 0);
 
 	/*
 	 * Config offset 0x98 is "Extended Control and Status Register 0"
-- 
2.47.0


  parent reply	other threads:[~2024-10-15 18:52 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 18:51 [PATCH 00/13] Remove implicit devres from pci_intx() Philipp Stanner
2024-10-15 18:51 ` [PATCH 01/13] PCI: Prepare removing " Philipp Stanner
2024-10-31 13:45   ` Thomas Gleixner
2024-11-04  9:26     ` Philipp Stanner
2024-10-15 18:51 ` [PATCH 02/13] ALSA: hda_intel: Use always-managed version of pcim_intx() Philipp Stanner
2024-10-22 14:08   ` Takashi Iwai
2024-10-23 13:50     ` Philipp Stanner
2024-10-23 15:03       ` Takashi Iwai
2024-10-24  8:02         ` Philipp Stanner
2024-10-24 15:43           ` Takashi Iwai
2024-10-25  8:37             ` Philipp Stanner
2024-10-25  8:46               ` Takashi Iwai
2024-10-15 18:51 ` [PATCH 03/13] drivers/xen: Use never-managed version of pci_intx() Philipp Stanner
2024-10-15 18:51 ` [PATCH 04/13] net/ethernet: " Philipp Stanner
2024-10-15 18:51 ` [PATCH 05/13] net/ntb: " Philipp Stanner
2024-10-15 18:51 ` [PATCH 06/13] misc: " Philipp Stanner
2024-10-15 18:51 ` [PATCH 07/13] vfio/pci: " Philipp Stanner
2024-10-15 18:51 ` [PATCH 08/13] PCI: MSI: " Philipp Stanner
2024-10-15 18:51 ` Philipp Stanner [this message]
2024-10-16 19:49   ` [PATCH 09/13] ata: Use always-managed " Sergey Shtylyov
2024-10-17  7:51   ` Niklas Cassel
2024-10-15 18:51 ` [PATCH 10/13] wifi: qtnfmac: use always-managed version of pcim_intx() Philipp Stanner
2024-10-16  9:36   ` Kalle Valo
2024-10-15 18:51 ` [PATCH 11/13] HID: amd_sfh: Use " Philipp Stanner
2024-10-15 18:51 ` [PATCH 12/13] Remove devres from pci_intx() Philipp Stanner
2024-10-15 18:51 ` [PATCH 13/13] PCI: Deprecate pci_intx(), pcim_intx() Philipp Stanner
2024-10-15 19:53   ` Alex Williamson
2024-10-16  6:57     ` Philipp Stanner
2024-10-16  8:43       ` Heiner Kallweit
2024-10-16  8:53         ` Philipp Stanner
2024-10-18 23:45           ` Bjorn Helgaas
2024-10-21  6:47             ` Philipp Stanner
2024-10-16  5:39   ` Greg Kroah-Hartman
2024-10-30 22:17 ` [PATCH 00/13] Remove implicit devres from pci_intx() Bjorn Helgaas
2024-10-31  9:19   ` Takashi Iwai
2024-10-31  9:28     ` Philipp Stanner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241015185124.64726-10-pstanner@redhat.com \
    --to=pstanner@redhat.com \
    --cc=GR-Linux-NIC-Dev@marvell.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=alex.williamson@redhat.com \
    --cc=allenbh@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ankita@nvidia.com \
    --cc=arnd@arndb.de \
    --cc=basavaraj.natikar@amd.com \
    --cc=bentiss@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=brauner@kernel.org \
    --cc=cassel@kernel.org \
    --cc=dave.jiang@intel.com \
    --cc=davem@davemloft.net \
    --cc=dlemoal@kernel.org \
    --cc=edumazet@google.com \
    --cc=eric.auger@redhat.com \
    --cc=geomatsi@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=imitsyanko@quantenna.com \
    --cc=jdmason@kudzu.us \
    --cc=jgg@ziepe.ca \
    --cc=jgross@suse.com \
    --cc=jikos@kernel.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=kevin.tian@intel.com \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=manishc@marvell.com \
    --cc=mario.limonciello@amd.com \
    --cc=marmarek@invisiblethingslab.com \
    --cc=netdev@vger.kernel.org \
    --cc=nichen@iscas.ac.cn \
    --cc=ntb@lists.linux.dev \
    --cc=oakad@yahoo.com \
    --cc=oleksandr_tyshchenko@epam.com \
    --cc=pabeni@redhat.com \
    --cc=perex@perex.cz \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=reinette.chatre@intel.com \
    --cc=ricky_wu@realtek.com \
    --cc=rmody@marvell.com \
    --cc=rsalvaterra@gmail.com \
    --cc=s.shtylyov@omp.ru \
    --cc=sanju.mehta@amd.com \
    --cc=skalluru@marvell.com \
    --cc=smostafa@google.com \
    --cc=sstabellini@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tiwai@suse.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xen-devel@lists.xenproject.org \
    --cc=yebin10@huawei.com \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).