From: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
To: Jiri Kosina <jikos@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Benjamin Tissoires <bentiss@kernel.org>,
Bryan.Kemp@dell.com, laurentiu.tudor1@dell.com,
Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
Subject: [PATCH v2 0/2] HID: i2c-hid: re-power-on quirk for QTEC kbrd
Date: Thu, 31 Oct 2024 08:31:40 +0100 [thread overview]
Message-ID: <20241031073419.9189-1-alex.vinarskis@gmail.com> (raw)
Resolve keyboard not working out of the box for Dell XPS 9345 13"
codenamed 'tributo'. X1E80100-based laptop's initial support is currently
being upstreamed [1].
In present state, keyboard is succesfully initialized, however attempt to type
anything throws 'incomplete report' errors. When utilizing
I2C_HID_QUIRK_BAD_INPUT_SIZE quirk the error is gone, however raw data coming
from the keyboard is always the same, no matter the key pressed. Issue
'resolves' itself when suspending and resuming the device.
It appears that calling power on command one more time after device
initialization before finishing off the probing fixes this weird behavior, and
keyboard works right away.
Introduce a new quirk for such behaviour, and enable it for particular keyboard.
Vendor is shown as 'QTEC', however device id is reported as 0000. Given that
vendor was not present before, using HID_ANY_ID to match the device should be
okay in this case.
In v1 it was suggested to make a dedicated i2c-of-qtec driver, but I was not
sure how to proceed at the time. I have now drafted a dedicated driver, and it
really is just probe method being extended to call powerup command again. Given
that a similarly 'ugly' quirk was just merged to i2c-hid-core.c for a Goodix
device [2], and that (IMO) creating a dedicated driver for such a small change
without any plan on extending it will be just polluting, I am asking you to
consider this change again. Alternatively, if it is yet still strongly
preferred to have a dedicated driver to include this quirk, please let me know
so I can proceed accordingly.
[1] https://lore.kernel.org/all/20241003211139.9296-1-alex.vinarskis@gmail.com/
[2] https://lore.kernel.org/all/20241007222629.172047-1-marynczakbartlomiej@gmail.com/
--------
Changes to V1:
* Rebase on top of latest linux-next
* Update coverletter's reasoning and links
* link: https://lore.kernel.org/all/20240925100303.9112-1-alex.vinarskis@gmail.com/
Aleksandrs Vinarskis (2):
HID: i2c-hid: introduce re-power-on quirk
HID: i2c-hid: introduce qtec vendor, enable re-power-on quirk
drivers/hid/hid-ids.h | 2 ++
drivers/hid/i2c-hid/i2c-hid-core.c | 12 +++++++++++-
2 files changed, 13 insertions(+), 1 deletion(-)
--
2.45.2
next reply other threads:[~2024-10-31 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 7:31 Aleksandrs Vinarskis [this message]
2024-10-31 7:31 ` [PATCH v2 1/2] HID: i2c-hid: introduce re-power-on quirk Aleksandrs Vinarskis
2024-10-31 7:31 ` [PATCH v2 2/2] HID: i2c-hid: introduce qtec vendor, enable " Aleksandrs Vinarskis
2024-10-31 16:26 ` [PATCH v2 0/2] HID: i2c-hid: re-power-on quirk for QTEC kbrd Tudor, Laurentiu
2024-12-11 14:06 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031073419.9189-1-alex.vinarskis@gmail.com \
--to=alex.vinarskis@gmail.com \
--cc=Bryan.Kemp@dell.com \
--cc=bentiss@kernel.org \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=laurentiu.tudor1@dell.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).