From: Charles Wang <charles.goodix@gmail.com>
To: dmitry.torokhov@gmail.com, hbarnor@chromium.org
Cc: jikos@kernel.org, bentiss@kernel.org, dianders@chromium.org,
dan.carpenter@linaro.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org,
Charles Wang <charles.goodix@gmail.com>
Subject: [PATCH v2 0/2] HID: hid-goodix: Improve handling of HID feature reports
Date: Thu, 31 Oct 2024 20:31:11 +0800 [thread overview]
Message-ID: <20241031123113.18843-1-charles.goodix@gmail.com> (raw)
The patchset introduces the following two changes:
1) Align with the i2c-hid driver by returning 0 instead of -EINVAL when
an empty response is received, ensuring that userspace programs utilizing
the hidraw node receive consistent return values.
2) Implement the hid get/set feature report function using a separate
address, rather than sharing an address with coordinate reporting, to
prevent feature events from being overwritten by coordinate events.
Signed-off-by: Charles Wang <charles.goodix@gmail.com>
---
Changes in v2:
- Split the commit into two patches.
---
Charles Wang (2):
HID: hid-goodix: Return 0 when receiving an empty HID feature package
HID: hid-goodix: Fix HID get/set feature operation overwritten problem
drivers/hid/hid-goodix-spi.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
--
2.43.0
next reply other threads:[~2024-10-31 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 12:31 Charles Wang [this message]
2024-10-31 12:31 ` [PATCH v2 1/2] HID: hid-goodix: Return 0 when receiving an empty HID feature package Charles Wang
2024-10-31 12:31 ` [PATCH v2 2/2] HID: hid-goodix: Fix HID get/set feature operation overwritten problem Charles Wang
2024-11-06 14:09 ` [PATCH v2 0/2] HID: hid-goodix: Improve handling of HID feature reports Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031123113.18843-1-charles.goodix@gmail.com \
--to=charles.goodix@gmail.com \
--cc=bentiss@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hbarnor@chromium.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).