linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Markus Burri <markus.burri@mt.com>
Cc: linux-kernel@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Marek Vasut <marek.vasut@gmail.com>,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 5/7] dt-bindings: input: matrix_keypad - add settle time after enable all columns
Date: Mon, 11 Nov 2024 15:38:38 -0600	[thread overview]
Message-ID: <20241111213838.GA1990975-robh@kernel.org> (raw)
In-Reply-To: <20241105130322.213623-6-markus.burri@mt.com>

On Tue, Nov 05, 2024 at 02:03:20PM +0100, Markus Burri wrote:
> matrix_keypad with high capacity need a longer settle time after enable
> all columns.
> Add optional property to specify the settle time
> 
> Signed-off-by: Markus Burri <markus.burri@mt.com>
> ---
>  .../devicetree/bindings/input/gpio-matrix-keypad.yaml       | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml
> index 9ea66b3..0ce89a6 100644
> --- a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml
> +++ b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml
> @@ -66,6 +66,12 @@ properties:
>        before we can scan keypad after activating column gpio.
>      default: 0
>  
> +  all-cols-on-delay-us:
> +    description: |

Don't need '|'.

> +      Delay, measured in microseconds, that is needed
> +      after activating all column gpios.

Wrap at 80 char.

> +    default: 0
> +
>    drive-inactive-cols:
>      type: boolean
>      description: |
> -- 
> 2.39.5
> 

  reply	other threads:[~2024-11-11 21:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31  6:29 [PATCH 0/6] Input: matrix-keypad: Various performance improvements Markus Burri
2024-10-31  6:29 ` [PATCH 1/6] Input: matrix_keypad - move gpio-row init to the init part Markus Burri
2024-10-31  6:30 ` [PATCH 2/6] Input: matrix_keypad - use fsleep for variable delay duration Markus Burri
2024-10-31  6:30 ` [PATCH 3/6] Input: matrix_keypad - add function for reading row state Markus Burri
2024-10-31  6:30 ` [PATCH 4/6] dt-bindings: input: matrix_keypad - add settle time after enable all columns Markus Burri
2024-10-31  8:32   ` Krzysztof Kozlowski
2024-10-31  6:30 ` [PATCH 5/6] Input: " Markus Burri
2024-10-31  6:30 ` [PATCH 6/6] Input: matrix_keypad - detect change during scan Markus Burri
2024-11-05 13:03 ` [PATCH v2 0/7] Input: matrix-keypad: Various performance improvements Markus Burri
2024-11-05 13:03   ` [PATCH v2 1/7] Input: matrix_keypad - use fsleep for variable delay duration Markus Burri
2024-11-05 19:16     ` Dmitry Torokhov
2024-11-05 13:03   ` [PATCH v2 2/7] Input: matrix_keypad - add function for reading row state Markus Burri
2024-11-05 13:03   ` [PATCH v2 3/7] dt-bindings: input: matrix_keypad - convert to YAML Markus Burri
2024-11-05 17:20     ` kernel test robot
2024-11-11 21:37     ` Rob Herring
2024-11-05 13:03   ` [PATCH v2 4/7] dt-bindings: input: matrix_keypad - add missing property Markus Burri
2024-11-05 18:22     ` Conor Dooley
2024-11-05 19:14       ` Dmitry Torokhov
2024-11-06 16:24         ` Conor Dooley
2024-11-05 13:03   ` [PATCH v2 5/7] dt-bindings: input: matrix_keypad - add settle time after enable all columns Markus Burri
2024-11-11 21:38     ` Rob Herring [this message]
2024-11-05 13:03   ` [PATCH v2 6/7] Input: " Markus Burri
2024-11-05 13:03   ` [PATCH v2 7/7] Input: matrix_keypad - detect change during scan Markus Burri
2024-11-05 19:19     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241111213838.GA1990975-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.vasut@gmail.com \
    --cc=markus.burri@mt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).