From: Conor Dooley <conor@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Support Opensource <support.opensource@diasemi.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Roy Im <roy.im.opensource@diasemi.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: input: convert dlg,da7280.txt to dt-schema
Date: Wed, 4 Dec 2024 17:55:56 +0000 [thread overview]
Message-ID: <20241204-duplicity-throwing-42a3faca5199@spud> (raw)
In-Reply-To: <20241204-topic-misc-da7280-convert-v1-1-0f89971beca9@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]
On Wed, Dec 04, 2024 at 11:54:35AM +0100, Neil Armstrong wrote:
> + dlg,bemf-sens-enable:
> + type: boolean
> + description:
> + Enable for internal loop computations
> +
> + dlg,freq-track-enable:
> + type: boolean
> + description:
> + Enable for resonant frequency tracking
> +
> + dlg,acc-enable:
> + type: boolean
> + description:
> + Enable for active acceleration
> +
> + dlg,rapid-stop-enable:
> + type: boolean
> + description:
> + Enable for rapid stop
> +
> + dlg,amp-pid-enable:
> + type: boolean
Shouldn't these ones be "flag"?
> + description:
> + Enable for the amplitude PID
> +
> + dlg,mem-array:
> + $ref: /schemas/types.yaml#/definitions/uint8-array
> + minItems: 100
> + description:
> + Customized waveform memory (patterns) data downloaded to the device during initialization
> +
> +required:
> + - compatible
Is this right? The text binding has: compatible, reg, interrupt-parent,
and a handful of vendor properties required. I don't see a mention for
the drop in the commit message.
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-12-04 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 10:54 [PATCH] dt-bindings: input: convert dlg,da7280.txt to dt-schema Neil Armstrong
2024-12-04 17:55 ` Conor Dooley [this message]
2024-12-06 8:24 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241204-duplicity-throwing-42a3faca5199@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=roy.im.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox