linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Rojtberg <rojtberg@gmail.com>
To: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
	gregkh@linuxfoundation.org
Cc: Andrei Ilyashenko <andrei.ilyashenko@gmail.com>,
	Pavel Rojtberg <rojtberg@gmail.com>
Subject: [PATCH 08/13] Input: xpad - add support for Xbox ONE liquid metal controller
Date: Sun,  5 Jan 2025 20:37:45 +0100	[thread overview]
Message-ID: <20250105193750.91460-9-rojtberg@gmail.com> (raw)
In-Reply-To: <20250105193750.91460-1-rojtberg@gmail.com>

From: Andrei Ilyashenko <andrei.ilyashenko@gmail.com>

I found that my controller wasn't working with this driver.  The LED would light up and it could rumble but was not registering any button presses or joystick movements.  I suspected the problem might be that it was not being sent some required init packet so I tried sending the packets being used in xboxone_init_packets and found that sending xboxone_pdp_auth got the controller working.  At least for my controller xboxone_pdp_led_on was not strictly necessary but I decided to follow the same pattern used by the other two controllers.

Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
---
 drivers/input/joystick/xpad.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 450a45152d63..b2716b49d3b6 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -694,7 +694,9 @@ static const struct xboxone_init_packet xboxone_init_packets[] = {
 	XBOXONE_INIT_PKT(0x045e, 0x0b00, xboxone_s_init),
 	XBOXONE_INIT_PKT(0x045e, 0x0b00, extra_input_packet_init),
 	XBOXONE_INIT_PKT(0x0e6f, 0x0000, xboxone_pdp_led_on),
+	XBOXONE_INIT_PKT(0x20d6, 0xa01a, xboxone_pdp_led_on),
 	XBOXONE_INIT_PKT(0x0e6f, 0x0000, xboxone_pdp_auth),
+	XBOXONE_INIT_PKT(0x20d6, 0xa01a, xboxone_pdp_auth),
 	XBOXONE_INIT_PKT(0x24c6, 0x541a, xboxone_rumblebegin_init),
 	XBOXONE_INIT_PKT(0x24c6, 0x542a, xboxone_rumblebegin_init),
 	XBOXONE_INIT_PKT(0x24c6, 0x543a, xboxone_rumblebegin_init),
-- 
2.43.0


  parent reply	other threads:[~2025-01-05 19:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-05 19:37 [PATCH 00/13] Input: xpad - sync with github fork Pavel Rojtberg
2025-01-05 19:37 ` [PATCH 01/13] Input: xpad - improve name of 8BitDo controller 2dc8:3106 Pavel Rojtberg
2025-01-05 19:37 ` [PATCH 02/13] Input: xpad - add support for 8BitDo Ultimate bluetooth/hall effect variant Pavel Rojtberg
2025-01-05 19:37 ` [PATCH 03/13] Input: xpad - add support for wooting two he (arm) Pavel Rojtberg
2025-01-05 19:37 ` [PATCH 04/13] Input: xpad - add support for SCUF Instinct Pavel Rojtberg
2025-01-05 19:37 ` [PATCH 05/13] Input: xpad - add Black Shark Green Ghost controller support Pavel Rojtberg
2025-01-06  7:08   ` Greg KH
2025-01-05 19:37 ` [PATCH 06/13] Input: xpad - add Hori Racing Wheel Overdrive for Xbox Series X Pavel Rojtberg
2025-01-05 19:37 ` [PATCH 07/13] Input: xpad - add support for Nacon Pro Compact Model NC7271 Pavel Rojtberg
2025-01-05 19:37 ` Pavel Rojtberg [this message]
2025-01-06  7:08   ` [PATCH 08/13] Input: xpad - add support for Xbox ONE liquid metal controller Greg KH
2025-01-05 19:37 ` [PATCH 09/13] Input: xpad - add USB ID for Nacon Revolution5 Pro Pavel Rojtberg
2025-01-05 19:37 ` [PATCH 10/13] Input: xpad - added Turtle Beach Recon support Pavel Rojtberg
2025-01-05 19:37 ` [PATCH 11/13] Input: xpad - add support for Nacon Evol-X Xbox One Controller Pavel Rojtberg
2025-01-05 19:37 ` [PATCH 12/13] Input: xpad - add support for PDP Mirror's Edge controller Pavel Rojtberg
2025-01-05 19:37 ` [PATCH 13/13] Input: xpad - add support for Thrustmaster ESWAP X2 ELDEN RING Pavel Rojtberg
2025-01-06  7:09 ` [PATCH 00/13] Input: xpad - sync with github fork Greg KH
2025-01-06  7:17   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250105193750.91460-9-rojtberg@gmail.com \
    --to=rojtberg@gmail.com \
    --cc=andrei.ilyashenko@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).