From: Markus Burri <markus.burri@mt.com>
To: linux-kernel@vger.kernel.org
Cc: Markus Burri <markus.burri@mt.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: [PATCH v3 2/7] Input: matrix_keypad - add function for reading row state
Date: Tue, 7 Jan 2025 14:56:54 +0100 [thread overview]
Message-ID: <20250107135659.185293-3-markus.burri@mt.com> (raw)
In-Reply-To: <20250107135659.185293-1-markus.burri@mt.com>
Move the evaluation of a row state into separate function.
It will be also used by a change later in this series.
Signed-off-by: Markus Burri <markus.burri@mt.com>
---
drivers/input/keyboard/matrix_keypad.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c
index 5571d2e..90148d3 100644
--- a/drivers/input/keyboard/matrix_keypad.c
+++ b/drivers/input/keyboard/matrix_keypad.c
@@ -100,6 +100,16 @@ static void disable_row_irqs(struct matrix_keypad *keypad)
disable_irq_nosync(keypad->row_irqs[i]);
}
+static uint32_t read_row_state(struct matrix_keypad *keypad)
+{
+ int row;
+ u32 row_state = 0;
+
+ for (row = 0; row < keypad->num_row_gpios; row++)
+ row_state |= row_asserted(keypad, row) ? BIT(row) : 0;
+ return row_state;
+}
+
/*
* This gets the keys from keyboard and reports it to input subsystem
*/
@@ -125,9 +135,7 @@ static void matrix_keypad_scan(struct work_struct *work)
activate_col(keypad, col, true);
- for (row = 0; row < keypad->num_row_gpios; row++)
- new_state[col] |=
- row_asserted(keypad, row) ? BIT(row) : 0;
+ new_state[col] = read_row_state(keypad);
activate_col(keypad, col, false);
}
--
2.39.5
next prev parent reply other threads:[~2025-01-07 14:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 13:56 [PATCH v3 0/7] Input: matrix-keypad: Various performance improvements Markus Burri
2025-01-07 13:56 ` [PATCH v3 1/7] Input: matrix_keypad - use fsleep for variable delay duration Markus Burri
2025-01-07 19:33 ` Thomas Weißschuh
2025-01-07 13:56 ` Markus Burri [this message]
2025-01-07 13:56 ` [PATCH v3 3/7] dt-bindings: input: matrix_keypad - convert to YAML Markus Burri
2025-01-07 19:09 ` Rob Herring
2025-01-07 13:56 ` [PATCH v3 4/7] dt-bindings: input: matrix_keypad - add missing property Markus Burri
2025-01-07 19:27 ` Rob Herring
2025-01-09 6:04 ` Dmitry Torokhov
2025-01-09 7:53 ` EXTERNAL - " Markus Burri
2025-01-08 8:34 ` Krzysztof Kozlowski
2025-01-07 13:56 ` [PATCH v3 5/7] dt-bindings: input: matrix_keypad - add settle time after enable all columns Markus Burri
2025-01-07 19:27 ` Rob Herring (Arm)
2025-01-07 13:56 ` [PATCH v3 6/7] Input: " Markus Burri
2025-01-07 13:56 ` [PATCH v3 7/7] Input: matrix_keypad - detect change during scan Markus Burri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250107135659.185293-3-markus.burri@mt.com \
--to=markus.burri@mt.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).