From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5D162A1A4; Mon, 3 Feb 2025 11:19:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738581597; cv=none; b=QWDHnJGf8ObC7UDr7BlxY5d/AIQ53Mr+7Za3ehakr2cfCP7Q7fgwr3yZypcfbXKyULdfRPaujPHUWjHci+DzUYzLCDEhCtrw8l0qbxPHb42cd6Je5ahZ/0FFDDGqCUOptYzJjYP2vbNwCpGWLmJuvZennc1a+zEutkb9+MrJcB4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738581597; c=relaxed/simple; bh=ZVRvgWsfvODU6Nzt/A5cjd5bh6rvxFxXYbmzsiYUAx8=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JspvmPeImPoBPzsnd8n8BvekhTPPvzqt4XXQt4hvO0zxjTZ+JqtfJT8UHhcBxE2R/GMECx34anmz//33bEga3ZEbGFuYOgWodNq2/RYn5qUkQkxHClWYh7Yge1WEk3iYOqtDKMcIwlGK8yEy4lL0lSjFUOC/as/CCD4EWNJxwcs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YmkVp4s9fz6M4S5; Mon, 3 Feb 2025 19:17:38 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 5650414011B; Mon, 3 Feb 2025 19:19:51 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 3 Feb 2025 12:19:50 +0100 Date: Mon, 3 Feb 2025 11:19:49 +0000 From: Jonathan Cameron To: Raag Jadav CC: , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 02/20] iio: imu: st_lsm9ds0: Replace device.h with what is needed Message-ID: <20250203111949.00002fa7@huawei.com> In-Reply-To: <20250203080902.1864382-3-raag.jadav@intel.com> References: <20250203080902.1864382-1-raag.jadav@intel.com> <20250203080902.1864382-3-raag.jadav@intel.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500002.china.huawei.com (7.191.160.78) To frapeml500008.china.huawei.com (7.182.85.71) On Mon, 3 Feb 2025 13:38:44 +0530 Raag Jadav wrote: > From: Andy Shevchenko > > Instead of including a huge device.h with tons of dependencies > include only what driver actually uses. > > Signed-off-by: Andy Shevchenko I'm fine with these going whatever route makes sense. Acked-by: Jonathan Cameron > --- > drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c | 2 +- > drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c > index 0732cfa258c4..8cc071463249 100644 > --- a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c > +++ b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c > @@ -7,7 +7,7 @@ > * Author: Andy Shevchenko > */ > > -#include > +#include > #include > #include > #include > diff --git a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c > index 43ec57c1e604..806e55f75f65 100644 > --- a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c > +++ b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c > @@ -7,7 +7,7 @@ > * Author: Andy Shevchenko > */ > > -#include > +#include > #include > #include > #include