From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Peng Fan <peng.fan@nxp.com>
Subject: [PATCH 3/4] input: misc: nxp-bbnsm-pwrkey: Use resource managed API to simplify code
Date: Wed, 05 Feb 2025 08:45:16 +0800 [thread overview]
Message-ID: <20250205-input-cleanup-v1-3-9758898ff8cb@nxp.com> (raw)
In-Reply-To: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com>
From: Peng Fan <peng.fan@nxp.com>
Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the
'driver.remove()' hook.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/input/misc/nxp-bbnsm-pwrkey.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/input/misc/nxp-bbnsm-pwrkey.c b/drivers/input/misc/nxp-bbnsm-pwrkey.c
index 7ba8d166d68c18b396e616f6f9074ae98c4629b7..5faad2c98af35c52dcacbf25728dbaf2cbb3c625 100644
--- a/drivers/input/misc/nxp-bbnsm-pwrkey.c
+++ b/drivers/input/misc/nxp-bbnsm-pwrkey.c
@@ -179,20 +179,17 @@ static int bbnsm_pwrkey_probe(struct platform_device *pdev)
return error;
}
- device_init_wakeup(&pdev->dev, true);
- error = dev_pm_set_wake_irq(&pdev->dev, bbnsm->irq);
+ error = devm_device_init_wakeup(&pdev->dev);
+ if (error)
+ return error;
+
+ error = devm_pm_set_wake_irq(&pdev->dev, bbnsm->irq);
if (error)
dev_warn(&pdev->dev, "irq wake enable failed.\n");
return 0;
}
-static void bbnsm_pwrkey_remove(struct platform_device *pdev)
-{
- dev_pm_clear_wake_irq(&pdev->dev);
- device_init_wakeup(&pdev->dev, false);
-}
-
static int __maybe_unused bbnsm_pwrkey_suspend(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
@@ -229,8 +226,6 @@ static struct platform_driver bbnsm_pwrkey_driver = {
.of_match_table = bbnsm_pwrkey_ids,
},
.probe = bbnsm_pwrkey_probe,
- .remove = bbnsm_pwrkey_remove,
-
};
module_platform_driver(bbnsm_pwrkey_driver);
--
2.37.1
next prev parent reply other threads:[~2025-02-05 0:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 0:45 [PATCH 0/4] input: use devm_pm_set_wake_irq Peng Fan (OSS)
2025-02-05 0:45 ` [PATCH 1/4] input: keyboard: ep93xx_keypad: Use devm_pm_set_wake_irq Peng Fan (OSS)
2025-02-05 0:45 ` [PATCH 2/4] input: keyboard: omap4_keypad: " Peng Fan (OSS)
2025-02-05 0:45 ` Peng Fan (OSS) [this message]
2025-02-05 0:45 ` [PATCH 4/4] input: touchscreen: ti_am335x_tsc: Use resource managed API to simplify code Peng Fan (OSS)
2025-03-04 1:51 ` [PATCH 0/4] input: use devm_pm_set_wake_irq Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205-input-cleanup-v1-3-9758898ff8cb@nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).