From: "Tomasz Pakuła" <tomasz.pakula.oficjalny@gmail.com>
To: jikos@kernel.org, bentiss@kernel.org
Cc: anssi.hannula@gmail.com, oleg@makarenk.ooo,
linux-input@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [PATCH v3 6/6] HID: pidff: Remove redundant call to pidff_find_special_keys
Date: Tue, 11 Feb 2025 15:02:52 +0100 [thread overview]
Message-ID: <20250211140252.702104-7-tomasz.pakula.oficjalny@gmail.com> (raw)
In-Reply-To: <20250211140252.702104-1-tomasz.pakula.oficjalny@gmail.com>
Probably left out as a mistake after Anssi created the helper macro
Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny@gmail.com>
---
drivers/hid/usbhid/hid-pidff.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
index d5734cbf745d..6f6c47bd57ea 100644
--- a/drivers/hid/usbhid/hid-pidff.c
+++ b/drivers/hid/usbhid/hid-pidff.c
@@ -1159,10 +1159,6 @@ static int pidff_find_special_fields(struct pidff_device *pidff)
return -1;
}
- pidff_find_special_keys(pidff->control_id, pidff->device_control,
- pidff_device_control,
- sizeof(pidff_device_control));
-
PIDFF_FIND_SPECIAL_KEYS(control_id, device_control, device_control);
if (!PIDFF_FIND_SPECIAL_KEYS(type_id, create_new_effect_type,
--
2.48.1
prev parent reply other threads:[~2025-02-11 14:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 14:02 [PATCH v3 0/6] HID: pidff: Compatibility update and new devices Tomasz Pakuła
2025-02-11 14:02 ` [PATCH v3 1/6] MAINTAINERS: Update hid-universal-pidff entry Tomasz Pakuła
2025-02-11 14:02 ` [PATCH v3 2/6] HID: pidff: Make sure to fetch pool before checking SIMULTANEOUS_MAX Tomasz Pakuła
2025-02-11 14:02 ` [PATCH v3 3/6] HID: hid-universal-pidff: Add Asetek wheelbases support Tomasz Pakuła
2025-02-11 14:02 ` [PATCH v3 4/6] HID: pidff: Comment and code style update Tomasz Pakuła
2025-02-11 14:02 ` [PATCH v3 5/6] HID: pidff: Support device error response from PID_BLOCK_LOAD Tomasz Pakuła
2025-02-11 14:02 ` Tomasz Pakuła [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211140252.702104-7-tomasz.pakula.oficjalny@gmail.com \
--to=tomasz.pakula.oficjalny@gmail.com \
--cc=anssi.hannula@gmail.com \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oleg@makarenk.ooo \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).