From: Even Xu <even.xu@intel.com>
To: david.laight.linux@gmail.com, jikos@kernel.org, bentiss@kernel.org
Cc: srinivas.pandruvada@linux.intel.com, mpearson-lenovo@squebb.ca,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Even Xu <even.xu@intel.com>, kernel test robot <lkp@intel.com>
Subject: [PATCH] Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x | !y" issue
Date: Thu, 13 Feb 2025 10:40:21 +0800 [thread overview]
Message-ID: <20250213024021.2477473-1-even.xu@intel.com> (raw)
Change to use "||" to make it more readable and avoid miss
understanding.
Signed-off-by: Even Xu <even.xu@intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501292144.eFDq4ovr-lkp@intel.com
---
drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
index eb23bea77686..8f97e71df7f4 100644
--- a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
+++ b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
@@ -295,7 +295,7 @@ static void release_dma_buffers(struct thc_device *dev,
return;
for (i = 0; i < config->prd_tbl_num; i++) {
- if (!config->sgls[i] | !config->sgls_nent[i])
+ if (!config->sgls[i] || !config->sgls_nent[i])
continue;
dma_unmap_sg(dev->dev, config->sgls[i],
--
2.40.1
next reply other threads:[~2025-02-13 2:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 2:40 Even Xu [this message]
2025-02-18 21:10 ` [PATCH] Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x | !y" issue Jiri Kosina
2025-02-19 0:49 ` Xu, Even
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213024021.2477473-1-even.xu@intel.com \
--to=even.xu@intel.com \
--cc=bentiss@kernel.org \
--cc=david.laight.linux@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mpearson-lenovo@squebb.ca \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).