* [PATCH] Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x | !y" issue
@ 2025-02-13 2:40 Even Xu
2025-02-18 21:10 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Even Xu @ 2025-02-13 2:40 UTC (permalink / raw)
To: david.laight.linux, jikos, bentiss
Cc: srinivas.pandruvada, mpearson-lenovo, linux-input, linux-kernel,
Even Xu, kernel test robot
Change to use "||" to make it more readable and avoid miss
understanding.
Signed-off-by: Even Xu <even.xu@intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501292144.eFDq4ovr-lkp@intel.com
---
drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
index eb23bea77686..8f97e71df7f4 100644
--- a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
+++ b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
@@ -295,7 +295,7 @@ static void release_dma_buffers(struct thc_device *dev,
return;
for (i = 0; i < config->prd_tbl_num; i++) {
- if (!config->sgls[i] | !config->sgls_nent[i])
+ if (!config->sgls[i] || !config->sgls_nent[i])
continue;
dma_unmap_sg(dev->dev, config->sgls[i],
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x | !y" issue
2025-02-13 2:40 [PATCH] Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x | !y" issue Even Xu
@ 2025-02-18 21:10 ` Jiri Kosina
2025-02-19 0:49 ` Xu, Even
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Kosina @ 2025-02-18 21:10 UTC (permalink / raw)
To: Even Xu
Cc: david.laight.linux, bentiss, srinivas.pandruvada, mpearson-lenovo,
linux-input, linux-kernel, kernel test robot
On Thu, 13 Feb 2025, Even Xu wrote:
> Change to use "||" to make it more readable and avoid miss
> understanding.
>
> Signed-off-by: Even Xu <even.xu@intel.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501292144.eFDq4ovr-lkp@intel.com
> ---
> drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> index eb23bea77686..8f97e71df7f4 100644
> --- a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> +++ b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> @@ -295,7 +295,7 @@ static void release_dma_buffers(struct thc_device *dev,
> return;
>
> for (i = 0; i < config->prd_tbl_num; i++) {
> - if (!config->sgls[i] | !config->sgls_nent[i])
> + if (!config->sgls[i] || !config->sgls_nent[i])
> continue;
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x | !y" issue
2025-02-18 21:10 ` Jiri Kosina
@ 2025-02-19 0:49 ` Xu, Even
0 siblings, 0 replies; 3+ messages in thread
From: Xu, Even @ 2025-02-19 0:49 UTC (permalink / raw)
To: Jiri Kosina
Cc: david.laight.linux@gmail.com, bentiss@kernel.org,
srinivas.pandruvada@linux.intel.com, mpearson-lenovo@squebb.ca,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, lkp
Thanks Jiri!
Best Regards,
Even Xu
> -----Original Message-----
> From: Jiri Kosina <jikos@kernel.org>
> Sent: Wednesday, February 19, 2025 5:10 AM
> To: Xu, Even <even.xu@intel.com>
> Cc: david.laight.linux@gmail.com; bentiss@kernel.org;
> srinivas.pandruvada@linux.intel.com; mpearson-lenovo@squebb.ca; linux-
> input@vger.kernel.org; linux-kernel@vger.kernel.org; lkp <lkp@intel.com>
> Subject: Re: [PATCH] Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x | !y" issue
>
> On Thu, 13 Feb 2025, Even Xu wrote:
>
> > Change to use "||" to make it more readable and avoid miss
> > understanding.
> >
> > Signed-off-by: Even Xu <even.xu@intel.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes:
> > https://lore.kernel.org/oe-kbuild-all/202501292144.eFDq4ovr-lkp@intel.
> > com
> > ---
> > drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> > b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> > index eb23bea77686..8f97e71df7f4 100644
> > --- a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> > +++ b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> > @@ -295,7 +295,7 @@ static void release_dma_buffers(struct thc_device
> *dev,
> > return;
> >
> > for (i = 0; i < config->prd_tbl_num; i++) {
> > - if (!config->sgls[i] | !config->sgls_nent[i])
> > + if (!config->sgls[i] || !config->sgls_nent[i])
> > continue;
>
> Applied, thanks.
>
> --
> Jiri Kosina
> SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-19 0:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-13 2:40 [PATCH] Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x | !y" issue Even Xu
2025-02-18 21:10 ` Jiri Kosina
2025-02-19 0:49 ` Xu, Even
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).