[PATCH 0/5] drm: panel-orientation-quirks: Add 2024 OneXPlayer line & ZOTAC Zone orientation quirks

[PATCH 0/5] drm: panel-orientation-quirks: Add 2024 OneXPlayer line & ZOTAC Zone orientation quirks

[Antheas Kapenekakis]

A number of OneXPlayer handhelds have come out with portrait panels.
Specifically, those are the X1 AMD and Intel variants, X1 Mini, and F1 Pro.
For X1 specifically, they also have spurious battery reporting within their
digitizer. The Zotac Gaming Zone also has a portrait OLED panel, so add
that as well.

Antheas Kapenekakis (5):
  drm: panel-orientation-quirks: Add OneXPlayer X1 AMD and Intel quirk
  drm: panel-orientation-quirks: Add OneXPlayer X1 Mini (AMD) quirk
  drm: panel-orientation-quirks: Add OneXPlayer F1Pro quirk
  HID: Add quirk to ignore the touchscreen battery on OneXPlayer X1
  drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk

 .../gpu/drm/drm_panel_orientation_quirks.c    | 42 +++++++++++++++++++
 drivers/hid/hid-ids.h                         |  1 +
 drivers/hid/hid-input.c                       |  2 +
 3 files changed, 45 insertions(+)

-- 
2.48.1

[PATCH 1/5] drm: panel-orientation-quirks: Add OneXPlayer X1 AMD and Intel quirk

[Antheas Kapenekakis]

The OneXPlayer X1 series features a 2k 10.95 display with a portrait
orientation. Add a quirk to set the panel orientation to portrait mode
to both the Intel and AMD variants.

Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 4a73821b81f6..17b4f57d64d7 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -443,6 +443,24 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONE XPLAYER"),
 		},
 		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OneXPlayer X1 AMD */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 A"),
+		},
+		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OneXPlayer X1 AMD Strix Point */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1Pro"),
+		},
+		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OneXPlayer X1 Intel */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 i"),
+		},
+		.driver_data = (void *)&lcd1600x2560_leftside_up,
 	}, {	/* OrangePi Neo */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
-- 
2.48.1

[PATCH 2/5] drm: panel-orientation-quirks: Add OneXPlayer X1 Mini (AMD) quirk

[Antheas Kapenekakis]

The OneXPlayer X1 mini features a 2k 8.8 display with a portrait
orientation. Add a quirk to set the panel orientation to portrait
mode. There is no Intel variant.

Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 17b4f57d64d7..1378690b7287 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -461,6 +461,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 i"),
 		},
 		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OneXPlayer X1 mini (AMD) */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 mini"),
+		},
+		.driver_data = (void *)&lcd1600x2560_leftside_up,
 	}, {	/* OrangePi Neo */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
-- 
2.48.1

[PATCH 3/5] drm: panel-orientation-quirks: Add OneXPlayer F1Pro quirk

[Antheas Kapenekakis]

The OneXPlayer F1Pro has a 144hz 1920x1080 portrait OLED panel.
Add a quirk to correct the panel portrait orientation. In addition,
it comes with a red limited edition variant in the Chinese market,
so add that as well.

Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 1378690b7287..f08cdc81dd9a 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -467,6 +467,18 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 mini"),
 		},
 		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OneXPlayer OneXFly F1 Pro (OLED) */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1Pro"),
+		},
+		.driver_data = (void *)&lcd1080x1920_leftside_up,
+	}, {	/* OneXPlayer OneXFly F1 Pro (OLED) LE Red variant */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1 EVA-02"),
+		},
+		.driver_data = (void *)&lcd1080x1920_leftside_up,
 	}, {	/* OrangePi Neo */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
-- 
2.48.1

[PATCH 4/5] HID: Add quirk to ignore the touchscreen battery on OneXPlayer X1

[Antheas Kapenekakis]

The X1 devices come with a pen-capable touchscreen, in which the HID
descriptor reports there is always a battery at 100% charge. Quirk it
to not report the battery status.

Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/hid/hid-ids.h   | 1 +
 drivers/hid/hid-input.c | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 7e400624908e..8e2fc152b089 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -1001,6 +1001,7 @@
 #define USB_VENDOR_ID_NOVATEK		0x0603
 #define USB_DEVICE_ID_NOVATEK_PCT	0x0600
 #define USB_DEVICE_ID_NOVATEK_MOUSE	0x1602
+#define I2C_DEVICE_ID_ONEXPLAYER_X1    0xF001
 
 #define USB_VENDOR_ID_NTI               0x0757
 #define USB_DEVICE_ID_USB_SUN           0x0a00
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 9d80635a91eb..08e87577feef 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -390,6 +390,8 @@ static const struct hid_device_id hid_battery_quirks[] = {
 	 * set HID_BATTERY_QUIRK_IGNORE for all Elan I2C-HID devices.
 	 */
 	{ HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, HID_ANY_ID), HID_BATTERY_QUIRK_IGNORE },
+	{ HID_I2C_DEVICE(USB_VENDOR_ID_NOVATEK, I2C_DEVICE_ID_ONEXPLAYER_X1),
+	  HID_BATTERY_QUIRK_IGNORE },
 	{}
 };
 
-- 
2.48.1

[PATCH 5/5] drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk

[Antheas Kapenekakis]

The Zotac Gaming Zone handheld features a 1080p portrait OLED screen.
Add the rotation to the panel orientation quirks.

Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index f08cdc81dd9a..bbbe707f541d 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -479,6 +479,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1 EVA-02"),
 		},
 		.driver_data = (void *)&lcd1080x1920_leftside_up,
+	}, {	/* Zotac Gaming Zone (OLED) */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ZOTAC"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ZOTAC GAMING ZONE"),
+		},
+		.driver_data = (void *)&lcd1080x1920_leftside_up,
 	}, {	/* OrangePi Neo */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
-- 
2.48.1

Re: [PATCH 4/5] HID: Add quirk to ignore the touchscreen battery on OneXPlayer X1

[Jiri Kosina]

On Sat, 22 Feb 2025, Antheas Kapenekakis wrote:

> The X1 devices come with a pen-capable touchscreen, in which the HID
> descriptor reports there is always a battery at 100% charge. Quirk it
> to not report the battery status.
> 
> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>

Let me provide

	Acked-by: Jiri Kosina <jkosina@suse.com>

so that this patch can be merged by the drm folks together with the rest 
of the enablement series.

Thanks,

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH 0/5] drm: panel-orientation-quirks: Add 2024 OneXPlayer line & ZOTAC Zone orientation quirks

[Antheas Kapenekakis]

On Sat, 22 Feb 2025 at 17:43, Antheas Kapenekakis <lkml@antheas.dev> wrote:
>
> A number of OneXPlayer handhelds have come out with portrait panels.
> Specifically, those are the X1 AMD and Intel variants, X1 Mini, and F1 Pro.
> For X1 specifically, they also have spurious battery reporting within their
> digitizer. The Zotac Gaming Zone also has a portrait OLED panel, so add
> that as well.
>
> Antheas Kapenekakis (5):
>   drm: panel-orientation-quirks: Add OneXPlayer X1 AMD and Intel quirk
>   drm: panel-orientation-quirks: Add OneXPlayer X1 Mini (AMD) quirk
>   drm: panel-orientation-quirks: Add OneXPlayer F1Pro quirk
>   HID: Add quirk to ignore the touchscreen battery on OneXPlayer X1
>   drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk
>
>  .../gpu/drm/drm_panel_orientation_quirks.c    | 42 +++++++++++++++++++
>  drivers/hid/hid-ids.h                         |  1 +
>  drivers/hid/hid-input.c                       |  2 +
>  3 files changed, 45 insertions(+)
>
> --
> 2.48.1
>

I'd like to push this along. We already have the ack for HID. Did I
miss anyone on the list? Full context [1]

+cc Hans

[1] https://lore.kernel.org/all/20250222164321.181340-1-lkml@antheas.dev/

Re: [PATCH 1/5] drm: panel-orientation-quirks: Add OneXPlayer X1 AMD and Intel quirk

[Hans de Goede]

Hi,

On 22-Feb-25 17:43, Antheas Kapenekakis wrote:
> The OneXPlayer X1 series features a 2k 10.95 display with a portrait
> orientation. Add a quirk to set the panel orientation to portrait mode
> to both the Intel and AMD variants.
> 
> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 4a73821b81f6..17b4f57d64d7 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -443,6 +443,24 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONE XPLAYER"),
>  		},
>  		.driver_data = (void *)&lcd1600x2560_leftside_up,
> +	}, {	/* OneXPlayer X1 AMD */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 A"),
> +		},
> +		.driver_data = (void *)&lcd1600x2560_leftside_up,
> +	}, {	/* OneXPlayer X1 AMD Strix Point */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1Pro"),
> +		},
> +		.driver_data = (void *)&lcd1600x2560_leftside_up,
> +	}, {	/* OneXPlayer X1 Intel */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 i"),
> +		},
> +		.driver_data = (void *)&lcd1600x2560_leftside_up,
>  	}, {	/* OrangePi Neo */
>  		.matches = {
>  		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),

Re: [PATCH 2/5] drm: panel-orientation-quirks: Add OneXPlayer X1 Mini (AMD) quirk

[Hans de Goede]

Hi,

On 22-Feb-25 17:43, Antheas Kapenekakis wrote:
> The OneXPlayer X1 mini features a 2k 8.8 display with a portrait
> orientation. Add a quirk to set the panel orientation to portrait
> mode. There is no Intel variant.
> 
> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 17b4f57d64d7..1378690b7287 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -461,6 +461,12 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 i"),
>  		},
>  		.driver_data = (void *)&lcd1600x2560_leftside_up,
> +	}, {	/* OneXPlayer X1 mini (AMD) */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 mini"),
> +		},
> +		.driver_data = (void *)&lcd1600x2560_leftside_up,
>  	}, {	/* OrangePi Neo */
>  		.matches = {
>  		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),

Re: [PATCH 3/5] drm: panel-orientation-quirks: Add OneXPlayer F1Pro quirk

[Hans de Goede]

Hi,

On 22-Feb-25 17:43, Antheas Kapenekakis wrote:
> The OneXPlayer F1Pro has a 144hz 1920x1080 portrait OLED panel.
> Add a quirk to correct the panel portrait orientation. In addition,
> it comes with a red limited edition variant in the Chinese market,
> so add that as well.
> 
> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

drm-misc maintainers, I'm dealing with a huge backlog of
patch-review, bugs and other work.

So I would appreciate it if one of you can merge patches 1-3
into drm-misc.

Regards,

Hans

> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 1378690b7287..f08cdc81dd9a 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -467,6 +467,18 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 mini"),
>  		},
>  		.driver_data = (void *)&lcd1600x2560_leftside_up,
> +	}, {	/* OneXPlayer OneXFly F1 Pro (OLED) */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1Pro"),
> +		},
> +		.driver_data = (void *)&lcd1080x1920_leftside_up,
> +	}, {	/* OneXPlayer OneXFly F1 Pro (OLED) LE Red variant */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1 EVA-02"),
> +		},
> +		.driver_data = (void *)&lcd1080x1920_leftside_up,
>  	}, {	/* OrangePi Neo */
>  		.matches = {
>  		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),

Re: [PATCH 5/5] drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk

[Hans de Goede]

Hi,

On 22-Feb-25 17:43, Antheas Kapenekakis wrote:
> The Zotac Gaming Zone handheld features a 1080p portrait OLED screen.
> Add the rotation to the panel orientation quirks.
> 
> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index f08cdc81dd9a..bbbe707f541d 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -479,6 +479,12 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1 EVA-02"),
>  		},
>  		.driver_data = (void *)&lcd1080x1920_leftside_up,
> +	}, {	/* Zotac Gaming Zone (OLED) */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ZOTAC"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ZOTAC GAMING ZONE"),
> +		},
> +		.driver_data = (void *)&lcd1080x1920_leftside_up,
>  	}, {	/* OrangePi Neo */

The entries in this list are alphabetically sorted. Please post
a v2 (of just this patch) with this entry moved to the end, just
above the special "One Mix 2S" entry which is at the very end
because its DMI matches are all "Default string".

Note another entry for another Zotac device, with a board name of
"G0A1W" has been added in drm-misc/next, so please base your v2
on top of drm-misc/next.

Also the freedesktop.org infra is currently being migrated to
another data center, so the drm-misc tree currently is not
available I think.

Regards,

Hans




>  		.matches = {
>  		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),

Re: [PATCH 3/5] drm: panel-orientation-quirks: Add OneXPlayer F1Pro quirk

[Antheas Kapenekakis]

On Mon, 17 Mar 2025 at 10:15, Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 22-Feb-25 17:43, Antheas Kapenekakis wrote:
> > The OneXPlayer F1Pro has a 144hz 1920x1080 portrait OLED panel.
> > Add a quirk to correct the panel portrait orientation. In addition,
> > it comes with a red limited edition variant in the Chinese market,
> > so add that as well.
> >
> > Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> drm-misc maintainers, I'm dealing with a huge backlog of
> patch-review, bugs and other work.
>
> So I would appreciate it if one of you can merge patches 1-3
> into drm-misc.
>
> Regards,
>
> Hans
>
> > ---
> >  drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > index 1378690b7287..f08cdc81dd9a 100644
> > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > @@ -467,6 +467,18 @@ static const struct dmi_system_id orientation_data[] = {
> >                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 mini"),
> >               },
> >               .driver_data = (void *)&lcd1600x2560_leftside_up,
> > +     }, {    /* OneXPlayer OneXFly F1 Pro (OLED) */
> > +             .matches = {
> > +               DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
> > +               DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1Pro"),
> > +             },
> > +             .driver_data = (void *)&lcd1080x1920_leftside_up,
> > +     }, {    /* OneXPlayer OneXFly F1 Pro (OLED) LE Red variant */
> > +             .matches = {
> > +               DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
> > +               DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1 EVA-02"),
> > +             },
> > +             .driver_data = (void *)&lcd1080x1920_leftside_up,
> >       }, {    /* OrangePi Neo */
> >               .matches = {
> >                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
>

Hi Hans,
patch 5 is also a panel quirk. Can you review that real quick as well
so it is not dangling?

Thanks,
Antheas

Re: [PATCH 5/5] drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk

[Antheas Kapenekakis]

On Mon, 17 Mar 2025 at 10:20, Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 22-Feb-25 17:43, Antheas Kapenekakis wrote:
> > The Zotac Gaming Zone handheld features a 1080p portrait OLED screen.
> > Add the rotation to the panel orientation quirks.
> >
> > Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
> > ---
> >  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > index f08cdc81dd9a..bbbe707f541d 100644
> > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > @@ -479,6 +479,12 @@ static const struct dmi_system_id orientation_data[] = {
> >                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1 EVA-02"),
> >               },
> >               .driver_data = (void *)&lcd1080x1920_leftside_up,
> > +     }, {    /* Zotac Gaming Zone (OLED) */
> > +             .matches = {
> > +               DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ZOTAC"),
> > +               DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ZOTAC GAMING ZONE"),
> > +             },
> > +             .driver_data = (void *)&lcd1080x1920_leftside_up,
> >       }, {    /* OrangePi Neo */
>
> The entries in this list are alphabetically sorted. Please post
> a v2 (of just this patch) with this entry moved to the end, just
> above the special "One Mix 2S" entry which is at the very end
> because its DMI matches are all "Default string".
>
> Note another entry for another Zotac device, with a board name of
> "G0A1W" has been added in drm-misc/next, so please base your v2
> on top of drm-misc/next.
>
> Also the freedesktop.org infra is currently being migrated to
> another data center, so the drm-misc tree currently is not
> available I think.
>
> Regards,
>
> Hans
>
>
>
>
> >               .matches = {
> >                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
>

Ok thanks. I will do that in a few days. Patches 1-4 hopefully should
be good to merge.

Antheas

Re: [PATCH 5/5] drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk

[Antheas Kapenekakis]

On Mon, 17 Mar 2025 at 10:23, Antheas Kapenekakis <lkml@antheas.dev> wrote:
>
> On Mon, 17 Mar 2025 at 10:20, Hans de Goede <hdegoede@redhat.com> wrote:
> >
> > Hi,
> >
> > On 22-Feb-25 17:43, Antheas Kapenekakis wrote:
> > > The Zotac Gaming Zone handheld features a 1080p portrait OLED screen.
> > > Add the rotation to the panel orientation quirks.
> > >
> > > Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
> > > ---
> > >  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > > index f08cdc81dd9a..bbbe707f541d 100644
> > > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > > @@ -479,6 +479,12 @@ static const struct dmi_system_id orientation_data[] = {
> > >                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1 EVA-02"),
> > >               },
> > >               .driver_data = (void *)&lcd1080x1920_leftside_up,
> > > +     }, {    /* Zotac Gaming Zone (OLED) */
> > > +             .matches = {
> > > +               DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ZOTAC"),
> > > +               DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ZOTAC GAMING ZONE"),
> > > +             },
> > > +             .driver_data = (void *)&lcd1080x1920_leftside_up,
> > >       }, {    /* OrangePi Neo */
> >
> > The entries in this list are alphabetically sorted. Please post
> > a v2 (of just this patch) with this entry moved to the end, just
> > above the special "One Mix 2S" entry which is at the very end
> > because its DMI matches are all "Default string".
> >
> > Note another entry for another Zotac device, with a board name of
> > "G0A1W" has been added in drm-misc/next, so please base your v2
> > on top of drm-misc/next.
> >
> > Also the freedesktop.org infra is currently being migrated to
> > another data center, so the drm-misc tree currently is not
> > available I think.
> >
> > Regards,
> >
> > Hans
> >
> >
> >
> >
> > >               .matches = {
> > >                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
> >
>
> Ok thanks. I will do that in a few days. Patches 1-4 hopefully should
> be good to merge.
>
> Antheas

Actually nevermind, this is the Zotac Zone so it is a dupe. It is fine
to drop this patch from the series and merge the rest.

Antheas