linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org,
	joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com,
	neil.armstrong@linaro.org, rfoss@kernel.org,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
	dmitry.torokhov@gmail.com, mchehab@kernel.org,
	awalls@md.metrocast.net, hverkuil@xs4all.nl,
	miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
	louis.peens@corigine.com, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	parthiban.veerasooran@microchip.com,
	arend.vanspriel@broadcom.com, johannes@sipsolutions.net,
	gregkh@linuxfoundation.org, jirislaby@kernel.org,
	yury.norov@gmail.com, akpm@linux-foundation.org
Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk,
	Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
	jernej.skrabec@gmail.com, kuba@kernel.org,
	linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org,
	dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org,
	linux-media@vger.kernel.org, linux-mtd@lists.infradead.org,
	oss-drivers@corigine.com, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
	brcm80211-dev-list.pdl@broadcom.com,
	linux-serial@vger.kernel.org, bpf@vger.kernel.org,
	jserv@ccns.ncku.edu.tw, david.laight.linux@gmail.com,
	andrew.cooper3@citrix.com, Kuan-Wei Chiu <visitorckw@gmail.com>,
	Yu-Chun Lin <eleanor15x@gmail.com>
Subject: [PATCH v2 04/18] media: media/test_drivers: Replace open-coded parity calculation with parity8()
Date: Sat,  1 Mar 2025 22:23:55 +0800	[thread overview]
Message-ID: <20250301142409.2513835-5-visitorckw@gmail.com> (raw)
In-Reply-To: <20250301142409.2513835-1-visitorckw@gmail.com>

Refactor parity calculations to use the standard parity8() helper. This
change eliminates redundant implementations and improves code
efficiency.

Co-developed-by: Yu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
---
 drivers/media/test-drivers/vivid/vivid-vbi-gen.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/media/test-drivers/vivid/vivid-vbi-gen.c b/drivers/media/test-drivers/vivid/vivid-vbi-gen.c
index 70a4024d461e..e0f4151bda18 100644
--- a/drivers/media/test-drivers/vivid/vivid-vbi-gen.c
+++ b/drivers/media/test-drivers/vivid/vivid-vbi-gen.c
@@ -5,6 +5,7 @@
  * Copyright 2014 Cisco Systems, Inc. and/or its affiliates. All rights reserved.
  */
 
+#include <linux/bitops.h>
 #include <linux/errno.h>
 #include <linux/kernel.h>
 #include <linux/ktime.h>
@@ -165,12 +166,7 @@ static const u8 vivid_cc_sequence2[30] = {
 
 static u8 calc_parity(u8 val)
 {
-	unsigned i;
-	unsigned tot = 0;
-
-	for (i = 0; i < 7; i++)
-		tot += (val & (1 << i)) ? 1 : 0;
-	return val | ((tot & 1) ? 0 : 0x80);
+	return val | (parity8(val) ? 0 : 0x80);
 }
 
 static void vivid_vbi_gen_set_time_of_day(u8 *packet)
-- 
2.34.1


  parent reply	other threads:[~2025-03-01 14:25 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-01 14:23 [PATCH v2 00/18] Introduce and use generic parity16/32/64 helper Kuan-Wei Chiu
2025-03-01 14:23 ` [PATCH v2 01/18] lib/parity: Add __builtin_parity() fallback implementations Kuan-Wei Chiu
2025-03-02  3:10   ` Yury Norov
2025-03-02  8:20     ` Kuan-Wei Chiu
2025-03-02 16:02       ` Yury Norov
2025-03-02 17:29         ` Kuan-Wei Chiu
2025-03-02 19:09           ` David Laight
2025-03-03  2:47             ` Kuan-Wei Chiu
2025-03-03 12:41               ` David Laight
2025-03-03 15:43               ` Yury Norov
2025-03-03 16:54                 ` Kuan-Wei Chiu
2025-03-03 15:25             ` Yury Norov
2025-03-03 15:15           ` Yury Norov
2025-03-03 19:37             ` David Laight
2025-03-01 14:23 ` [PATCH v2 02/18] bitops: Optimize parity8() using __builtin_parity() Kuan-Wei Chiu
2025-03-01 14:23 ` [PATCH v2 03/18] bitops: Add parity16(), parity32(), and parity64() helpers Kuan-Wei Chiu
2025-03-05 16:20   ` Simon Horman
2025-03-01 14:23 ` Kuan-Wei Chiu [this message]
2025-03-01 14:23 ` [PATCH v2 05/18] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity8() Kuan-Wei Chiu
2025-03-01 14:23 ` [PATCH v2 06/18] media: saa7115: " Kuan-Wei Chiu
2025-03-01 14:23 ` [PATCH v2 07/18] serial: max3100: " Kuan-Wei Chiu
2025-03-01 14:23 ` [PATCH v2 08/18] lib/bch: Replace open-coded parity calculation with parity32() Kuan-Wei Chiu
2025-03-01 14:24 ` [PATCH v2 09/18] Input: joystick - " Kuan-Wei Chiu
2025-03-01 14:24 ` [PATCH v2 10/18] net: ethernet: oa_tc6: " Kuan-Wei Chiu
2025-03-01 14:24 ` [PATCH v2 11/18] wifi: brcm80211: " Kuan-Wei Chiu
2025-03-01 14:24 ` [PATCH v2 12/18] drm/bridge: dw-hdmi: " Kuan-Wei Chiu
2025-03-01 14:24 ` [PATCH v2 13/18] mtd: ssfdc: " Kuan-Wei Chiu
2025-03-01 14:24 ` [PATCH v2 14/18] fsi: i2cr: " Kuan-Wei Chiu
2025-03-01 14:24 ` [PATCH v2 15/18] fsi: i2cr: Replace open-coded parity calculation with parity64() Kuan-Wei Chiu
2025-03-01 14:24 ` [PATCH v2 16/18] Input: joystick - " Kuan-Wei Chiu
2025-03-01 14:24 ` [PATCH v2 17/18] nfp: bpf: " Kuan-Wei Chiu
2025-03-01 14:24 ` [PATCH v2 18/18] bitops: Add parity() macro for automatic type-based selection Kuan-Wei Chiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250301142409.2513835-5-visitorckw@gmail.com \
    --to=visitorckw@gmail.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alistair@popple.id.au \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew.cooper3@citrix.com \
    --cc=andrzej.hajda@intel.com \
    --cc=arend.vanspriel@broadcom.com \
    --cc=awalls@md.metrocast.net \
    --cc=bp@alien8.de \
    --cc=bpf@vger.kernel.org \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=dave.hansen@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=david.laight.linux@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eajames@linux.ibm.com \
    --cc=edumazet@google.com \
    --cc=eleanor15x@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=hverkuil@xs4all.nl \
    --cc=jernej.skrabec@gmail.com \
    --cc=jirislaby@kernel.org \
    --cc=jk@ozlabs.org \
    --cc=joel@jms.id.au \
    --cc=johannes@sipsolutions.net \
    --cc=jonas@kwiboo.se \
    --cc=jserv@ccns.ncku.edu.tw \
    --cc=kuba@kernel.org \
    --cc=linux-fsi@lists.ozlabs.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=louis.peens@corigine.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mchehab@kernel.org \
    --cc=mingo@redhat.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@corigine.com \
    --cc=pabeni@redhat.com \
    --cc=parthiban.veerasooran@microchip.com \
    --cc=rfoss@kernel.org \
    --cc=richard@nod.at \
    --cc=simona@ffwll.ch \
    --cc=tglx@linutronix.de \
    --cc=tzimmermann@suse.de \
    --cc=vigneshr@ti.com \
    --cc=x86@kernel.org \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).