linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luke Jones <luke@ljones.dev>
To: linux-kernel@vger.kernel.org
Cc: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com,
	platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org,
	bentiss@kernel.org, jikos@kernel.org, mario.limonciello@amd.com,
	lkml@antheas.dev, Luke Jones <luke@ljones.dev>
Subject: [PATCH v3 0/2] hid-asus: asus-wmi: refactor Ally suspend/resume
Date: Fri, 21 Mar 2025 16:51:04 +1300	[thread overview]
Message-ID: <20250321035106.26752-1-luke@ljones.dev> (raw)

This short series refactors the Ally suspend/resume functionality in the
asus-wmi driver along with adding support for ROG Ally MCU version checking.

The version checking is then used to toggle the use of older CSEE call hacks
that were initially used to combat Ally suspend/wake issues arising from the MCU
not clearing a particular flag on resume. ASUS have since corrected this
especially for Linux in newer firmware versions.

- hid-asus requests the MCU version and displays a warning if the version is
  older than the one that fixes the issue.
- hid-asus awill also toggle the CSEE hack off, and mcu_powersave to on if the
version is high enough.

- Changelog:
  + V2:
    - Adjust warning message to explicitly mention suspend issues
    - Use switch/case block to set min_version
      - Set min_version to 0 by default and toggle hacks off
  + V3:
    - Fix errors picked up by test bot: incorrect return in the else block
      of `#if IS_REACHABLE(CONFIG_ASUS_WMI)`:
      - set_ally_mcu_hack()
      - set_ally_mcu_powersave()

Luke D. Jones (2):
  hid-asus: check ROG Ally MCU version and warn
  platform/x86: asus-wmi: Refactor Ally suspend/resume

 drivers/hid/hid-asus.c                     | 111 +++++++++++++++++-
 drivers/platform/x86/asus-wmi.c            | 130 ++++++++++++++-------
 include/linux/platform_data/x86/asus-wmi.h |  13 +++
 3 files changed, 213 insertions(+), 41 deletions(-)

-- 
2.49.0


             reply	other threads:[~2025-03-21  3:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-21  3:51 Luke Jones [this message]
2025-03-21  3:51 ` [PATCH v3 1/2] hid-asus: check ROG Ally MCU version and warn Luke Jones
2025-03-21 17:10   ` Mario Limonciello
2025-03-21  3:51 ` [PATCH v3 2/2] platform/x86: asus-wmi: Refactor Ally suspend/resume Luke Jones
2025-03-21 17:12   ` Mario Limonciello
2025-03-21 18:55   ` Antheas Kapenekakis
2025-03-22  0:33     ` Luke D. Jones
2025-03-22  5:07       ` Antheas Kapenekakis
2025-03-22  8:14         ` Luke D. Jones
2025-03-22  8:24           ` Antheas Kapenekakis
2025-03-22  8:49             ` Luke D. Jones
2025-03-22  8:53               ` Antheas Kapenekakis
2025-03-22  9:18                 ` Luke D. Jones
2025-03-21  3:53 ` [PATCH v3 0/2] hid-asus: asus-wmi: refactor " Luke D. Jones
2025-03-21 17:39 ` Antheas Kapenekakis
  -- strict thread matches above, loose matches on Subject: below --
2025-02-27  8:58 Luke Jones
2025-02-27 14:35 ` Mario Limonciello
2025-03-04 20:56 ` Jiri Kosina
2025-03-06 12:58   ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250321035106.26752-1-luke@ljones.dev \
    --to=luke@ljones.dev \
    --cc=bentiss@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@antheas.dev \
    --cc=mario.limonciello@amd.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).