From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99706223719; Mon, 31 Mar 2025 14:57:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743433051; cv=none; b=nrd9VkjkjHOypFA9y9XVqLCgnmbbY/hymZbjidqvBHMFKvROQTgceX3jTmNBfn2tHSjFoiRtsn31eabQzsbzvz09qb0ywYyHl6vOhex8Ubp0wDTOU+qp3nUcfpahqJjYA5l4K8yo7FMETnm0soUPIj2dSrihEgbLWQAQpWO+/oQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743433051; c=relaxed/simple; bh=YcTBlIafHtHS/QfWcMiXPeP5ZtMpUJfjub+Ey0l9aVE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=BOi55PHKqmVCfbAX6cS5gZL+gR2MYrVZOYBE4ymAhB97dayEt2S56AaAvNbDMX6rjkK/W587xYqwTZmFcv5CysfDVK/4Olfgh6czW+eKxJ4gAhhi0G3RW0N45kcBxwyl7fj5oZSf5O5dddNdR41lfLR8HbQfwLfunRzIzvDY+QE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CBhvXe3p; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CBhvXe3p" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB21EC4CEE3; Mon, 31 Mar 2025 14:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743433051; bh=YcTBlIafHtHS/QfWcMiXPeP5ZtMpUJfjub+Ey0l9aVE=; h=From:To:Cc:Subject:Date:From; b=CBhvXe3pO2mlK+1x3D+TyOO7dI1+uMVpAX4xzDEZMVa8yOMjxWmjNVE3NczsRpqjD Is+iG6g/BzvbEPExmiSnkfPo6BUVkv+9Z0E4ruruO5Mji2Rl8OVcpOxqSjh+dXRLTQ rA7xeFVAsQ2UkX1+Gxfc53oZZOKqt0qtoOREAyZqFFJgwGgvlm19VOSjKCxOqwyaam pzuKE5kmTxbIuh3phzztMEMscrhQPvBncpxRohLaakmCU23vbFuOioiAjBquT1nLcZ +ibNzl3wkGn8F3BL0S/SNRJ0J/QIWtXqP+CxrJ74KxJxZt9Vm67zLWAbCud9uWps5Q spDGzVrK5KgXQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Tomasz=20Paku=C5=82a?= , Makarenko Oleg , =?UTF-8?q?Micha=C5=82=20Kope=C4=87?= , Paul Dino Jones , =?UTF-8?q?Crist=C3=B3ferson=20Bueno?= , Pablo Cisneros , Jiri Kosina , Sasha Levin , jikos@kernel.org, bentiss@kernel.org, linux-usb@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 1/5] HID: pidff: Convert infinite length from Linux API to PID standard Date: Mon, 31 Mar 2025 10:57:24 -0400 Message-Id: <20250331145728.1706329-1-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.291 Content-Transfer-Encoding: 8bit From: Tomasz Pakuła [ Upstream commit 37e0591fe44dce39d1ebc7a82d5b6e4dba1582eb ] Software uses 0 as de-facto infinite lenght on Linux FF apis (SDL), Linux doesn't actually define anythi as of now, while USB PID defines NULL (0xffff). Most PID devices do not expect a 0-length effect and can't interpret it as infinite. This change fixes Force Feedback for most PID compliant devices. As most games depend on updating the values of already playing infinite effects, this is crucial to ensure they will actually work. Previously, users had to rely on third-party software to do this conversion and make their PID devices usable. Co-developed-by: Makarenko Oleg Signed-off-by: Makarenko Oleg Signed-off-by: Tomasz Pakuła Reviewed-by: Michał Kopeć Reviewed-by: Paul Dino Jones Tested-by: Paul Dino Jones Tested-by: Cristóferson Bueno Tested-by: Pablo Cisneros Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/usbhid/hid-pidff.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 07a9fe97d2e05..badcb5f28607e 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -21,6 +21,7 @@ #include "usbhid.h" #define PID_EFFECTS_MAX 64 +#define PID_INFINITE 0xffff /* Report usage table used to put reports into an array */ @@ -301,7 +302,12 @@ static void pidff_set_effect_report(struct pidff_device *pidff, pidff->block_load[PID_EFFECT_BLOCK_INDEX].value[0]; pidff->set_effect_type->value[0] = pidff->create_new_effect_type->value[0]; - pidff->set_effect[PID_DURATION].value[0] = effect->replay.length; + + /* Convert infinite length from Linux API (0) + to PID standard (NULL) if needed */ + pidff->set_effect[PID_DURATION].value[0] = + effect->replay.length == 0 ? PID_INFINITE : effect->replay.length; + pidff->set_effect[PID_TRIGGER_BUTTON].value[0] = effect->trigger.button; pidff->set_effect[PID_TRIGGER_REPEAT_INT].value[0] = effect->trigger.interval; -- 2.39.5