From: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
To: "Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Kamel Bouhara" <kamel.bouhara@bootlin.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Michael Walle" <mwalle@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-input@vger.kernel.org,
linux-pwm@vger.kernel.org, andriy.shevchenko@intel.com,
"Grégory Clement" <gregory.clement@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
Subject: [PATCH v6 07/12] gpio: regmap: Allow to allocate regmap-irq device
Date: Wed, 09 Apr 2025 16:55:54 +0200 [thread overview]
Message-ID: <20250409-mdb-max7360-support-v6-7-7a2535876e39@bootlin.com> (raw)
In-Reply-To: <20250409-mdb-max7360-support-v6-0-7a2535876e39@bootlin.com>
GPIO controller often have support for IRQ: allow to easily allocate
both gpio-regmap and regmap-irq in one operation.
Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
---
drivers/base/regmap/regmap-irq.c | 5 +++--
drivers/gpio/gpio-regmap.c | 21 +++++++++++++++++++--
include/linux/gpio/regmap.h | 14 ++++++++++++++
3 files changed, 36 insertions(+), 4 deletions(-)
diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c
index b4a72750ff6d..882c6516301b 100644
--- a/drivers/base/regmap/regmap-irq.c
+++ b/drivers/base/regmap/regmap-irq.c
@@ -6,12 +6,12 @@
//
// Author: Mark Brown <broonie@opensource.wolfsonmicro.com>
-#include <linux/array_size.h>
#include <linux/device.h>
#include <linux/export.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
#include <linux/irqdomain.h>
+#include <linux/overflow.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
#include <linux/slab.h>
@@ -910,7 +910,8 @@ int regmap_add_irq_chip_fwnode(struct fwnode_handle *fwnode,
if (ret < 0)
goto err_alloc;
- memcpy(d->prev_status_buf, d->status_buf, array_size(d->prev_status_buf));
+ memcpy(d->prev_status_buf, d->status_buf,
+ array_size(d->chip->num_regs, sizeof(d->prev_status_buf[0])));
}
ret = regmap_irq_create_domain(fwnode, irq_base, chip, d);
diff --git a/drivers/gpio/gpio-regmap.c b/drivers/gpio/gpio-regmap.c
index 87c4225784cf..c27cc78f9025 100644
--- a/drivers/gpio/gpio-regmap.c
+++ b/drivers/gpio/gpio-regmap.c
@@ -215,6 +215,7 @@ EXPORT_SYMBOL_GPL(gpio_regmap_get_drvdata);
*/
struct gpio_regmap *gpio_regmap_register(const struct gpio_regmap_config *config)
{
+ struct irq_domain *irq_domain;
struct gpio_regmap *gpio;
struct gpio_chip *chip;
int ret;
@@ -295,8 +296,24 @@ struct gpio_regmap *gpio_regmap_register(const struct gpio_regmap_config *config
if (ret < 0)
goto err_free_gpio;
- if (config->irq_domain) {
- ret = gpiochip_irqchip_add_domain(chip, config->irq_domain);
+#ifdef CONFIG_REGMAP_IRQ
+ if (config->regmap_irq_chip) {
+ struct regmap_irq_chip_data *irq_chip_data;
+
+ ret = devm_regmap_add_irq_chip_fwnode(config->parent, dev_fwnode(config->parent),
+ config->regmap, config->regmap_irq_irqno,
+ config->regmap_irq_flags, 0,
+ config->regmap_irq_chip, &irq_chip_data);
+ if (ret)
+ goto err_free_gpio;
+
+ irq_domain = regmap_irq_get_domain(irq_chip_data);
+ } else
+#endif
+ irq_domain = config->irq_domain;
+
+ if (irq_domain) {
+ ret = gpiochip_irqchip_add_domain(chip, irq_domain);
if (ret)
goto err_remove_gpiochip;
}
diff --git a/include/linux/gpio/regmap.h b/include/linux/gpio/regmap.h
index c722c67668c6..7ed7927ae2e9 100644
--- a/include/linux/gpio/regmap.h
+++ b/include/linux/gpio/regmap.h
@@ -40,6 +40,14 @@ struct regmap;
* @drvdata: (Optional) Pointer to driver specific data which is
* not used by gpio-remap but is provided "as is" to the
* driver callback(s).
+ * @regmap_irq_chip: (Optional) Pointer on an regmap_irq_chip structure. If
+ * set, a regmap-irq device will be created and the IRQ
+ * domain will be set accordingly.
+ * @regmap_irq_chip_data: (Optional) Pointer on an regmap_irq_chip_data
+ * structure pointer. If set, it will be populated with a
+ * pointer on allocated regmap_irq data.
+ * @regmap_irq_irqno (Optional) The IRQ the device uses to signal interrupts.
+ * @regmap_irq_flags (Optional) The IRQF_ flags to use for the interrupt.
*
* The ->reg_mask_xlate translates a given base address and GPIO offset to
* register and mask pair. The base address is one of the given register
@@ -78,6 +86,12 @@ struct gpio_regmap_config {
int ngpio_per_reg;
struct irq_domain *irq_domain;
+#ifdef CONFIG_REGMAP_IRQ
+ struct regmap_irq_chip *regmap_irq_chip;
+ int regmap_irq_irqno;
+ unsigned long regmap_irq_flags;
+#endif
+
int (*reg_mask_xlate)(struct gpio_regmap *gpio, unsigned int base,
unsigned int offset, unsigned int *reg,
unsigned int *mask);
--
2.39.5
next prev parent reply other threads:[~2025-04-09 14:56 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 14:55 [PATCH v6 00/12] Add support for MAX7360 Mathieu Dubois-Briand
2025-04-09 14:55 ` [PATCH v6 01/12] dt-bindings: mfd: gpio: Add MAX7360 Mathieu Dubois-Briand
2025-04-09 15:22 ` [External] : " ALOK TIWARI
2025-04-10 7:55 ` Lee Jones
2025-04-10 8:19 ` Mathieu Dubois-Briand
2025-04-09 20:58 ` Dmitry Torokhov
2025-04-10 8:22 ` Mathieu Dubois-Briand
2025-04-11 16:05 ` Rob Herring (Arm)
2025-04-15 11:24 ` Mathieu Dubois-Briand
2025-04-09 14:55 ` [PATCH v6 02/12] mfd: Add max7360 support mathieu.dubois-briand
2025-04-17 18:16 ` Andy Shevchenko
2025-04-18 15:39 ` Mathieu Dubois-Briand
2025-04-18 15:52 ` Christophe JAILLET
2025-04-18 16:20 ` Mathieu Dubois-Briand
2025-04-09 14:55 ` [PATCH v6 03/12] pinctrl: Add MAX7360 pinctrl driver Mathieu Dubois-Briand
2025-04-09 15:03 ` Mathieu Dubois-Briand
2025-04-09 16:32 ` Andy Shevchenko
2025-04-10 8:37 ` Mathieu Dubois-Briand
2025-04-09 14:55 ` [PATCH v6 04/12] pwm: max7360: Add MAX7360 PWM support mathieu.dubois-briand
2025-04-09 17:00 ` Andy Shevchenko
2025-04-10 8:48 ` Mathieu Dubois-Briand
2025-04-09 14:55 ` [PATCH v6 05/12] regmap: irq: Remove unreachable goto Mathieu Dubois-Briand
2025-04-09 15:19 ` Mark Brown
2025-04-09 15:21 ` Mark Brown
2025-04-10 8:53 ` Mathieu Dubois-Briand
2025-04-09 15:38 ` Andy Shevchenko
2025-04-09 15:46 ` Mark Brown
2025-04-09 16:00 ` Andy Shevchenko
2025-04-09 16:32 ` Mark Brown
2025-04-09 16:45 ` Andy Shevchenko
2025-04-09 17:16 ` Dmitry Torokhov
2025-04-10 18:43 ` Andy Shevchenko
2025-04-09 15:56 ` Andy Shevchenko
2025-04-19 10:38 ` Uwe Kleine-König
2025-04-23 12:41 ` Mathieu Dubois-Briand
2025-04-23 12:42 ` Mark Brown
2025-04-09 15:40 ` Andy Shevchenko
2025-04-09 14:55 ` [PATCH v6 06/12] regmap: irq: Add support for chips without separate IRQ status Mathieu Dubois-Briand
2025-04-09 14:55 ` Mathieu Dubois-Briand [this message]
2025-04-09 16:39 ` [PATCH v6 07/12] gpio: regmap: Allow to allocate regmap-irq device Andy Shevchenko
2025-04-10 9:03 ` Mathieu Dubois-Briand
2025-04-14 10:29 ` Andy Shevchenko
2025-04-09 14:55 ` [PATCH v6 08/12] gpio: regmap: Allow to provide init_valid_mask callback Mathieu Dubois-Briand
2025-04-09 17:02 ` Andy Shevchenko
2025-04-10 10:03 ` Mathieu Dubois-Briand
2025-04-15 22:15 ` Linus Walleij
2025-04-09 14:55 ` [PATCH v6 09/12] gpio: max7360: Add MAX7360 gpio support Mathieu Dubois-Briand
2025-04-17 12:41 ` Bartosz Golaszewski
2025-04-17 18:13 ` Andy Shevchenko
2025-04-18 15:26 ` Mathieu Dubois-Briand
2025-04-09 14:55 ` [PATCH v6 10/12] input: keyboard: Add support for MAX7360 keypad Mathieu Dubois-Briand
2025-04-09 18:40 ` Dmitry Torokhov
2025-04-10 11:29 ` Mathieu Dubois-Briand
2025-04-09 14:55 ` [PATCH v6 11/12] input: misc: Add support for MAX7360 rotary Mathieu Dubois-Briand
2025-04-09 19:17 ` Dmitry Torokhov
2025-04-10 11:36 ` Mathieu Dubois-Briand
2025-04-09 14:55 ` [PATCH v6 12/12] MAINTAINERS: Add entry on MAX7360 driver Mathieu Dubois-Briand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409-mdb-max7360-support-v6-7-7a2535876e39@bootlin.com \
--to=mathieu.dubois-briand@bootlin.com \
--cc=andriy.shevchenko@intel.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=kamel.bouhara@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mwalle@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).