* [PATCH] iio: orientation: hid-sensor-rotation: remove unnecessary alignment
@ 2025-04-18 20:08 David Lechner
2025-04-19 16:18 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: David Lechner @ 2025-04-18 20:08 UTC (permalink / raw)
To: Jiri Kosina, Jonathan Cameron, Srinivas Pandruvada, Nuno Sá,
Andy Shevchenko
Cc: linux-input, linux-iio, linux-kernel, David Lechner
Remove __aligned(16) in the scan data struct in the hid-sensor-rotation
driver. There is nothing in the code that requires this alignment.
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
drivers/iio/orientation/hid-sensor-rotation.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/orientation/hid-sensor-rotation.c b/drivers/iio/orientation/hid-sensor-rotation.c
index c4b18fd0fa76c17318b262ea9f44ea5c40170298..e759f91a710a2cdec8b708faab49c557e3418146 100644
--- a/drivers/iio/orientation/hid-sensor-rotation.c
+++ b/drivers/iio/orientation/hid-sensor-rotation.c
@@ -19,7 +19,7 @@ struct dev_rot_state {
struct hid_sensor_common common_attributes;
struct hid_sensor_hub_attribute_info quaternion;
struct {
- s32 sampled_vals[4] __aligned(16);
+ s32 sampled_vals[4];
aligned_s64 timestamp;
} scan;
int scale_pre_decml;
---
base-commit: aff301f37e220970c2f301b5c65a8bfedf52058e
change-id: 20250418-iio-orientation-hid-sensor-rotation-remove-alignment-8d8f8f814d72
Best regards,
--
David Lechner <dlechner@baylibre.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: orientation: hid-sensor-rotation: remove unnecessary alignment
2025-04-18 20:08 [PATCH] iio: orientation: hid-sensor-rotation: remove unnecessary alignment David Lechner
@ 2025-04-19 16:18 ` Andy Shevchenko
2025-04-21 11:19 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2025-04-19 16:18 UTC (permalink / raw)
To: David Lechner
Cc: Jiri Kosina, Jonathan Cameron, Srinivas Pandruvada, Nuno Sá,
linux-input, linux-iio, linux-kernel
On Fri, Apr 18, 2025 at 03:08:53PM -0500, David Lechner wrote:
> Remove __aligned(16) in the scan data struct in the hid-sensor-rotation
> driver. There is nothing in the code that requires this alignment.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: orientation: hid-sensor-rotation: remove unnecessary alignment
2025-04-19 16:18 ` Andy Shevchenko
@ 2025-04-21 11:19 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2025-04-21 11:19 UTC (permalink / raw)
To: Andy Shevchenko
Cc: David Lechner, Jiri Kosina, Srinivas Pandruvada, Nuno Sá,
linux-input, linux-iio, linux-kernel
On Sat, 19 Apr 2025 19:18:39 +0300
Andy Shevchenko <andy@kernel.org> wrote:
> On Fri, Apr 18, 2025 at 03:08:53PM -0500, David Lechner wrote:
> > Remove __aligned(16) in the scan data struct in the hid-sensor-rotation
> > driver. There is nothing in the code that requires this alignment.
>
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
>
Odd case. I wonder what motivated that... Anyhow, I've applied
this to the togreg branch of iio.git and pushed that out as testing.
If there is something odd going on that the 3 of us have missed
hopefully someone will point it out!
Jonathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-21 11:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-18 20:08 [PATCH] iio: orientation: hid-sensor-rotation: remove unnecessary alignment David Lechner
2025-04-19 16:18 ` Andy Shevchenko
2025-04-21 11:19 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).