Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: goodix: Add no-reset-pull-up property

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

On Tue, Apr 29, 2025 at 11:56:11AM +0200, Esben Haabendal wrote:
> This should be added for boards where there is no pull-up on the reset pin,
> as the driver will otherwise switch the reset signal to high-impedance to
> save power, which obviously not safe without pull-up.
> 
> Signed-off-by: Esben Haabendal <esben@geanix.com>
> ---
>  Documentation/devicetree/bindings/input/touchscreen/goodix.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
> index eb4992f708b70fef93bd4b59b9565123f7c6ad5d..21ac13046b6e021eeb403d854aabc945801dd29f 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
> @@ -45,6 +45,10 @@ properties:
>    reset-gpios:
>      maxItems: 1
>  
> +  goodix,no-reset-pull-up:
> +    type: boolean
> +    description: There is no pull-up on reset pin

I have to wonder, why are these system using the reset property if the
reset is not usable? Shouldn't the property be omitted?

> +
>    AVDD28-supply:
>      description: Analog power supply regulator on AVDD28 pin
>  
> 
> -- 
> 2.49.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]