* [PATCH] HID: Lower message 'No inputs registered, leaving' to debug
@ 2025-05-23 16:10 Mario Limonciello
2025-06-10 19:48 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Mario Limonciello @ 2025-05-23 16:10 UTC (permalink / raw)
To: mario.limonciello, jikos, bentiss; +Cc: linux-input
From: Mario Limonciello <mario.limonciello@amd.com>
Plugging in a "Blue snowball" microphone always shows the
error 'No inputs registered, leaving', but the device functions as
intended.
When a HID device is started using the function hid_hw_start() and
the argument HID_CONNECT_DEFAULT it will try all various hid connect
requests. Not all devices will create an input device and so the
message is needlessly noisy. Decrease it to debug instead.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/hid/hid-input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 9d80635a91ebd..ff1784b5c2a47 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -2343,7 +2343,7 @@ int hidinput_connect(struct hid_device *hid, unsigned int force)
}
if (list_empty(&hid->inputs)) {
- hid_err(hid, "No inputs registered, leaving\n");
+ hid_dbg(hid, "No inputs registered, leaving\n");
goto out_unwind;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] HID: Lower message 'No inputs registered, leaving' to debug
2025-05-23 16:10 [PATCH] HID: Lower message 'No inputs registered, leaving' to debug Mario Limonciello
@ 2025-06-10 19:48 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2025-06-10 19:48 UTC (permalink / raw)
To: Mario Limonciello; +Cc: mario.limonciello, bentiss, linux-input
On Fri, 23 May 2025, Mario Limonciello wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> Plugging in a "Blue snowball" microphone always shows the
> error 'No inputs registered, leaving', but the device functions as
> intended.
>
> When a HID device is started using the function hid_hw_start() and
> the argument HID_CONNECT_DEFAULT it will try all various hid connect
> requests. Not all devices will create an input device and so the
> message is needlessly noisy. Decrease it to debug instead.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Indeed, that's way too verbose.
Applied to hid.git#for-6.16/upstream-fixes, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-10 19:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-23 16:10 [PATCH] HID: Lower message 'No inputs registered, leaving' to debug Mario Limonciello
2025-06-10 19:48 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).