[PATCH] xpad - Added Acer NGR 200 Controller

[PATCH] xpad - Added Acer NGR 200 Controller

[Nilton Perim Neto]

This patch adds the NGR 200 Xbox 360 to the xpad device tree and also Acer's VendorID

Signed-off-by: Nilton Perim Neto <niltonperimneto@gmail.com>
---
 drivers/input/joystick/xpad.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 7746530da030..100aaaa7a5cb 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -177,6 +177,7 @@ static const struct xpad_device {
 	{ 0x05fd, 0x107a, "InterAct 'PowerPad Pro' X-Box pad (Germany)", 0, XTYPE_XBOX },
 	{ 0x05fe, 0x3030, "Chic Controller", 0, XTYPE_XBOX },
 	{ 0x05fe, 0x3031, "Chic Controller", 0, XTYPE_XBOX },
+	{ 0x0502, 0x1305, "Acer NGR200", 0, XTYPE_XBOX },
 	{ 0x062a, 0x0020, "Logic3 Xbox GamePad", 0, XTYPE_XBOX },
 	{ 0x062a, 0x0033, "Competition Pro Steering Wheel", 0, XTYPE_XBOX },
 	{ 0x06a3, 0x0200, "Saitek Racing Wheel", 0, XTYPE_XBOX },
@@ -521,6 +522,7 @@ static const struct usb_device_id xpad_table[] = {
 	XPAD_XBOX360_VENDOR(0x045e),		/* Microsoft Xbox 360 controllers */
 	XPAD_XBOXONE_VENDOR(0x045e),		/* Microsoft Xbox One controllers */
 	XPAD_XBOX360_VENDOR(0x046d),		/* Logitech Xbox 360-style controllers */
+	XPAD_XBOX360_VENDOR(0x0502),		/* Acer Inc. Xbox 360 style controllers */
 	XPAD_XBOX360_VENDOR(0x056e),		/* Elecom JC-U3613M */
 	XPAD_XBOX360_VENDOR(0x06a3),		/* Saitek P3600 */
 	XPAD_XBOX360_VENDOR(0x0738),		/* Mad Catz Xbox 360 controllers */
-- 
2.49.0

Re: [PATCH] xpad - Added Acer NGR 200 Controller

[Dmitry Torokhov]

On Sun, Jun 08, 2025 at 03:04:45AM -0300, Nilton Perim Neto wrote:
> This patch adds the NGR 200 Xbox 360 to the xpad device tree and also Acer's VendorID
> 
> Signed-off-by: Nilton Perim Neto <niltonperimneto@gmail.com>

Applied, thank you.

-- 
Dmitry

Re: [PATCH] xpad - Added Acer NGR 200 Controller

[Vicki Pfau]

Hi,

On 6/7/25 11:04 PM, Nilton Perim Neto wrote:
> This patch adds the NGR 200 Xbox 360 to the xpad device tree and also Acer's VendorID
> 
> Signed-off-by: Nilton Perim Neto <niltonperimneto@gmail.com>
> ---
>  drivers/input/joystick/xpad.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index 7746530da030..100aaaa7a5cb 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -177,6 +177,7 @@ static const struct xpad_device {
>  	{ 0x05fd, 0x107a, "InterAct 'PowerPad Pro' X-Box pad (Germany)", 0, XTYPE_XBOX },
>  	{ 0x05fe, 0x3030, "Chic Controller", 0, XTYPE_XBOX },
>  	{ 0x05fe, 0x3031, "Chic Controller", 0, XTYPE_XBOX },
> +	{ 0x0502, 0x1305, "Acer NGR200", 0, XTYPE_XBOX },

Shouldn't this be XTYPE_XBOX360?

>  	{ 0x062a, 0x0020, "Logic3 Xbox GamePad", 0, XTYPE_XBOX },
>  	{ 0x062a, 0x0033, "Competition Pro Steering Wheel", 0, XTYPE_XBOX },
>  	{ 0x06a3, 0x0200, "Saitek Racing Wheel", 0, XTYPE_XBOX },
> @@ -521,6 +522,7 @@ static const struct usb_device_id xpad_table[] = {
>  	XPAD_XBOX360_VENDOR(0x045e),		/* Microsoft Xbox 360 controllers */
>  	XPAD_XBOXONE_VENDOR(0x045e),		/* Microsoft Xbox One controllers */
>  	XPAD_XBOX360_VENDOR(0x046d),		/* Logitech Xbox 360-style controllers */
> +	XPAD_XBOX360_VENDOR(0x0502),		/* Acer Inc. Xbox 360 style controllers */
>  	XPAD_XBOX360_VENDOR(0x056e),		/* Elecom JC-U3613M */
>  	XPAD_XBOX360_VENDOR(0x06a3),		/* Saitek P3600 */
>  	XPAD_XBOX360_VENDOR(0x0738),		/* Mad Catz Xbox 360 controllers */

Vicki

[PATCH] Changed Acer NGR200 to XTYPE_XBOX360 fixed the table because

[Nilton Perim Neto]

You're correct Vicki
I wrote the wrong xtype in the device tree,
But now it is fine.

Signed-off-by: Nilton Perim Neto <niltonperimneto@gmail.com>
---
 drivers/input/joystick/xpad.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 7746530da030..bad4c3608775 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -177,6 +177,7 @@ static const struct xpad_device {
 	{ 0x05fd, 0x107a, "InterAct 'PowerPad Pro' X-Box pad (Germany)", 0, XTYPE_XBOX },
 	{ 0x05fe, 0x3030, "Chic Controller", 0, XTYPE_XBOX },
 	{ 0x05fe, 0x3031, "Chic Controller", 0, XTYPE_XBOX },
+	{ 0x0502, 0x1305, "Acer NGR200", 0, XTYPE_XBOX360 },
 	{ 0x062a, 0x0020, "Logic3 Xbox GamePad", 0, XTYPE_XBOX },
 	{ 0x062a, 0x0033, "Competition Pro Steering Wheel", 0, XTYPE_XBOX },
 	{ 0x06a3, 0x0200, "Saitek Racing Wheel", 0, XTYPE_XBOX },
-- 
2.50.0

Re: [PATCH] Changed Acer NGR200 to XTYPE_XBOX360 fixed the table because

[Greg KH]

On Tue, Jul 08, 2025 at 12:31:27AM -0300, Nilton Perim Neto wrote:
> You're correct Vicki
> I wrote the wrong xtype in the device tree,
> But now it is fine.

Very odd changelog text :(

Re: [PATCH] Changed Acer NGR200 to XTYPE_XBOX360 fixed the table because

[Vicki Pfau]

On 7/8/25 1:15 AM, Greg KH wrote:
> On Tue, Jul 08, 2025 at 12:31:27AM -0300, Nilton Perim Neto wrote:
>> You're correct Vicki
>> I wrote the wrong xtype in the device tree,
>> But now it is fine.
> 
> Very odd changelog text :(
> 

Yes, I'm not really sure what's going on there. It appears to be a replacement for an already-in-tree patch (22c69d786ef8 ("Input: xpad - support Acer NGR 200 Controller")), and won't apply on top of it. It's also worth noting that that patch put the entry in the wrong place in the table to begin with, so drafting up a new patch on top of the tree that fixes the table entry and moves it into the right place is probably the best way to proceed here instead.

Vicki

Re: Re: [PATCH] Changed Acer NGR200 to XTYPE_XBOX360 fixed the table because

[Nilton Perim Neto]

 Not sure how to procceed with it, I only want to fix my mistake, 
 However I'm fairly new to doing git over the mail list (I just use
 github/lab) It was previously on the wrong place and the wrong xtype, so I
 changed it Now it is on the right place on the tree and the correct 360 XTYPE
 Just want to correct those issues

Signed-off-by: Nilton Perim Neto <niltonperimneto@gmail.com>
---
 drivers/input/joystick/xpad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index bad4c3608775..a7953bf5e289 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -176,8 +176,8 @@ static const struct xpad_device {
 	{ 0x05fd, 0x1007, "Mad Catz Controller (unverified)", 0, XTYPE_XBOX },
 	{ 0x05fd, 0x107a, "InterAct 'PowerPad Pro' X-Box pad (Germany)", 0, XTYPE_XBOX },
 	{ 0x05fe, 0x3030, "Chic Controller", 0, XTYPE_XBOX },
-	{ 0x05fe, 0x3031, "Chic Controller", 0, XTYPE_XBOX },
 	{ 0x0502, 0x1305, "Acer NGR200", 0, XTYPE_XBOX360 },
+	{ 0x05fe, 0x3031, "Chic Controller", 0, XTYPE_XBOX },
 	{ 0x062a, 0x0020, "Logic3 Xbox GamePad", 0, XTYPE_XBOX },
 	{ 0x062a, 0x0033, "Competition Pro Steering Wheel", 0, XTYPE_XBOX },
 	{ 0x06a3, 0x0200, "Saitek Racing Wheel", 0, XTYPE_XBOX },
-- 
2.50.0

Re: Re: [PATCH] Changed Acer NGR200 to XTYPE_XBOX360 fixed the table because

[Greg KH]

On Tue, Jul 08, 2025 at 12:12:06PM -0300, Nilton Perim Neto wrote:
>  Not sure how to procceed with it, I only want to fix my mistake, 
>  However I'm fairly new to doing git over the mail list (I just use
>  github/lab) It was previously on the wrong place and the wrong xtype, so I
>  changed it Now it is on the right place on the tree and the correct 360 XTYPE
>  Just want to correct those issues

Please take a look at the kernel documentation for how to submit a
patch, it describes how to write this changelog in a format that will be
correct.

thanks,

greg k-h