linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Janne Grunau <j@jannau.net>
To: Sven Peter <sven@kernel.org>
Cc: "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
	"Neal Gompa" <neal@gompa.dev>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Srinivas Kandagatla" <srini@kernel.org>,
	"Andi Shyti" <andi.shyti@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Joerg Roedel" <joro@8bytes.org>, "Will Deacon" <will@kernel.org>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Martin Povišer" <povik+lin@cutebit.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>, "Arnd Bergmann" <arnd@arndb.de>,
	asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org,
	iommu@lists.linux.dev, linux-input@vger.kernel.org,
	dmaengine@vger.kernel.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH 00/11] Drop default ARCH_APPLE from Kconfig and use defconfig instead
Date: Fri, 13 Jun 2025 09:34:55 +0200	[thread overview]
Message-ID: <20250613073455.GF3141695@robin.jannau.net> (raw)
In-Reply-To: <20250612-apple-kconfig-defconfig-v1-0-0e6f9cb512c1@kernel.org>

Hej,

On Thu, Jun 12, 2025 at 09:11:24PM +0000, Sven Peter wrote:
> 
> When support for Apple Silicon was originally upstreamed we somehow
> started using `default ARCH_APPLE` for most drivers. arm64 defconfig
> also contains ARCH_APPLE=y such that this will turn into `default y`
> there by default which is neither what we want nor how this is usually
> done.

It's not such an uncommon pattern. `git grep 'default ARCH_' --
'*Kconfig'` has over 250 matches (not counting ARCH_APPLE) and from a
cursory look not all CONFIG_* look essential for booting.
I agree that the drivers covered here should not be built-in by default.
An alternative would be using `default m if ARCH_APPLE` instead but that
pattern is not common in the kernel. So just moving this to defconfig is
fine by me.

> Let's fix all that by dropping the default everywhere and adding the
> drivers to defconfig as modules instead of built-ins.
> None of these patches depend on each other so we can just take them all
> independently through the respective subsystem trees.
> 
> Best,
> 
> Sven
> 
> Signed-off-by: Sven Peter <sven@kernel.org>
> ---
> Sven Peter (11):
>       pmdomain: apple: Drop default ARCH_APPLE in Kconfig
>       soc: apple: Drop default ARCH_APPLE in Kconfig
>       clk: apple-nco: Drop default ARCH_APPLE in Kconfig
>       nvmem: apple: drop default ARCH_APPLE in Kconfig
>       i2c: apple: Drop default ARCH_APPLE in Kconfig
>       cpufreq: apple: drop default ARCH_APPLE in Kconfig
>       iommu/apple-dart: Drop default ARCH_APPLE in Kconfig
>       Input: apple_z2: Drop default ARCH_APPLE in Kconfig
>       dmaengine: apple-admac: Drop default ARCH_APPLE in Kconfig
>       ASoC: apple: mca: Drop default ARCH_APPLE in Kconfig
>       arm64: defconfig: Enable Apple Silicon drivers
> 
>  arch/arm64/configs/defconfig      | 19 +++++++++++++++++++
>  drivers/clk/Kconfig               |  1 -
>  drivers/cpufreq/Kconfig.arm       |  1 -
>  drivers/dma/Kconfig               |  1 -
>  drivers/i2c/busses/Kconfig        |  1 -
>  drivers/input/touchscreen/Kconfig |  1 -
>  drivers/iommu/Kconfig             |  1 -
>  drivers/nvmem/Kconfig             |  1 -
>  drivers/pmdomain/apple/Kconfig    |  1 -
>  drivers/soc/apple/Kconfig         |  3 ---
>  sound/soc/apple/Kconfig           |  1 -
>  11 files changed, 19 insertions(+), 12 deletions(-)

whole series

Reviewed-by: Janne Grunau <j@jannau.net>

  parent reply	other threads:[~2025-06-13  7:35 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12 21:11 [PATCH 00/11] Drop default ARCH_APPLE from Kconfig and use defconfig instead Sven Peter
2025-06-12 21:11 ` [PATCH 01/11] pmdomain: apple: Drop default ARCH_APPLE in Kconfig Sven Peter
2025-06-18 12:56   ` Ulf Hansson
2025-06-12 21:11 ` [PATCH 02/11] soc: " Sven Peter
2025-06-12 21:11 ` [PATCH 03/11] clk: apple-nco: " Sven Peter
2025-06-19 19:51   ` Stephen Boyd
2025-06-12 21:11 ` [PATCH 04/11] nvmem: apple: drop " Sven Peter
2025-06-12 21:11 ` [PATCH 05/11] i2c: apple: Drop " Sven Peter
2025-08-03 20:40   ` Wolfram Sang
2025-06-12 21:11 ` [PATCH 06/11] cpufreq: apple: drop " Sven Peter
2025-06-19  5:35   ` Viresh Kumar
2025-06-12 21:11 ` [PATCH 07/11] iommu/apple-dart: Drop " Sven Peter
2025-06-13 16:55   ` Robin Murphy
2025-06-27  7:00   ` Joerg Roedel
2025-06-12 21:11 ` [PATCH 08/11] Input: apple_z2: " Sven Peter
2025-06-17 22:18   ` Dmitry Torokhov
2025-06-12 21:11 ` [PATCH 09/11] dmaengine: apple-admac: " Sven Peter
2025-06-12 21:11 ` [PATCH 10/11] ASoC: apple: mca: " Sven Peter
2025-06-12 21:11 ` [PATCH 11/11] arm64: defconfig: Enable Apple Silicon drivers Sven Peter
2025-06-13 15:44   ` Nick Chan
2025-06-13 16:50   ` Robin Murphy
2025-06-21 16:01     ` Sven Peter
2025-06-23 11:33       ` Robin Murphy
2025-06-13  7:34 ` Janne Grunau [this message]
2025-06-14 11:12 ` (subset) [PATCH 00/11] Drop default ARCH_APPLE from Kconfig and use defconfig instead Mark Brown
2025-06-17 17:29 ` Vinod Koul
2025-06-22  9:13 ` Sven Peter
2025-06-27 10:49 ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250613073455.GF3141695@robin.jannau.net \
    --to=j@jannau.net \
    --cc=alyssa@rosenzweig.io \
    --cc=andi.shyti@kernel.org \
    --cc=arnd@arndb.de \
    --cc=asahi@lists.linux.dev \
    --cc=broonie@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=neal@gompa.dev \
    --cc=perex@perex.cz \
    --cc=povik+lin@cutebit.org \
    --cc=rafael@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=sboyd@kernel.org \
    --cc=srini@kernel.org \
    --cc=sven@kernel.org \
    --cc=tiwai@suse.com \
    --cc=ulf.hansson@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).